[language] Needs to stop using deprecated "icon"
Bug #1256017 reported by
Sebastien Bacher
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-system-settings (Ubuntu) |
Fix Released
|
High
|
William Hua |
Bug Description
The ui toolkit deprecated "icon" in favor of iconName and iconSource [1], the KeyboardLayouts code needs to be ported to something not deprecated.
The current code does "icon: Rectangle {...}" so we can't simply rename the property there, we need to find another solution.
[1] http://
Related branches
lp:~attente/ubuntu-system-settings/1256017
- PS Jenkins bot: Approve (continuous-integration)
- Sebastien Bacher (community): Approve
-
Diff: 153 lines (+83/-34)3 files modifiedplugins/language/CMakeLists.txt (+1/-0)
plugins/language/KeyboardLayoutItem.qml (+70/-0)
plugins/language/KeyboardLayouts.qml (+12/-34)
Changed in ubuntu-system-settings (Ubuntu): | |
status: | Confirmed → Fix Committed |
To post a comment you must log in.
Just for reference, the design is on https:/ /wiki.ubuntu. com/LanguageAnd Text#Phone: _.2BIBw- Keyboard_ layouts. 2BIB0_settings
We basically need a label in a rectangle in the list items