[MIR] ubuntu-system-settings-online-accounts

Bug #1612299 reported by Alberto Mardegan
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webapps-sprint
High
Alberto Mardegan
ubuntu-system-settings-online-accounts (Ubuntu)
Undecided
Unassigned

Bug Description

[Availability]
 * Available in universe

[Rationale]
 * This package is required by unity8

[Security]
 * No known security issues at this time. It has been reviewed by security in the past for use on the phone.

[Quality assurance]
 * This package has both unit tests and autopkgtests

[Dependencies]
 Most dependencies are already in main with the exception of the following:
 * libsystemsettings1, ubuntu-system-settings (bug #1612280)
 * qml-module-ubuntu-onlineaccounts (same source package as this one)
 * libonline-accounts-daemon1, qml-module-ubuntu-onlineaccounts (bug #1613575)
 * qtbase-opensource-src-gles (the non-gles variant is in main) (doesn't need a MIR?)

[Standards compliance]
 * This package uses qmake and is properly translated.

[Maintenance]
 * This package is maintained by Canonical and actively in use on the phone images

Alberto Mardegan (mardy)
Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: New → Incomplete
Alberto Mardegan (mardy)
description: updated
Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: Incomplete → New
David Barth (dbarth)
Changed in webapps-sprint:
assignee: nobody → Alberto Mardegan (mardy)
status: New → Triaged
importance: Undecided → High
milestone: none → sprint-26
Revision history for this message
Michael Terry (mterry) wrote :

- Needs a team bug subscriber, ideally from this list:
http://bazaar.launchpad.net/~ubuntu-archive/ubuntu-archive-tools/trunk/view/head:/package-subscribers#L107

- There are plenty of bugs, but I know this is a work in progress.

- The fix for bug 1608814 should land, so that we no longer ftbfs in -proposed.

- lintian error: dependency-is-not-multi-archified libonline-accounts-plugin-dev depends on ubuntu-system-settings-online-accounts (multi-arch: no) -- this is because you have libonline-accounts-plugin, a seemingly public library, installed into the main package along with the executables and data files. Is there a reason it's not in a separate library package like libonline-accounts-client1?

- I tried to build in a yakkety pbuilder chroot, but keep getting the test failure below. Is this a known issue or just some misconfiguration on my part?

task-0: ********* Start testing of UiProxyTest *********
task-0: Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160519)
task-0: PASS : UiProxyTest::initTestCase()
task-0: PASS : UiProxyTest::testInit()
task-0: QWARN : UiProxyTest::testRequest(success) QStandardPaths: wrong ownership on runtime directory /run/user/1001, -2 instead of 1234
task-0: QWARN : UiProxyTest::testRequest(success) Couldn't setup IPC socket
task-0: FAIL! : UiProxyTest::testRequest(success) '(!remoteProcesses.isEmpty())' returned FALSE. ()
task-0: Loc: [tst_ui_proxy.cpp(319)]
task-0: QWARN : UiProxyTest::testRequest(failure) QStandardPaths: wrong ownership on runtime directory /run/user/1001, -2 instead of 1234
task-0: QWARN : UiProxyTest::testRequest(failure) Couldn't setup IPC socket
task-0: FAIL! : UiProxyTest::testRequest(failure) '(!remoteProcesses.isEmpty())' returned FALSE. ()
task-0: Loc: [tst_ui_proxy.cpp(319)]
task-0: QWARN : UiProxyTest::testRequestDelay(no delay) QStandardPaths: wrong ownership on runtime directory /run/user/1001, -2 instead of 1234
task-0: QWARN : UiProxyTest::testRequestDelay(no delay) Couldn't setup IPC socket

** (dbus-test-runner:26648): WARNING **: Timing out at maximum wait of 30 seconds.

(dbus-test-runner:26648): libdbustest-CRITICAL **: dbus_test_service_run: assertion 'all_tasks(service, all_tasks_finished_helper, NULL)' failed
task-0: Shutting down

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: New → Incomplete
Revision history for this message
Alberto Mardegan (mardy) wrote : Re: [Bug 1612299] Re: [MIR] ubuntu-system-settings-online-accounts

On 08/16/2016 11:08 PM, Michael Terry wrote:
> - Needs a team bug subscriber, ideally from this list:
> http://bazaar.launchpad.net/~ubuntu-archive/ubuntu-archive-tools/trunk/view/head:/package-subscribers#L107

"ubuntu-webapps-bugs" will be it.

> - The fix for bug 1608814 should land, so that we no longer ftbfs in
> -proposed.

OK, I've put it in a silo.

> - lintian error: dependency-is-not-multi-archified libonline-accounts-
> plugin-dev depends on ubuntu-system-settings-online-accounts (multi-
> arch: no) -- this is because you have libonline-accounts-plugin, a
> seemingly public library, installed into the main package along with the
> executables and data files. Is there a reason it's not in a separate
> library package like libonline-accounts-client1?

It could be in a separate package, but I didn't do that because it's
mostly an internal library: the -dev package does not provide any
headers, its use is only providing a pkg-config file which defines a
variable.
The libonline-accounts-plugin.so is not directly used by other apps,
it's the backend for the Ubuntu.OnlineAccounts.Plugin QML module, which
is also implemented in the u-s-s-o-a package itself. Note that in
debian/control we have a "Provides" for a
qml-module-ubuntu-onlineaccounts-plugin.

Please let me know what's the best way to proceed; I'll now separate
this module into its own package, but let me know if there are simpler
ways to solve this.

> - I tried to build in a yakkety pbuilder chroot, but keep getting the
> test failure below. Is this a known issue or just some misconfiguration
> on my part?

Weird. I could reproduce the failure as well, and filed bug 1614108
about it. I've also added a workaround in our silo.

Revision history for this message
Michael Terry (mterry) wrote :

So about splitting libonline-accounts-plugin or not... If it's truly never linked externally, the simplest thing might be to drop the whole online-accounts-plugin section from the .pc file (but keep the plugin_qml_dir variable), drop its .so symlink, and drop its dependency on the main package.

If you can't do that (i.e. something external does want to link against the plugins library), the best thing is to split it into its own multiarch-able package.

---

Oh, and I'm now noticing two other lintian errors about calling out to public jquery:

E: qml-module-ubuntu-onlineaccounts-client-doc: privacy-breach-uses-embedded-file usr/share/online-accounts-client/doc/html/qml-setup-members.html You may use libjs-jquery package. (https://ajax.googleapis.com/ajax/libs/jquery/1.6.2/jquery.min.js)

E: qml-module-ubuntu-onlineaccounts-client-doc: privacy-breach-uses-embedded-file usr/share/online-accounts-client/doc/html/qml-setup.html You may use libjs-jquery package. (https://ajax.googleapis.com/ajax/libs/jquery/1.6.2/jquery.min.js)

I don't think these are blockers for main, but they should be fixed (I'm not sure why lintian doesn't care about the script/images from developer.ubuntu.com or the css from fonts.googleapis.com...).

Revision history for this message
Alberto Mardegan (mardy) wrote :

On 08/18/2016 06:45 PM, Michael Terry wrote:
> So about splitting libonline-accounts-plugin or not... If it's truly
> never linked externally, the simplest thing might be to drop the whole
> online-accounts-plugin section from the .pc file (but keep the
> plugin_qml_dir variable), drop its .so symlink, and drop its dependency
> on the main package.

I'm going for this option.

> Oh, and I'm now noticing two other lintian errors about calling out to
> public jquery:
[...]
> I don't think these are blockers for main, but they should be fixed (I'm
> not sure why lintian doesn't care about the script/images from
> developer.ubuntu.com or the css from fonts.googleapis.com...).

I had a look at the ubuntu-ui-tollkit, to see how it has solved this
issue, and it's not solved there either. Given that these HTML files are
not served locally, but are meant to be published on a website such as
developer.ubuntu.com, I don't think that the lintian warning applies in
this case.

Revision history for this message
Michael Terry (mterry) wrote :

OK, once you get a team subscribed to bugs and the silo lands, poke this bug and I'll top-approve.

Revision history for this message
David Barth (dbarth) wrote :

Hi Mike,

ubuntu-webapps-bugs is now subscribed to this bug and to all ubuntu/ussoa project bugs in the future.

Michael Terry (mterry)
Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Override component to main
ubuntu-system-settings-online-accounts 0.7+16.10.20160929-0ubuntu1 in yakkety amd64: universe/gnome/optional/100% -> main
ubuntu-system-settings-online-accounts 0.7+16.10.20160929-0ubuntu1 in yakkety arm64: universe/gnome/optional/100% -> main
ubuntu-system-settings-online-accounts 0.7+16.10.20160929-0ubuntu1 in yakkety armhf: universe/gnome/optional/100% -> main
ubuntu-system-settings-online-accounts 0.7+16.10.20160929-0ubuntu1 in yakkety i386: universe/gnome/optional/100% -> main
ubuntu-system-settings-online-accounts 0.7+16.10.20160929-0ubuntu1 in yakkety powerpc: universe/gnome/optional/100% -> main
ubuntu-system-settings-online-accounts 0.7+16.10.20160929-0ubuntu1 in yakkety ppc64el: universe/gnome/optional/100% -> main
6 publications overridden.

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: Fix Committed → Fix Released
Alberto Mardegan (mardy)
Changed in webapps-sprint:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers