does not check all required locks in is_package_system_locked

Bug #570583 reported by Michael Vogt on 2010-04-27
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-system-service (Ubuntu)
Medium
Michael Vogt
Lucid
Medium
Michael Vogt

Bug Description

Binary package hint: ubuntu-system-service

The dbus call for "is_package_system_locked" does not check all possible locks.

This can lead to update-notifier (that uses this interface) to auto-opening update-manager when there is
a package management operation already in progress. Its a bit of a corner case as most package managers
take /var/lib/dpkg/lock (and that is already tested). But should be fixed nevertheless.

TEST CASE:
 1. use lucid and log into desktop
 2. open two terminals
 3. run "while true; do apt-get update; done" in the first
 4. run "killall update-notifier; NO_FAKE_STAT=1 faketime -f +10d update-notifier" and verify that update-manager opens

 5. close the terminals
 6. install new ubuntu-system-servce and run "sudo killall system-service-d" to ensure the old one is gone
 7. run "gconftool --unset /apps/update-manager/launch_time" to ensure the launch time is reset
 8. repeat steps 3,4 and verify that update-manager does not open this time

 9. close the terminals that was opened in step 3
 10. repeat step 4, verify that update-manager now auto-opens

Michael Vogt (mvo) on 2010-04-27
Changed in ubuntu-system-service (Ubuntu Lucid):
status: New → Confirmed
importance: Undecided → Medium
milestone: none → lucid-updates
assignee: nobody → Michael Vogt (mvo)
Michael Vogt (mvo) wrote :

Fix is uploaded to lucid-proposed.

description: updated
description: updated
Changed in ubuntu-system-service (Ubuntu Lucid):
status: Confirmed → Fix Committed

Accepted ubuntu-system-service into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-service - 0.1.20.1

---------------
ubuntu-system-service (0.1.20.1) lucid-proposed; urgency=low

  * backend/system-service-d:
    - check for download lock files as well when running
      "is_package_system_locked" (LP: #570583)
 -- Michael Vogt <email address hidden> Tue, 27 Apr 2010 10:47:35 +0200

Changed in ubuntu-system-service (Ubuntu Lucid):
status: Fix Committed → Fix Released
Martin Pitt (pitti) wrote :

Copied lucid-proposed to maverick.

Changed in ubuntu-system-service (Ubuntu):
status: Fix Committed → Fix Released
Changed in ubuntu-system-service (Ubuntu Lucid):
status: Fix Released → Fix Committed
Paul Elliott (omahn) wrote :

I'm not sure 0.1.20.1 from lucid-proposed fixes the issue, after following the test case and installing the proposed package, update-manager does not appear at all on my system in the final step when issuing:

NO_FAKE_STAT=1 faketime -f +10d update-notifier

This is even when no other apt activity is (knowingly) running. Can you verify the test case steps are correct?

Paul Elliott (omahn) on 2010-05-13
tags: added: verification-failed
removed: verification-needed
Michael Vogt (mvo) wrote :

Thanks Paul for your verification effort and sorry for not getting back to you earlier. I just updated the testcase (it did not include a killall update-notifier). This lead to the problem that update-notifier was still running and the new one (with the faketime argument) would not start.

Could you (or someone else) please retry the verification with the updated instructions?

Thanks,
 Michael

description: updated
Changed in ubuntu-system-service (Ubuntu Lucid):
status: Fix Committed → In Progress
status: In Progress → Fix Committed
tags: added: verification-needed
removed: verification-failed
Martin Pitt (pitti) wrote :

Running the test case. I confirm that with the lucid-final version u-manager opens automatically, greys out, and just results in a crash report (_usr_bin_update-manager.1000.crash).

I upgraded u-s-s to lucid-proposed, downgraded another package (udisks) to final (so that there was still a reason to upgrade your system) and re-ran the test case. Without the apt-get loop, u-m runs automatically, as desired. With the apt-get loop, u-n does not auto-open until I control-c the apt-get update loop.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-service - 0.1.20.1

---------------
ubuntu-system-service (0.1.20.1) lucid-proposed; urgency=low

  * backend/system-service-d:
    - check for download lock files as well when running
      "is_package_system_locked" (LP: #570583)
 -- Michael Vogt <email address hidden> Tue, 27 Apr 2010 10:47:35 +0200

Changed in ubuntu-system-service (Ubuntu Lucid):
status: Fix Committed → Fix Released
tags: added: testcase
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers