do-release-upgrade failed silently after failed to connect to snap service

[Patrick Wu]

Multiple reports received for people trying to upgrade from Ubuntu 20.04 to Ubuntu 20.10 using `do-release-upgrade` on WSL failed silently. After digging, it is found that in DistUpgradeQuirks.py, DistUpgradeQuirks._checkStoreConnectivity won't check for the message thrown by `snap debug connectivity` which is complaining about the inability of connecting to `snapd` service:
`
> error: cannot communicate with server: Get "http://localhost/v2/debug?aspect=connectivity": dial unix /run/snapd.socket: connect: no such file or directory

This bug should affect all versions of packages especially 20.04 or higher (1:20.04.32).

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Logan Rosen (logan)]

This also impacts upgrading from 20.10 to 21.04. I was able to reproduce the issue in my local WSL2 install of Groovy.

[Daniel (sad1212fasdf)]

I can reproduce the issue on when trying to upgrade from Ubuntu 20.04.2 LTS to Ubuntu 21.04 using `do-release-upgrade` on WSL 2.

I don't get any real error output. The last this I see is a screen that shows only:

Reading cache

Checking package manager
Reading package lists... Done
Building dependency tree
Reading state information... Done
Hit http://archive.ubuntu.com/ubuntu focal InRelease
Hit http://archive.ubuntu.com/ubuntu focal-updates InRelease
Hit http://archive.ubuntu.com/ubuntu focal-backports InRelease
Hit http://security.ubuntu.com/ubuntu focal-security InRelease
Fetched 0 B in 0s (0 B/s)
Reading package lists... Done
Building dependency tree
Reading state information... Done

Restoring original system state

Aborting
Reading package lists... Done
Building dependency tree
Reading state information... Done
=== Command terminated with exit status 1 (Mon Jul 12 09:14:34 2021) ===

[Daniel (sad1212fasdf)]

PS, when I invoke `apt remove snapd` and run `do-release-upgrade` again, the upgrade completes successfully.

[Steve Dodd (anarchetic)]

Bug #1810565 related.

[Brian Murray (brian-murray)]

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-release-upgrader_22.04.2.dsc: done.
  Uploading ubuntu-release-upgrader_22.04.2.tar.xz: done.
  Uploading ubuntu-release-upgrader_22.04.2_source.buildinfo: done.
  Uploading ubuntu-release-upgrader_22.04.2_source.changes: done.
Successfully uploaded packages.

[Brian Murray (brian-murray)]

I'm happy to upload this to Impish but the bug will need an SRU template completed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-release-upgrader - 1:22.04.2

---------------
ubuntu-release-upgrader (1:22.04.2) jammy; urgency=medium

  [ Didier Roche ]
  * DistUpgrade/DistUpgradeQuirks.py: Only try to connect to snapd if there is
    a socket for system activation or if snapd was already running. This
    resolves failures to upgrade under WSL. (LP: #1926267)

 -- Brian Murray <email address hidden> Fri, 29 Oct 2021 09:59:29 -0700

[Brian Murray (brian-murray)]

Ubuntu 21.10 (Impish Indri) has reached end of life, so this bug will not be fixed for that specific release.