| 2020-07-25 01:28:03 |
Patricia Domingues |
bug |
|
|
added bug |
| 2020-07-25 01:30:23 |
Patricia Domingues |
attachment added |
|
attaching dist-upgrade/screenlog.0 https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+attachment/5395637/+files/screenlog.0 |
|
| 2020-07-25 01:32:12 |
Patricia Domingues |
summary |
upgrade from bionic to focal in a server with molly-guard moves back sources.list to bionic entries |
upgrade from bionic to focal a server with molly-guard moves back sources.list to bionic entries |
|
| 2020-07-29 20:14:00 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu): importance |
Undecided |
Medium |
|
| 2020-07-29 20:14:00 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu): status |
New |
Triaged |
|
| 2020-07-29 20:14:18 |
Brian Murray |
tags |
|
rls-gg-incoming |
|
| 2020-07-30 15:14:13 |
Brian Murray |
nominated for series |
|
Ubuntu Groovy |
|
| 2020-07-30 15:14:13 |
Brian Murray |
bug task added |
|
ubuntu-release-upgrader (Ubuntu Groovy) |
|
| 2020-07-30 15:39:33 |
Brian Murray |
tags |
rls-gg-incoming |
|
|
| 2020-07-31 15:22:23 |
Alexandre Erwin Ittner |
bug |
|
|
added subscriber Alexandre Erwin Ittner |
| 2020-08-01 12:32:38 |
Francis Ginther |
tags |
|
id-5f22e99071f5a889bf3c4734 |
|
| 2020-08-04 14:16:31 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Groovy): status |
Triaged |
Incomplete |
|
| 2020-08-04 23:14:08 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Groovy): assignee |
|
Brian Murray (brian-murray) |
|
| 2020-08-05 12:16:30 |
Patricia Domingues |
attachment added |
|
main.log https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+attachment/5398909/+files/main.log |
|
| 2020-08-06 23:55:22 |
Patricia Domingues |
attachment added |
|
/var/log/dist-upgrade/main.log https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+attachment/5399431/+files/main.log |
|
| 2020-08-06 23:57:23 |
Patricia Domingues |
attachment added |
|
apt-clone_system_state.tar.gz https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+attachment/5399432/+files/apt-clone_system_state.tar.gz |
|
| 2020-08-24 17:50:22 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Groovy): status |
Incomplete |
Confirmed |
|
| 2020-08-24 17:51:17 |
Brian Murray |
summary |
upgrade from bionic to focal a server with molly-guard moves back sources.list to bionic entries |
after upgrading running the upgrader again can restore your sources.list file to the previous release |
|
| 2020-08-24 23:41:37 |
Brian Murray |
summary |
after upgrading running the upgrader again can restore your sources.list file to the previous release |
after the upgrade completes reattaching to the screen session can restore your sources.list file |
|
| 2020-08-25 20:45:46 |
Brian Murray |
summary |
after the upgrade completes reattaching to the screen session can restore your sources.list file |
release upgrader can restore sources.list file from a previous release upgrade |
|
| 2020-08-25 20:58:31 |
Brian Murray |
description |
I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to Focal, with molly-guard installed on it - molly-guard configured to always ask for the hostname.
After it has finished:
```
System upgrade is complete.
Restart required
To finish the upgrade, a restart is required.
If you select 'y' the system will be restarted.
Continue [yN] y
I: molly-guard: reboot is always molly-guarded on this system.
Please type in hostname of the machine to reboot:
Good thing I asked; I won't reboot bates ...
=== Command detached from window (Tue Jul 21 15:23:36 2020) ===
=== Command terminated normally (Tue Jul 21 15:23:46 2020) ===
```
It doesn't alert you it was restoring original state of sources.list.
After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package. |
Impact
------
The distribution upgrader creates a backup of your sources.list named sources.list.distUpgrade before upgrading your system. This file is not cleaned up after the upgrade and under the right set of circumstances (re-attaching to a screen session which starts the dist-upgrade again, or having a strange sources.list file) the sources.list.distUpgrade file will be restored which can result in a mismatch between what you are running and what is in sources.list.
Test Case
---------
A simple test case is the following:
1) Copy /etc/apt/sources.list to /etc/apt/sources.list.distUpgrade
2) Modify /etc/apt/sources.list.distUpgrade to contain a previous release of Ubuntu e.g. 's/focal/eoan/'. (This simulates that you upgraded to your current release of Ubuntu.)
3) Modify /etc/apt/sources.list to contain the release you want to which you want to upgrade (strange right‽)
4) Run do-release-upgrade (with or w/o -d as necessary)
5) When prompted about "No valid sources.list entry found" choose not to upgrade
6) Observe that /etc/apt/sources.list has the same content as /etc/apt/sources.list.distUpgrade and that it doesn't match your current release.
With the version of the release upgrader in -proposed sources.list and sources.list.distUpgrade will still have the same content but it will be your current release.
A more involved test case would have one complete a release upgrade choose not to reboot then reattach to the screen session (by pressing r). After that they'd see the same thing as in Step 5 and Step 6 but given that its the same code path it seems unnecessary.
Regression Potential
--------------------
The fix involves backing up your sources.list file before presenting the error dialog regarding "No valid sources.list entry found". So its literally moving the same two lines before the dialog but the copy and paste could have gone wrong so be observant for any Tracebacks.
Original Description
--------------------
I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to Focal, with molly-guard installed on it - molly-guard configured to always ask for the hostname.
After it has finished:
```
System upgrade is complete.
Restart required
To finish the upgrade, a restart is required.
If you select 'y' the system will be restarted.
Continue [yN] y
I: molly-guard: reboot is always molly-guarded on this system.
Please type in hostname of the machine to reboot:
Good thing I asked; I won't reboot bates ...
=== Command detached from window (Tue Jul 21 15:23:36 2020) ===
=== Command terminated normally (Tue Jul 21 15:23:46 2020) ===
```
It doesn't alert you it was restoring original state of sources.list.
After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package. |
|
| 2020-08-25 21:46:29 |
Brian Murray |
nominated for series |
|
Ubuntu Focal |
|
| 2020-08-25 21:46:29 |
Brian Murray |
bug task added |
|
ubuntu-release-upgrader (Ubuntu Focal) |
|
| 2020-08-25 21:46:54 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Focal): status |
New |
Triaged |
|
| 2020-08-25 21:46:57 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Focal): importance |
Undecided |
High |
|
| 2020-08-26 06:16:18 |
Launchpad Janitor |
ubuntu-release-upgrader (Ubuntu Groovy): status |
Confirmed |
Fix Released |
|
| 2020-08-26 17:26:45 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Focal): status |
Triaged |
In Progress |
|
| 2020-08-26 17:26:49 |
Brian Murray |
ubuntu-release-upgrader (Ubuntu Focal): assignee |
|
Brian Murray (brian-murray) |
|
| 2020-08-26 17:39:50 |
Brian Murray |
description |
Impact
------
The distribution upgrader creates a backup of your sources.list named sources.list.distUpgrade before upgrading your system. This file is not cleaned up after the upgrade and under the right set of circumstances (re-attaching to a screen session which starts the dist-upgrade again, or having a strange sources.list file) the sources.list.distUpgrade file will be restored which can result in a mismatch between what you are running and what is in sources.list.
Test Case
---------
A simple test case is the following:
1) Copy /etc/apt/sources.list to /etc/apt/sources.list.distUpgrade
2) Modify /etc/apt/sources.list.distUpgrade to contain a previous release of Ubuntu e.g. 's/focal/eoan/'. (This simulates that you upgraded to your current release of Ubuntu.)
3) Modify /etc/apt/sources.list to contain the release you want to which you want to upgrade (strange right‽)
4) Run do-release-upgrade (with or w/o -d as necessary)
5) When prompted about "No valid sources.list entry found" choose not to upgrade
6) Observe that /etc/apt/sources.list has the same content as /etc/apt/sources.list.distUpgrade and that it doesn't match your current release.
With the version of the release upgrader in -proposed sources.list and sources.list.distUpgrade will still have the same content but it will be your current release.
A more involved test case would have one complete a release upgrade choose not to reboot then reattach to the screen session (by pressing r). After that they'd see the same thing as in Step 5 and Step 6 but given that its the same code path it seems unnecessary.
Regression Potential
--------------------
The fix involves backing up your sources.list file before presenting the error dialog regarding "No valid sources.list entry found". So its literally moving the same two lines before the dialog but the copy and paste could have gone wrong so be observant for any Tracebacks.
Original Description
--------------------
I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to Focal, with molly-guard installed on it - molly-guard configured to always ask for the hostname.
After it has finished:
```
System upgrade is complete.
Restart required
To finish the upgrade, a restart is required.
If you select 'y' the system will be restarted.
Continue [yN] y
I: molly-guard: reboot is always molly-guarded on this system.
Please type in hostname of the machine to reboot:
Good thing I asked; I won't reboot bates ...
=== Command detached from window (Tue Jul 21 15:23:36 2020) ===
=== Command terminated normally (Tue Jul 21 15:23:46 2020) ===
```
It doesn't alert you it was restoring original state of sources.list.
After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package. |
Impact
------
The distribution upgrader creates a backup of your sources.list named sources.list.distUpgrade before upgrading your system. This file is not cleaned up after the upgrade and under the right set of circumstances (re-attaching to a screen session which starts the dist-upgrade again, or having a strange sources.list file) the sources.list.distUpgrade file will be restored which can result in a mismatch between what you are running and what is in sources.list.
Test Case
---------
A simple test case is the following:
1) Copy /etc/apt/sources.list to /etc/apt/sources.list.distUpgrade
2) Modify /etc/apt/sources.list.distUpgrade to contain a previous release of Ubuntu e.g. 's/focal/eoan/'. (This simulates that you upgraded to your current release of Ubuntu.)
3) Modify /etc/apt/sources.list to contain the release to which you want to upgrade (strange right‽)
4) Run do-release-upgrade (with or w/o -d as necessary)
5) When prompted about "No valid sources.list entry found" choose not to upgrade
6) Observe that /etc/apt/sources.list has the same content as /etc/apt/sources.list.distUpgrade and that it doesn't match your current release.
With the version of the release upgrader in -proposed sources.list and sources.list.distUpgrade will still have the same content but it will be your current release.
A more involved test case would have one complete a release upgrade choose not to reboot then reattach to the screen session (by pressing r). After that they'd see the same thing as in Step 5 and Step 6 but given that its the same code path it seems unnecessary.
Regression Potential
--------------------
The fix involves backing up your sources.list file before presenting the error dialog regarding "No valid sources.list entry found". So its literally moving the same two lines before the dialog but the copy and paste could have gone wrong so be observant for any Tracebacks.
Original Description
--------------------
I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to Focal, with molly-guard installed on it - molly-guard configured to always ask for the hostname.
After it has finished:
```
System upgrade is complete.
Restart required
To finish the upgrade, a restart is required.
If you select 'y' the system will be restarted.
Continue [yN] y
I: molly-guard: reboot is always molly-guarded on this system.
Please type in hostname of the machine to reboot:
Good thing I asked; I won't reboot bates ...
=== Command detached from window (Tue Jul 21 15:23:36 2020) ===
=== Command terminated normally (Tue Jul 21 15:23:46 2020) ===
```
It doesn't alert you it was restoring original state of sources.list.
After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package. |
|
| 2020-08-27 12:33:15 |
Łukasz Zemczak |
ubuntu-release-upgrader (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2020-08-27 12:33:17 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-08-27 12:33:19 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2020-08-27 12:33:21 |
Łukasz Zemczak |
tags |
id-5f22e99071f5a889bf3c4734 |
id-5f22e99071f5a889bf3c4734 verification-needed verification-needed-focal |
|
| 2020-08-27 20:03:49 |
Patricia Domingues |
tags |
id-5f22e99071f5a889bf3c4734 verification-needed verification-needed-focal |
id-5f22e99071f5a889bf3c4734 verification-done-focal |
|
| 2020-08-28 12:40:18 |
Andrew Cloke |
bug |
|
|
added subscriber Andrew Cloke |
| 2020-09-01 02:55:42 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/390056 |
|
| 2020-09-03 13:12:55 |
Launchpad Janitor |
ubuntu-release-upgrader (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2020-09-03 13:13:04 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
