Activity log for bug #1841225

Date Who What changed Old value New value Message
2019-08-23 16:52:59 Brian Murray bug added bug
2019-08-23 16:53:12 Brian Murray tags eoan
2019-08-23 16:53:15 Brian Murray ubuntu-release-upgrader (Ubuntu): status New Triaged
2019-08-23 16:53:18 Brian Murray ubuntu-release-upgrader (Ubuntu): importance Undecided High
2019-08-23 16:53:51 Brian Murray nominated for series Ubuntu Eoan
2019-08-23 16:53:51 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Eoan)
2019-08-24 12:25:44 Francis Ginther tags eoan eoan id-5d601a1e1cecf13f82a7067a
2019-08-28 17:14:18 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Eoan): assignee Łukasz Zemczak (sil2100)
2019-08-30 17:04:55 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Eoan): status Triaged In Progress
2019-08-30 17:05:09 Łukasz Zemczak branch linked lp:~sil2100/ubuntu-release-upgrader/snap-core18-from-stable
2019-09-03 14:09:11 Łukasz Zemczak nominated for series Ubuntu Disco
2019-09-03 14:09:11 Łukasz Zemczak bug task added ubuntu-release-upgrader (Ubuntu Disco)
2019-09-04 16:22:53 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Eoan): status In Progress Fix Released
2019-09-05 10:05:31 Łukasz Zemczak description The release upgrader (DistUpgradeQuirks.py) tries to run the following command when upgrading a system without snaps installed to Ubuntu 19.10 (eoan): snap install --channel stable/ubuntu-19.10 core18 This channel does not exist and the release upgrade will fail e.g.: 2019-08-23 03:24:45,533 DEBUG quirks: running eoanPostUpgrade 2019-08-23 03:24:45,533 DEBUG running Quirks.eoanPostUpgrade 2019-08-23 03:24:51,547 DEBUG install of snap core18 failed 2019-08-23 03:25:51,348 DEBUG install of snap gnome-3-28-1804 succeeded The quirk should be updated so that an ubuntu release channel is not used when installing the core18 snap. [Impact] During distro upgrades, additional logic exists that replaces existing debs with snaps and refreshes existing, installed snaps to the branch of the series we're upgrading to (e.g. from stable/ubuntu-18.04 to stable/ubuntu-19.04 etc.). However, the upgrader tries to apply the logic for all the snaps it 'supports' in migration, even though snaps like core18 do not have per-series branches (and will never have). This causes non-fatal failures during installation/refresh of the core18 snap on upgrades. Even though this does not cause a crash or error, and in theory should should not cause any trouble as core18 *should* be pulled in as a dependency of the other snaps, it is invalid behavior and might result in core18 not being present on the end system. Upgrades should not perform commands that fail, if possible. [Test Case] * Prepare a bionic machine * Make sure ubuntu-desktop and snapd are installed on it * Make sure core18 is *not* installed on the system - if there are any snaps installed, remove them * Perform an upgrade to disco (with the --proposed option, to use disco-proposed) * Reboot * Make sure that the upgrade succeeded * Check if core18 is installed, open /var/log/dist-upgrade/main.log and look for 'install of snap core18', make sure the command succeeded [Regression Potential] The changes have been constrained to the DistUpgradeQuirks place, only to the snap handling pieces. So any possible regressions should be visible in the snap replacement/refresh areas. Most probable ones would be for the snaps not being installed/refreshed properly, or using the wrong channels/branches. [Original Description] The release upgrader (DistUpgradeQuirks.py) tries to run the following command when upgrading a system without snaps installed to Ubuntu 19.10 (eoan): snap install --channel stable/ubuntu-19.10 core18 This channel does not exist and the release upgrade will fail e.g.: 2019-08-23 03:24:45,533 DEBUG quirks: running eoanPostUpgrade 2019-08-23 03:24:45,533 DEBUG running Quirks.eoanPostUpgrade 2019-08-23 03:24:51,547 DEBUG install of snap core18 failed 2019-08-23 03:25:51,348 DEBUG install of snap gnome-3-28-1804 succeeded The quirk should be updated so that an ubuntu release channel is not used when installing the core18 snap.
2019-09-05 10:05:33 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Disco): importance Undecided Medium
2019-09-05 10:05:39 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Disco): status New In Progress
2019-09-30 17:00:55 Brian Murray ubuntu-release-upgrader (Ubuntu Disco): status In Progress Fix Committed
2019-09-30 17:00:59 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2019-09-30 17:01:00 Brian Murray bug added subscriber SRU Verification
2019-09-30 17:01:03 Brian Murray tags eoan id-5d601a1e1cecf13f82a7067a eoan id-5d601a1e1cecf13f82a7067a verification-needed verification-needed-disco
2019-10-09 13:47:58 Łukasz Zemczak tags eoan id-5d601a1e1cecf13f82a7067a verification-needed verification-needed-disco eoan id-5d601a1e1cecf13f82a7067a verification-done verification-done-disco
2019-10-09 17:18:14 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Disco): status Fix Committed Fix Released
2019-10-09 17:18:31 Brian Murray removed subscriber Ubuntu Stable Release Updates Team