Activity log for bug #1822886

Date Who What changed Old value New value Message
2019-04-02 21:12:16 Dean Henrichsmeyer bug added bug
2019-04-02 21:13:14 Dean Henrichsmeyer attachment added sources.list.distUpgrade https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1822886/+attachment/5252231/+files/sources.list.distUpgrade
2019-04-02 21:14:54 Steve Langasek ubuntu-release-upgrader (Ubuntu): importance Undecided Critical
2019-04-02 21:21:01 Steve Langasek summary universe missing after do-release-upgrade universe missing after bionic->cosmic do-release-upgrade
2019-04-02 21:43:07 Dean Henrichsmeyer attachment added main.log https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1822886/+attachment/5252256/+files/main.log
2019-04-03 00:22:21 Ubuntu Foundations Team Bug Bot tags amd64 apport-bug disco dist-upgrade amd64 apport-bug cosmic2disco disco dist-upgrade
2019-04-03 12:38:34 Francis Ginther tags amd64 apport-bug cosmic2disco disco dist-upgrade amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67
2019-04-03 17:43:09 Steve Langasek tags amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update
2019-04-05 00:12:37 Brian Murray ubuntu-release-upgrader (Ubuntu): status New In Progress
2019-04-05 00:12:44 Brian Murray ubuntu-release-upgrader (Ubuntu): assignee Brian Murray (brian-murray)
2019-04-05 01:15:06 Launchpad Janitor branch linked lp:ubuntu-release-upgrader
2019-04-05 15:18:16 Launchpad Janitor ubuntu-release-upgrader (Ubuntu): status In Progress Fix Released
2019-04-05 17:11:54 Brian Murray branch linked lp:~brian-murray/ubuntu-release-upgrader/better-uri-testing
2019-04-05 17:15:39 Brian Murray nominated for series Ubuntu Cosmic
2019-04-05 17:15:39 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Cosmic)
2019-04-05 17:15:39 Brian Murray nominated for series Ubuntu Bionic
2019-04-05 17:15:39 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Bionic)
2019-04-05 17:15:48 Brian Murray ubuntu-release-upgrader (Ubuntu Bionic): importance Undecided Critical
2019-04-05 17:15:50 Brian Murray ubuntu-release-upgrader (Ubuntu Cosmic): importance Undecided Critical
2019-04-05 22:31:08 Brian Murray ubuntu-release-upgrader (Ubuntu Bionic): status New Triaged
2019-04-05 22:31:11 Brian Murray ubuntu-release-upgrader (Ubuntu Cosmic): status New Triaged
2019-04-11 18:24:30 Brian Murray description I took a bionic system and stepped through bionic->cosmic->disco via do-release-upgrade. Upon finishing I noticed that universe was "gone" and all packages from universe were removed from the system. Based on the files on my system, it looks like it happened during the bionic->cosmic upgrade. You'll see in the sources.list that cosmic-updates universe pocket is that but not cosmic universe. ProblemType: Bug DistroRelease: Ubuntu 19.04 Package: ubuntu-release-upgrader-core 1:19.04.13 ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1 Uname: Linux 5.0.0-8-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.20.10-0ubuntu23 Architecture: amd64 CrashDB: ubuntu CurrentDesktop: ubuntu:GNOME Date: Tue Apr 2 16:04:34 2019 InstallationDate: Installed on 2018-07-24 (252 days ago) InstallationMedia: Ubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180724) PackageArchitecture: all ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=<set> LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: ubuntu-release-upgrader Symptom: ubuntu-release-upgrader UpgradeStatus: Upgraded to disco on 2019-04-02 (0 days ago) VarLogDistupgradeXorgFixuplog: INFO:root:/usr/bin/do-release-upgrade running INFO:root:No xorg.conf, exiting mtime.conffile..etc.update-manager.release-upgrades: 2019-04-02T08:18:06.798258 [Impact] If there is a network hiccup at the right moment it's possible that some sources.list entries will be disabled when a release upgrade is calculated and then people could upgrade with surprising results e.g. universe being missing. [Test Case] This is somewhat convoluted as we need to create the network error only when a specific line is is being tested by the dist-upgrader. 1) Use a system on xenial or bionic and ensure prompt is set appropriately (lts for xenial, normal for bionic) 2) Edit your /etc/apt/sources.list file so that universe is a separate line from main, restricted, and multiverse 3) Run do-release-upgrade 4) Cancel the release upgrade 5) cd to /tmp/ubuntu-release-upgrader-$tmpname 6) edit DistUpgradeController.py with the attached patch which will cause the url check for the universe line to fail 7) run 'sudo ./$release-upgrading-to' 8) wait until you receive the message regarding quantities of packages to install, upgrade, etc 9) look at /etc/apt/sources.list file and notice that the lines with universe are disabled With the release-upgrader from -proposed you'll need to follow the same steps and you'll notice that the lines with universe are not disabled. [Regression Potential] Because we are checking each unique uri in sources.list only one time its possible that if the first check fails then the upgrade will fail to be calculated. That is better than upgrading and having components disabled though. I took a bionic system and stepped through bionic->cosmic->disco via do-release-upgrade. Upon finishing I noticed that universe was "gone" and all packages from universe were removed from the system. Based on the files on my system, it looks like it happened during the bionic->cosmic upgrade. You'll see in the sources.list that cosmic-updates universe pocket is that but not cosmic universe. ProblemType: BugDistroRelease: Ubuntu 19.04 Package: ubuntu-release-upgrader-core 1:19.04.13 ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1 Uname: Linux 5.0.0-8-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.20.10-0ubuntu23 Architecture: amd64 CrashDB: ubuntu CurrentDesktop: ubuntu:GNOME Date: Tue Apr 2 16:04:34 2019 InstallationDate: Installed on 2018-07-24 (252 days ago) InstallationMedia: Ubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180724) PackageArchitecture: all ProcEnviron:  TERM=xterm  PATH=(custom, no user)  XDG_RUNTIME_DIR=<set>  LANG=en_US.UTF-8  SHELL=/bin/bashSourcePackage: ubuntu-release-upgrader Symptom: ubuntu-release-upgrader UpgradeStatus: Upgraded to disco on 2019-04-02 (0 days ago) VarLogDistupgradeXorgFixuplog:  INFO:root:/usr/bin/do-release-upgrade running  INFO:root:No xorg.conf, exiting mtime.conffile..etc.update-manager.release-upgrades: 2019-04-02T08:18:06.798258
2019-04-11 18:25:28 Brian Murray attachment added changes to DistUpgradeController for testing https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1822886/+attachment/5254979/+files/bug-1822886-test-case.patch
2019-04-11 20:08:43 Łukasz Zemczak description [Impact] If there is a network hiccup at the right moment it's possible that some sources.list entries will be disabled when a release upgrade is calculated and then people could upgrade with surprising results e.g. universe being missing. [Test Case] This is somewhat convoluted as we need to create the network error only when a specific line is is being tested by the dist-upgrader. 1) Use a system on xenial or bionic and ensure prompt is set appropriately (lts for xenial, normal for bionic) 2) Edit your /etc/apt/sources.list file so that universe is a separate line from main, restricted, and multiverse 3) Run do-release-upgrade 4) Cancel the release upgrade 5) cd to /tmp/ubuntu-release-upgrader-$tmpname 6) edit DistUpgradeController.py with the attached patch which will cause the url check for the universe line to fail 7) run 'sudo ./$release-upgrading-to' 8) wait until you receive the message regarding quantities of packages to install, upgrade, etc 9) look at /etc/apt/sources.list file and notice that the lines with universe are disabled With the release-upgrader from -proposed you'll need to follow the same steps and you'll notice that the lines with universe are not disabled. [Regression Potential] Because we are checking each unique uri in sources.list only one time its possible that if the first check fails then the upgrade will fail to be calculated. That is better than upgrading and having components disabled though. I took a bionic system and stepped through bionic->cosmic->disco via do-release-upgrade. Upon finishing I noticed that universe was "gone" and all packages from universe were removed from the system. Based on the files on my system, it looks like it happened during the bionic->cosmic upgrade. You'll see in the sources.list that cosmic-updates universe pocket is that but not cosmic universe. ProblemType: BugDistroRelease: Ubuntu 19.04 Package: ubuntu-release-upgrader-core 1:19.04.13 ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1 Uname: Linux 5.0.0-8-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.20.10-0ubuntu23 Architecture: amd64 CrashDB: ubuntu CurrentDesktop: ubuntu:GNOME Date: Tue Apr 2 16:04:34 2019 InstallationDate: Installed on 2018-07-24 (252 days ago) InstallationMedia: Ubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180724) PackageArchitecture: all ProcEnviron:  TERM=xterm  PATH=(custom, no user)  XDG_RUNTIME_DIR=<set>  LANG=en_US.UTF-8  SHELL=/bin/bashSourcePackage: ubuntu-release-upgrader Symptom: ubuntu-release-upgrader UpgradeStatus: Upgraded to disco on 2019-04-02 (0 days ago) VarLogDistupgradeXorgFixuplog:  INFO:root:/usr/bin/do-release-upgrade running  INFO:root:No xorg.conf, exiting mtime.conffile..etc.update-manager.release-upgrades: 2019-04-02T08:18:06.798258 [Impact] If there is a network hiccup at the right moment it's possible that some sources.list entries will be disabled when a release upgrade is calculated and then people could upgrade with surprising results e.g. universe being missing. [Test Case] This is somewhat convoluted as we need to create the network error only when a specific line is is being tested by the dist-upgrader. 1) Use a system on xenial or bionic and ensure prompt is set appropriately (lts for xenial, normal for bionic) 2) Edit your /etc/apt/sources.list file so that universe is a separate line from main, restricted, and multiverse 3) Run do-release-upgrade 4) Cancel the release upgrade 5) cd to /tmp/ubuntu-release-upgrader-$tmpname 6) edit DistUpgradeController.py with the attached patch which will cause the url check for the universe line to fail 7) run 'sudo ./$release-upgrading-to' 8) wait until you receive the message regarding quantities of packages to install, upgrade, etc 9) look at /etc/apt/sources.list file and notice that the lines with universe are disabled With the release-upgrader from -proposed you'll need to follow the same steps and you'll notice that the lines with universe are not disabled. [Regression Potential] Because we are checking each unique uri in sources.list only one time its possible that if the first check fails then the upgrade will fail to be calculated. That is better than upgrading and having components disabled though. [Original Description] I took a bionic system and stepped through bionic->cosmic->disco via do-release-upgrade. Upon finishing I noticed that universe was "gone" and all packages from universe were removed from the system. Based on the files on my system, it looks like it happened during the bionic->cosmic upgrade. You'll see in the sources.list that cosmic-updates universe pocket is that but not cosmic universe. ProblemType: BugDistroRelease: Ubuntu 19.04 Package: ubuntu-release-upgrader-core 1:19.04.13 ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1 Uname: Linux 5.0.0-8-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.20.10-0ubuntu23 Architecture: amd64 CrashDB: ubuntu CurrentDesktop: ubuntu:GNOME Date: Tue Apr 2 16:04:34 2019 InstallationDate: Installed on 2018-07-24 (252 days ago) InstallationMedia: Ubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180724) PackageArchitecture: all ProcEnviron:  TERM=xterm  PATH=(custom, no user)  XDG_RUNTIME_DIR=<set>  LANG=en_US.UTF-8  SHELL=/bin/bashSourcePackage: ubuntu-release-upgrader Symptom: ubuntu-release-upgrader UpgradeStatus: Upgraded to disco on 2019-04-02 (0 days ago) VarLogDistupgradeXorgFixuplog:  INFO:root:/usr/bin/do-release-upgrade running  INFO:root:No xorg.conf, exiting mtime.conffile..etc.update-manager.release-upgrades: 2019-04-02T08:18:06.798258
2019-04-11 20:12:38 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Cosmic): status Triaged Fix Committed
2019-04-11 20:12:39 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-04-11 20:12:40 Łukasz Zemczak bug added subscriber SRU Verification
2019-04-11 20:12:42 Łukasz Zemczak tags amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update verification-needed verification-needed-cosmic
2019-04-11 20:18:13 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Bionic): status Triaged Fix Committed
2019-04-11 20:18:17 Łukasz Zemczak tags amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update verification-needed verification-needed-cosmic amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update verification-needed verification-needed-bionic verification-needed-cosmic
2019-04-15 17:17:31 Brian Murray tags amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update verification-needed verification-needed-bionic verification-needed-cosmic amd64 apport-bug cosmic2disco disco dist-upgrade id-5ca3d1e6bc6a797ad8a39c67 regression-update verification-done verification-done-bionic verification-done-cosmic
2019-04-15 18:35:56 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Cosmic): status Fix Committed Fix Released
2019-04-15 18:36:02 Steve Langasek removed subscriber Ubuntu Stable Release Updates Team
2019-04-17 19:03:06 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Bionic): status Fix Committed Fix Released