Activity log for bug #1786484

Date Who What changed Old value New value Message
2018-08-10 13:48:54 Carlo Wood bug added bug
2018-08-10 16:20:23 Ubuntu Foundations Team Bug Bot tags amd64 apport-bug bionic dist-upgrade amd64 apport-bug bionic dist-upgrade xenial2bionic
2018-08-10 16:20:25 Ubuntu Foundations Team Bug Bot tags amd64 apport-bug bionic dist-upgrade xenial2bionic amd64 apport-bug bionic dist-upgrade third-party-packages xenial2bionic
2018-11-26 19:58:24 Brian Murray ubuntu-release-upgrader (Ubuntu): importance Undecided High
2018-11-26 19:58:29 Brian Murray bug added subscriber Brian Murray
2018-11-26 20:46:05 Brian Murray ubuntu-release-upgrader (Ubuntu): status New Incomplete
2018-11-28 19:09:17 Brian Murray summary Updater doesn't check size of partitions. free space need for /usr could be negative which is wrong
2018-11-28 19:10:19 Brian Murray ubuntu-release-upgrader (Ubuntu): status Incomplete In Progress
2018-11-28 19:10:23 Brian Murray ubuntu-release-upgrader (Ubuntu): assignee Brian Murray (brian-murray)
2018-11-28 19:13:08 Launchpad Janitor branch linked lp:ubuntu-release-upgrader
2018-12-13 15:43:07 Launchpad Janitor ubuntu-release-upgrader (Ubuntu): status In Progress Fix Released
2018-12-21 21:08:55 Brian Murray description In my case I ran out of diskspace in /usr which required a temporary 4 GB of more data during upgrade. Things just start to fail, and I can tell you - then you are screwed. I find this unacceptable for a wide-spread official LTS upgrader. ProblemType: Bug DistroRelease: Ubuntu 18.04 Package: ubuntu-release-upgrader-core 1:18.04.22 ProcVersionSignature: Ubuntu 4.15.0-30.32-generic 4.15.18 Uname: Linux 4.15.0-30-generic x86_64 NonfreeKernelModules: nvidia_modeset nvidia ApportVersion: 2.20.9-0ubuntu7.2 Architecture: amd64 CrashDB: ubuntu CurrentDesktop: KDE Date: Fri Aug 10 15:14:33 2018 InstallationDate: Installed on 2016-01-11 (941 days ago) InstallationMedia: Kubuntu 14.04.3 LTS "Trusty Tahr" - Beta amd64 (20150805) PackageArchitecture: all SourcePackage: ubuntu-release-upgrader Symptom: release-upgrade UpgradeStatus: Upgraded to bionic on 2018-08-09 (0 days ago) mtime.conffile..etc.update-manager.release-upgrades: 2018-08-06T15:08:30.181962 [Impact] The checkFreeSpace function doesn't ensure that the space needed is a positive number thereby causing a situation where a partition, like /usr, doesn't have enough free space which then results in a failure during upgrade. [Test Case] It's not clear to me how to recreate this scenario, however I believe this falls into the "obviously safe" patch category. The specific change to checkFreeSpace, which is described as "this checks if we have enough free space", from DistUpgradeCache.py follows: 1200 # we are ensuring we have more than enough free space not less 1201 if size < 0: 1202 continue This stops the needed space from being a negative number. [Regression Potential] Other than a typo in the change there won't be any. [Original Description] In my case I ran out of diskspace in /usr which required a temporary 4 GB of more data during upgrade. Things just start to fail, and I can tell you - then you are screwed. I find this unacceptable for a wide-spread official LTS upgrader. ProblemType: BugDistroRelease: Ubuntu 18.04 Package: ubuntu-release-upgrader-core 1:18.04.22 ProcVersionSignature: Ubuntu 4.15.0-30.32-generic 4.15.18 Uname: Linux 4.15.0-30-generic x86_64 NonfreeKernelModules: nvidia_modeset nvidia ApportVersion: 2.20.9-0ubuntu7.2 Architecture: amd64 CrashDB: ubuntu CurrentDesktop: KDE Date: Fri Aug 10 15:14:33 2018 InstallationDate: Installed on 2016-01-11 (941 days ago) InstallationMedia: Kubuntu 14.04.3 LTS "Trusty Tahr" - Beta amd64 (20150805) PackageArchitecture: allSourcePackage: ubuntu-release-upgrader Symptom: release-upgrade UpgradeStatus: Upgraded to bionic on 2018-08-09 (0 days ago) mtime.conffile..etc.update-manager.release-upgrades: 2018-08-06T15:08:30.181962
2019-01-08 16:29:40 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Cosmic): status New Fix Committed
2019-01-08 16:29:41 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-01-08 16:29:43 Łukasz Zemczak bug added subscriber SRU Verification
2019-01-08 16:29:45 Łukasz Zemczak tags amd64 apport-bug bionic dist-upgrade third-party-packages xenial2bionic amd64 apport-bug bionic dist-upgrade third-party-packages verification-needed verification-needed-cosmic xenial2bionic
2019-01-14 16:42:40 Brian Murray tags amd64 apport-bug bionic dist-upgrade third-party-packages verification-needed verification-needed-cosmic xenial2bionic amd64 apport-bug bionic dist-upgrade third-party-packages verification-done verification-done-cosmic xenial2bionic
2019-01-15 23:48:41 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Cosmic): status Fix Committed Fix Released
2019-01-15 23:48:57 Chris Halse Rogers removed subscriber Ubuntu Stable Release Updates Team
2019-01-22 17:45:53 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Bionic): status New Fix Committed
2019-01-22 17:45:55 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-01-22 17:45:59 Łukasz Zemczak tags amd64 apport-bug bionic dist-upgrade third-party-packages verification-done verification-done-cosmic xenial2bionic amd64 apport-bug bionic dist-upgrade third-party-packages verification-done-cosmic verification-needed verification-needed-bionic xenial2bionic
2019-01-23 16:38:30 Brian Murray tags amd64 apport-bug bionic dist-upgrade third-party-packages verification-done-cosmic verification-needed verification-needed-bionic xenial2bionic amd64 apport-bug bionic dist-upgrade third-party-packages verification-done verification-done-bionic verification-done-cosmic xenial2bionic
2019-01-31 09:20:22 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Bionic): status Fix Committed Fix Released