17.10 upgrade should mark ubuntu-gnome-desktop for removal

[Jeremy Bícha]

ubuntu-gnome-desktop now depends on ubuntu-desktop.

I think we should remove ubuntu-gnome-desktop when a user upgrades to 17.10 or 18.04.

Also, upgrading from 17.04 says that "Ubuntu-gnome 17.10" is now available." It would be nice if it would just say "Ubuntu 17.10 is now available".

[Brian Murray (brian-murray)]

The second part of this bug is actually about a string from update-manager and it uses "flavor_name" from UpdateManager/Core/utils.py which guesses it by looking for a package which ends with '-desktop'. There is a lookup in the get_ubuntu_flavor_name function you could add an override for ubuntu-gnome-deskotp and SRU to 17.04.

[Brian Murray (brian-murray)]

For the first part I think we can use DistUpgrade.cfg and put ubuntu-gnome-desktop in the ForcedObsoletes section for either ubuntu-gnome-desktop or it and ubuntu-desktop. I'll test this out now.

[Mathieu Trudel-Lapierre (cyphermox)]

Shouldn't that simply be handled by proper dependencies across the relevant packages? If ubuntu-desktop Breaks/Replaces ubuntu-gnome-desktop, you shouldn't need to do any special handling in u-r-u.

[Brian Murray (brian-murray)]

Putting it in ForcedObsoletes did not work because ubuntu-gnome-desktop also exists in data/removal_blacklist.cfg. Additionally, cyphermox is of the opinion that if the debian control fields are setup properly for this the autoremoval should happen anyway although it probably also needs removing from data/removal_blacklist.cfg so I'll handle that.

[Jeremy Bícha (jbicha)]

Did you forget to try removing it from the removal_blacklist.cfg?

[Brian Murray (brian-murray)]

I tested this upgrade again with ubuntu-gnome-desktop in data/removal_blacklist.cfg but not in ForcedObsoletes and this also did not cause it to be removed.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Brian Murray (brian-murray)]

I reported bug 1768620 regarding the removal_blacklist.cfg file being out of date and dropped ubuntu-gnome-desktop from that file.