broken translations results in traceback in new release notification

[Brian Murray]

[Test Case]
1) Install one of the affected languages
2) Make it the primary language
3) In a terminal run '/usr/lib/ubuntu-release-upgrader/check-new-release-gtk' for saucy
   In a terminal run '/usr/lib/update-manager/check-new-release-gtk -d' for precise
4) Observe a Traceback ending in a "ValueError: incomplete format" in precise the traceback says "ValueError: unsupported format character"

With the language pack from -proposed you should not see a Traceback, but rather a notification window about the new release of Ubuntu.

The error bucket at https://errors.ubuntu.com/problem/50c8f7b892dd75b531ac7d68a07ec11541387013 contains the following traceback.

Traceback (most recent call last):
  File "/usr/lib/ubuntu-release-upgrader/check-new-release-gtk", line 113, in new_dist_available
    self.window_main.set_title(_("Ubuntu %(version)s Upgrade Available") % {'version': new_dist.version})
ValueError: incomplete format

This is due to a bad translation for the Croatian (hr) language.

https://translations.launchpad.net/ubuntu/saucy/+source/ubuntu-release-upgrader/+pots/ubuntu-release-upgrader/hr/+translate?batch=10&show=all&search=Upgrade+Available

"Dostupna nadogradnja Ubuntu %(version)"

Notice the missing s after version. This is causing check-new-release-gtk to fail to notify users of a new release.

[Brian Murray (brian-murray)]

It looks like hr is not the only language with an issue.

 $ grep -r "%(version) " *
po/id.po:msgstr "Peningkatan ke Ubuntu %(version) Tersedia"
po/eo.po:msgstr "Ĝisdatigoj por Ubuntu %(version) disponeblas"
po/ug.po:msgstr "ئۇبۇنتۇ %(version) نىڭ يۈكسەلدۈرمىسى بار ئىكەن"

[Brian Murray (brian-murray)]

And precise (although it is update-manager) has issues too.

[ 10:31AM ] [ bdmurray@impulse:~/source-trees/update-manager/precise-proposed ]
 $ grep -r "%(version) " *
po/ja.po:msgstr "Ubuntu %(version) のアップグレードが利用可能です"
po/id.po:msgstr "Peningkatan ke Ubuntu %(version) Tersedia"
po/eo.po:msgstr "Ĝisdatigoj por Ubuntu %(version) disponeblas"
po/ug.po:msgstr "ئۇبۇنتۇ %(version) نىڭ يۈكسەلدۈرمىسى بار ئىكەن"

[Adam Conrad (adconrad)]

Hello Brian, or anyone else affected,

Accepted update-manager into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/update-manager/1:0.156.14.14 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Adam Conrad (adconrad)]

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.205.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Ubuntu Foundations Team Bug Bot (crichton)]

As a part of the Stable Release Updates quality process a search for Launchpad bug reports using the version of ubuntu-release-upgrader from saucy-proposed was performed and bug 1313447 was found. Please investigate this bug report to ensure that a regression will not be created by this SRU. In the event that this is not a regression remove the "verification-failed" tag from this bug report and tag 1313447 "bot-stop-nagging". Thanks!

[Brian Murray (brian-murray)]

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.220.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-release-upgrader - 1:14.10.2

---------------
ubuntu-release-upgrader (1:14.10.2) utopic; urgency=low

  * debian/test/control:
    - add missing pep8 test dependency
  * tests/test_xorg_fix_intrepid.py:
    -
 -- Michael Vogt <email address hidden> Sat, 03 May 2014 08:37:51 +0200

[Mathew Hodson (mathew-hodson)]

Is there a way to test the ubuntu-release-upgrader in trusty-proposed on a machine with trusty already installed?

[Jean-Baptiste Lallement (jibel)]

I tried update-manager 1:0.156.14.14 from precise-proposed and verification failed with Indonesian

# apt-cache policy update-manager
update-manager:
  Terpasang: 1:0.156.14.14
  Kandidat: 1:0.156.14.14
  Tabel versi:
 *** 1:0.156.14.14 0
        500 http://fr.archive.ubuntu.com/ubuntu/ precise-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     1:0.156.14.13 0
        500 http://fr.archive.ubuntu.com/ubuntu/ precise-updates/main amd64 Packages
     1:0.156.14.5 0
        500 http://security.ubuntu.com/ubuntu/ precise-security/main amd64 Packages
     1:0.156.14 0
        500 http://fr.archive.ubuntu.com/ubuntu/ precise/main amd64 Packages
root@ubuntu:~# /usr/lib/update-manager/check-new-release-gtk -d
Traceback (most recent call last):
  File "/usr/lib/update-manager/check-new-release-gtk", line 90, in new_dist_available
    self.window_main.set_title(_("Ubuntu %(version)s Upgrade Available") % {'version': new_dist.version})
ValueError: unsupported format character 'T' (0x54) at index 33

[Jean-Baptiste Lallement (jibel)]

I verified ubuntu-release-upgrader 1:0.220.3 from trusty-proposed with Indonesian and the same crash occurs.

# apt-cache policy ubuntu-release-upgrader-gtk
ubuntu-release-upgrader-gtk:
  Terpasang: 1:0.220.3
  Kandidat: 1:0.220.3
  Tabel versi:
 *** 1:0.220.3 0
        500 http://fr.archive.ubuntu.com/ubuntu/ trusty-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     1:0.220.2 0
        500 http://fr.archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages
root@ubuntu:~# /usr/lib/ubuntu-release-upgrader/check-new-release-gtk -d
Traceback (most recent call last):
  File "/usr/lib/ubuntu-release-upgrader/check-new-release-gtk", line 113, in new_dist_available
    self.window_main.set_title(_("Ubuntu %(version)s Upgrade Available") % {'version': new_dist.version})
ValueError: unsupported format character 'T' (0x54) at index 33

[Jean-Baptiste Lallement (jibel)]

Actually in Trusty it's a translation fix, I tried language-pack-id and language-pack-gnome-id 1:14.04+20140522 from trusty-proposed and it fixes the problem.

[Jean-Baptiste Lallement (jibel)]

I cannot do the verification in Precise because the new langpacks for eo, id, ja and ug are not in precise-proposed.

[Jean-Baptiste Lallement (jibel)]

Closing update-manager tasks, the fix is in the language packs.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:0.156.14.15

---------------
update-manager (1:0.156.14.15) precise-proposed; urgency=low

  * support HardwareEnablement End-of-Life transition
    (LP: #1333728)
 -- Michael Vogt <email address hidden> Tue, 24 Jun 2014 16:32:25 +0200

[Mathew Hodson (mathew-hodson)]

New langpack for ja is in precise-proposed.

[Brian Murray (brian-murray)]

Given that the change is in the language packs and not in ubuntu-release-upgrader this bug should not block the SRU or ubuntu-rlelease-upgrader, so I am setting the bug to verification-done.

[Steve Langasek (vorlon)]

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:0.220.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-release-upgrader - 1:0.220.4

---------------
ubuntu-release-upgrader (1:0.220.4) trusty-proposed; urgency=low

  * DistUpgrade/DistUpgradeCache.py:
    - fix crash in free space check for certain locales (LP: #1172740)
    - removal of essential packages that are not in the main arch
      is ok (LP: #1307904)
    - fix str/unicode crash in certain locales when a package is
      found in the removal blacklist (LP: #1310053)
  * DistUpgrade/DistUpgradeViewGtk3.py:
   - make details dialog resize when details are expanded/collapsed
     (LP: #1072460)
    - load webkit only when needed
  * DistUpgrade/DistUpgradeViewText.py:
    - fix py3 crash in text mode
  * DistUpgrade/DistUpgradeMain.py:
    - log python version
  * po/{eo,id,ug}.po:
    - fix translations of check-new-release-gtk which cause a crash
      (LP: #1311396)
  * data/demoted.cfg:
    - autmatic refresh of the demoted packages
  * po/*.po:
    - automatic refresh from launchpad
 -- Michael Vogt <email address hidden> Thu, 24 Apr 2014 14:57:39 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Mathew Hodson (mathew-hodson)]

https://launchpad.net/ubuntu/+source/language-pack-ja/1:12.04+20140813 released to precise-updates.

[Mathew Hodson (mathew-hodson)]

The four language packs are in trusty-proposed. Does there need to be a new upload for the Trusty update-manager task?

What verification needs to be done to move the language packs to trusty-updates?

[Mitsuya Shibata (cosmos-door)]

Hi Mathew

Sorry for late reply, Anyway, I tried language-pack-ja in
trusty-proposed, but output followings.
---
The following package was automatically installed and is no longer required:
  firefox-locale-ja
Use 'apt-get autoremove' to remove it.
---

Do you know any reason why firefox-locale-XX is dropped from
Recommends field of language-pack-XX-base?

--
Mitsuya Shibata
<email address hidden>

[Gunnar Hjalmarsson (gunnarhj)]

On 2015-10-09 16:25, Mitsuya Shibata wrote:
> Do you know any reason why firefox-locale-XX is dropped from
> Recommends field of language-pack-XX-base?

I don't think it ever was included in depends in language-pack-XX-base, but it's still pulled via
/usr/share/language-selector/data/pkg_depends once you open Language Support.

[Mitsuya Shibata (cosmos-door)]

Hi Gunnar,

2015-10-10 0:48 GMT+09:00 Gunnar Hjalmarsson <email address hidden>:
> I don't think it ever was included in depends in language-pack-XX-base, but it's still pulled via
> /usr/share/language-selector/data/pkg_depends once you open Language Support.

Thank you for your information.
Indeed, I could recover by Language Support.

1. language-pack updated via proposed)
2. $ sudo apt-get autoremove
  => firefox-locale-ja removed
3. launch firefox
  => UI doesn't localized
4. launch Language Support
  => "not complete langpack" message and install firefox-locale-ja
5. launch firefox
  => UI does localized

It seems that normal user doesn't exec "apt-get autoremove".
If it is removed, it is able to recover via language support.
Additionally to this, at least wily already drop it from recommends.
I think this is not so critical.

[Mitsuya Shibata (cosmos-door)]

Mathew and Gunnar,

I have tested language pack ja in trusty-proposed,
then not found any problem without #23-25.
And it seems that #23-25 is not real problem.

Could you move the packages from -proposed to -updates?

[Gunnar Hjalmarsson (gunnarhj)]

On 2015-10-11 21:15, Mitsuya Shibata wrote:
> Additionally to this, at least wily already drop it from recommends.

Hmm.. I see now that it was included as "Recommends" in the
language-pack-XX-base packages in precise, but not in trusty. That was news to me, and it indeed explains why quite a few users (including me) found that firefox-locale-XX was uninstalled unexpectedly.

Anyway, that problem should (almost) be history now, and it's not related to the issue in this bug report.

On 2015-10-11 21:26, Mitsuya Shibata wrote:
> I have tested language pack ja in trusty-proposed,
> then not found any problem without #23-25.
> And it seems that #23-25 is not real problem.
>
> Could you move the packages from -proposed to -updates?

Hopefully someone with proper access to the archive will do it.

Thanks, Mitsuya!

[Martin Pitt (pitti)]

I released the Japanese langpacks, thanks for testing!

[Mitsuya Shibata (cosmos-door)]

Hi Martin,

Thank you for update. However please update language-pack-ja-base too?

https://launchpad.net/ubuntu/+source/language-pack-ja-base

language-pack-ja depends same version of language-pack-ja.
http://packages.ubuntu.com/trusty-updates/language-pack-ja

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Mitsuya Shibata (cosmos-door)]

language-pack-ja-base was moved to trusty-updates. Thanks!

[Mathew Hodson (mathew-hodson)]

Sill a problem for Croatian.

https://translations.launchpad.net/ubuntu/precise/+source/update-manager/+pots/update-manager/hr/373/+translate