more tests fail with Go 1.5

Bug #1478742 reported by Michael Hudson-Doyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-push (Ubuntu)
New
Undecided
Unassigned

Bug Description

Further to #1478741, these tests fail with Go 1.5 tip:

FAIL launchpad.net/ubuntu-push/client/session 1.069s
FAIL launchpad.net/ubuntu-push/config 0.028s
FAIL launchpad.net/ubuntu-push/server/listener 0.320s

Full output at http://paste.ubuntu.com/11951230/

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This wasn't fixed when the purported duplicate was fixed and wasn't really the same bug anyway, so de-duplicating.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The client/session failures are pretty terrible: setupSuite starts a goroutine that sets the state to running and then the test methods assert that the state is running -- but there's no synchronization to make sure that the goroutine has done that before the test method starts.

server/listener is confusing. Haven't looked at config.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oh, the config failure is because the default help output from flag has chanegd. It used to be this: http://paste.ubuntu.com/12044311/ and now it is http://paste.ubuntu.com/12044315/

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I used https://code.launchpad.net/~mwhudson/ubuntu-push/1.5-test-fixery to build packages against 1.5rc1. It's messy as all heck though and disables the tests mentioned in bug 1483079.

affects: ubuntu-push → ubuntu-push (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.