MATE icon theme is missing color folders

[Brice Terzaghi]

This is more a wishlist than a bug report. Problem happens on 17.04 and 17.10 (not sure about previous version, as the MATE theme has changed a bit at some point).

Ubuntu MATE includes support for Folder Color (http://foldercolor.tuxfamily.org/) out of the box. Yet, the MATE icon theme (Ambiant-MATE / Radiant-MATE) doesn't include color folders and reverts to the generic ones installed by FC. While they look similar, they have small differences.

I've put a comparison of MATE using the FC icons vs recolored versions I've done here: http://imgur.com/a/Zd143

I can upload them somewhere if you want to include them (not sure if it's right to add an archive of icons as attachment to the bug report?).

[Martin Wimpress  (flexiondotorg)]

Hi Bruce,

Please do create a tarball of the recoloured folders and attach them here. I will see they get added to the icon theme :-)

[Brice Terzaghi (terzag)]

Here it is. A few notes:

- I've made all the colors managed by Folder Color, including the ones added recently (black, magenta, cyan and violet) that are not shown on my comparison screenshot. Not sure if the current version of FC in Ubuntu MATE 17.10 is up-to-date to support them.

- As MATE folders are already green by default, maybe you'll want to drop the green folders included (they're not copies of the MATE default icons, they match the Tango palette which appears to be nearly udentical to MATE's green). If so, you'll have to remove the folder_color_green_* and folder_extraicons_green_* from each size in the places dirs.

- I've not included an icon to add the option to set a global color in FC's menu. It can be done by adding an appropriate icon named "folder_color_globalcolor.svg" in actions/16. Not sure if you want to provide the option in MATE.

- I've included all the sizes found in the MATE icon theme though I'm not sure if they're all used by the desktop and thus Folder Color. Especially size 128 which only has the desktop icon in the base theme, not sure what it's used for. Maybe it has to be removed from my package.

[costales (costales)]

@Brice: WOW!!! AWESOME WORK!!! Thanks a lot mate! :)))

I reviewed them and in the new version of Folder Color, it would be better to change the filenames and remove the extraicons

http://bazaar.launchpad.net/~costales/folder-color/trunk/view/head:/README
Are you interested in the custom icon? [point 4]

I'm attaching the icons again.

Please, could you review everything is OK after my rename?
Steps for install new icon colors: https://paste.ubuntu.com/25463642/

Thanks in advance!

[Brice Terzaghi (terzag)]

I've never used the custom color option of FC (I find it a bit odd to have a color named "custom" along the usual ones, that can vary from theme to theme), I'm not even sure how I would update the MATE icons to use it, as I didn't design them in the first place, not sure how/where to put constants in the SVG files.

I checked the icons you reuploaded and there's something I don't understand: there's no more extra icons *at all*? FC will stop handling the user / recent / remote folders? No more global color?

Are the new names inside your pack compatible with the version of FC included in Ubuntu MATE 17.10?

Note: about the way to install the icons, don't forget Radiant-MATE along Ambiant-MATE but I guess Martin is aware of this.

[Brice Terzaghi (terzag)]

(Tried the icons with the new names, they seem to work with the current version of Ubuntu MATE 17.10.)

[costales (costales)]

@Brice:

Custom color: About custom color, it's OK not to include it :)

Global color: Yes, there isn't more global color in the last version (so clean code now for future maintenance), then we doesn't need the extra icons anymore.

Pack compatible: Yes, folder color was uploaded to the Ubuntu repository, then, the rename is better for that version :) https://packages.ubuntu.com/artful/folder-color

Path icons: Yes, that will be in the @Martin work :)

A hug and thanks for the review and work!! :D

[Brice Terzaghi (terzag)]

I just realized that I assumed Radiant-MATE only had different icons for the panel but I didn't think about the desktop icon, which is different too (white panel instead of black). So, the icons provided so far in the report matched only the MATE-Ambiant theme. I just recolored the desktop icon for the MATE-Radiant variant, I post the full set up to date:
- Ambiant + Radiant icons;
- no green icons because MATE ones are already green;
- no more extra icons as support for global color is dropped;
- the new names.

I think this time it should be ok. Sorry for the missing icons previously.

[Martin Wimpress  (flexiondotorg)]

Thank you Brice and Marcos! This will feature in the new update to ubuntu-mate-artwork :-)

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-mate-artwork - 17.10.10

---------------
ubuntu-mate-artwork (17.10.10) artful; urgency=medium

  * mate-panel: re-style outlines for keyboard navigation. (LP: #1709013)
  * Add missing icons for Folder Color (LP: #1713254)
  * Make search match color in GtkSourceView easier to read (LP: #1711783)

 -- Martin Wimpress <email address hidden> Mon, 04 Sep 2017 19:40:13 +0100

[costales (costales)]

Hi,
About Radiant-MATE, I think they could be just a symbolic link to Ambiant-MATE (for saving disk space).
Best regards.