Some extra comments from IRC below, then +1 for NEWing them: 17:39:07 JackYu | didrocks, hi, could you help to upload this package at bug #1371165 ? Laney approved the FFe just now. 17:39:08 ubot5 | bug 1371165 in ubuntu-kylin-software-center (Ubuntu) "[FFe] Upload ubuntu-kylin-sso-client to Archive for UKSC" | [High,Triaged] https://launchpad.net/bugs/1371165 17:39:27 didrocks | JackYu: hum, let me have a look 17:40:06 didrocks | JackYu: seems like you already asked and gave to seb128, right? 17:40:18 didrocks | seeing that he commented 5 hours ago) 17:40:47 JackYu | didrocks, seb128 have helped to review it. 17:41:15 didrocks | JackYu: where are the updates? https://code.launchpad.net/~luolei/ubuntu-kylin-sso-client/trunk is from the 19th 17:42:41 didrocks | JackYu: the debian/copyright fix is not in trunk 17:43:44 JackYu | didrocks, let's me check. 17:44:23 didrocks | JackYu: also: bzr: ERROR: Inconsistency between source format and version: version is native, format is not | native. 17:44:54 didrocks | debian/source/format should be: 3.0 (native) 17:45:24 Laney | diff the packaging with ubuntu-sso-client? ;-) 17:45:48 didrocks | Laney: yeah, I was doing that, seems similar 17:45:49 JackYu | didrocks, I will update the code asap. 17:45:55 didrocks | Laney: the thing is that I can't even bzr bd :p 17:48:12 didrocks | JackYu: in addition to what seb128 told: W: ubuntu-kylin-sso-client source: | missing-license-paragraph-in-dep5-copyright gpl-3 with openssl exception (paragraph at line 3) 17:48:19 didrocks | please add the paragraph 17:49:34 didrocks | JackYu: also debian/tests/control mentions a run-tests file which doesn't exist in debian/tests/ 17:50:20 JackYu | didrocks, Sure. 17:50:29 didrocks | JackYu: nitpick, but, please change the date to be a real one in debian/changelog 17:50:35 didrocks | Thu, 19 Sep 2014 -> was a Friday 17:50:50 didrocks | JackYu: a hint, when you build the package, you have lintian warnings in the end, they tell you that :) 17:51:10 JackYu | OK! 17:51:18 Laney | I think the Tests-Directory: . fixes the debian/tests thing 17:51:33 Laney | Makes it look in the root of the package which has such a script 17:51:41 didrocks | Laney: I compared to u-s-c, and it seems that they still have the other file 17:51:56 didrocks | I don't really know and want to risk blocking in proposed though, wdyt? 17:52:04 didrocks | if you are sure it's working that way, fine with me :) 17:52:14 Laney | this is also part of the diff 17:52:27 Laney | +Tests-Directory: . 17:52:55 didrocks | JackYu: and finally (other small things, but not too big): ubuntu-kylin-sso-client-qt has a too long description | line, please wrap in debian/control to 80 characters 17:53:10 didrocks | Laney: ah ok, thanks for the hint, JackYu: please ignore the test comment then 17:53:35 Laney | Looks like all the Ubuntu one does is run that script 17:53:42 JackYu | good:) 17:53:50 Laney | someone's clever, fixing that :P 17:54:07 didrocks | JackYu: oh, and in debian/control -> Priority: extra -> set it to optional please :) 17:54:12 didrocks | no reason to have it extra 17:56:30 didrocks | JackYu: ok, the rest is minor, just do those changes and I'll NEW it 17:57:01 JackYu | didrocks, got it, dong now