[regression] OSK input shaping no longer works correctly

Bug #1669444 reported by Michael Sheldon on 2017-03-02
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Canonical System Image
High
Stephen M. Webb
Mir
Fix Released
High
Kevin DuBois
0.26
Fix Released
High
Kevin DuBois
mir (Ubuntu)
High
Unassigned
qtmir (Ubuntu)
High
Unassigned
ubuntu-keyboard (Ubuntu)
Undecided
Unassigned

Bug Description

Steps to reproduce:

1) Run the keyboard under Unity8 (silo 2481 can be helpful in making this more usable at present)
2) Click in an input field
3) Move the mouse over the keyboard
4) Attempt to click on the app again

Expected result:

The mouse click should be passed through to the app

Actual result:

The click is swallowed by the keyboard surface instead. However, it is still possible to click on the app if this is done prior to the mouse entering the visible keyboard area.

Related branches

Bill Filler (bfiller) on 2017-03-02
Changed in qtmir (Ubuntu):
importance: Undecided → High
Daniel van Vugt (vanvugt) wrote :

According to this page, the functionality was rewritten/moved recently:
https://code.launchpad.net/~andreas-pokorny/mir/remove-input-region/+merge/316713

tags: added: regression
summary: - OSK input shaping no longer works correctly
+ [regression] OSK input shaping no longer works correctly
Changed in mir:
importance: Undecided → High
Changed in mir (Ubuntu):
importance: Undecided → High
Daniel van Vugt (vanvugt) wrote :

That said, why is the OSK written to work that way? Isn't it wasting GPU/CPU time by rendering a large translucent area?

Gerry Boland (gerboland) wrote :

I've tracked this down to the following mir bug:
https://bugs.launchpad.net/mir/+bug/1670876

Gerry Boland (gerboland) wrote :

@vanvugt - yep it's not ideal. For phone/tablet, to make device rotation animation as good as we could, was easiest to give the OSK a fullscreen surface and have it rotate itself, letting application shine through in the translucent area.

But that is certainly an area we can improve.

Changed in ubuntu-keyboard (Ubuntu):
status: New → Invalid
Changed in qtmir (Ubuntu):
status: New → Invalid
tags: added: unity8-desktop
Changed in mir:
milestone: none → 1.0.0
Changed in mir:
assignee: nobody → Kevin DuBois (kdub)
status: New → In Progress
Changed in canonical-devices-system-image:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Stephen M. Webb (bregma)
milestone: none → u8c-1
Changed in mir (Ubuntu):
status: New → Triaged
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 1.0.0

Changed in mir:
status: In Progress → Fix Committed
Changed in canonical-devices-system-image:
status: Triaged → Fix Committed
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:mir/0.26 at revision 4034, scheduled for release in Mir 0.26.2

tags: added: osk
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.26.2+17.04.20170322.1-0ubuntu1

---------------
mir (0.26.2+17.04.20170322.1-0ubuntu1) zesty; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.26.2 (https://launchpad.net/mir/+milestone/0.26.2)
    - Bugs fixed:
      . EDID does not change when hotplugging a monitor (LP: #1660017)
      . [regression] mirout crashes when connecting to unity8 or any nested
        server: [libprotobuf FATAL /usr/include/google/protobuf/repeated_field.
        h:1408] CHECK failed: (index) < (current_size_) (LP: #1661163)
      . Mir server crashed with SIGSEGV in
        mir::compositor::TemporaryBuffer::size() called from
        mir::gl::tessellate_renderable_into_rectangle() (LP: #1664760)
      . Nested servers (Unity8) periodically stutter (half frame rate) with
        Mir 0.26.1 (LP: #1666372)
      . Don't dereference the end iterator in ms::ApplicationSession::
        surface_after() (LP: #1667645)
      . [regression] OSK input shaping no longer works correctly (LP: #1669444)
      . Setting MirWindowSpec parameters always causes window's input_region
        to be reset (LP: #1670876)
      . Subpixel order not included in Mir display information (LP: #1393578)
      . Presentation chains should support various swap interval modes
        (LP: #1673533)
      . Need an extension for GBM buffers to replace
        mir_buffer_get_buffer_package() (LP: #1673534)
      . Seg fault on detect_fd_leaks (LP: #1661498)

 -- Cemil Azizoglu <email address hidden> Wed, 22 Mar 2017 04:54:19 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Stephen M. Webb (bregma) on 2017-03-24
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers