| 2017-10-27 13:28:28 |
Stefan Bader |
bug |
|
|
added bug |
| 2017-10-27 14:28:17 |
Stefan Bader |
description |
SRU Justification (for Artful/Zesty/Xenial):
Impact:
"fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge. However it is possible that this returns with an error and in that case fanatic must undo previously done configuration changes or otherwise any following attempt to run enable-fan will incorrectly believe the bridge is up and do nothing.
Fix:
Adding a remove config stage if the call to fanctl returns with an error.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $? |
SRU Justification (for Artful/Zesty/Xenial):
Impact:
"fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge. However it is possible that this returns with an error and in that case fanatic must undo previously done configuration changes or otherwise any following attempt to run enable-fan will incorrectly believe the bridge is up and do nothing.
Fix:
Adding a remove config stage if the call to fanctl returns with an error.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?
Regression potential:
Cleanup called only on failure and the used function is also used in fanatic disable-fan. -> Low |
|
| 2017-10-27 15:15:51 |
Stefan Bader |
description |
SRU Justification (for Artful/Zesty/Xenial):
Impact:
"fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge. However it is possible that this returns with an error and in that case fanatic must undo previously done configuration changes or otherwise any following attempt to run enable-fan will incorrectly believe the bridge is up and do nothing.
Fix:
Adding a remove config stage if the call to fanctl returns with an error.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?
Regression potential:
Cleanup called only on failure and the used function is also used in fanatic disable-fan. -> Low |
SRU Justification (for Artful/Zesty/Xenial):
Impact:
"fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge. However it is possible that this returns with an error and in that case fanatic must undo previously done configuration changes or otherwise any following attempt to run enable-fan will incorrectly believe the bridge is up and do nothing.
Fix:
Adding a remove config stage if the call to fanctl returns with an error.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?
Note: It seems in Artful, the default for iptables is to wait until the lock is released (without -w) so the test here won't work without adding -w to all iptables calls in fanctl. :/
Regression potential:
Cleanup called only on failure and the used function is also used in fanatic disable-fan. -> Low |
|
| 2017-11-07 15:06:36 |
Łukasz Zemczak |
nominated for series |
|
Ubuntu Artful |
|
| 2017-11-07 15:06:36 |
Łukasz Zemczak |
bug task added |
|
ubuntu-fan (Ubuntu Artful) |
|
| 2017-11-07 15:07:11 |
Łukasz Zemczak |
nominated for series |
|
Ubuntu Zesty |
|
| 2017-11-07 15:07:11 |
Łukasz Zemczak |
bug task added |
|
ubuntu-fan (Ubuntu Zesty) |
|
| 2017-11-07 15:07:11 |
Łukasz Zemczak |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-11-07 15:07:11 |
Łukasz Zemczak |
bug task added |
|
ubuntu-fan (Ubuntu Xenial) |
|
| 2017-11-07 15:13:15 |
Łukasz Zemczak |
ubuntu-fan (Ubuntu Artful): status |
New |
Fix Committed |
|
| 2017-11-07 15:13:18 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-11-07 15:13:21 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2017-11-07 15:13:25 |
Łukasz Zemczak |
tags |
|
verification-needed verification-needed-artful |
|
| 2017-11-07 15:16:30 |
Łukasz Zemczak |
ubuntu-fan (Ubuntu Zesty): status |
New |
Fix Committed |
|
| 2017-11-07 15:16:37 |
Łukasz Zemczak |
tags |
verification-needed verification-needed-artful |
verification-needed verification-needed-artful verification-needed-zesty |
|
| 2017-11-07 15:23:55 |
Łukasz Zemczak |
ubuntu-fan (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2017-11-07 15:24:02 |
Łukasz Zemczak |
tags |
verification-needed verification-needed-artful verification-needed-zesty |
verification-needed verification-needed-artful verification-needed-xenial verification-needed-zesty |
|
| 2017-11-17 23:37:35 |
Launchpad Janitor |
ubuntu-fan (Ubuntu): status |
In Progress |
Fix Released |
|
| 2017-12-06 11:35:16 |
Stefan Bader |
tags |
verification-needed verification-needed-artful verification-needed-xenial verification-needed-zesty |
verification-done-xenial verification-needed verification-needed-artful verification-needed-zesty |
|
| 2017-12-06 13:46:22 |
Stefan Bader |
tags |
verification-done-xenial verification-needed verification-needed-artful verification-needed-zesty |
verification-done-xenial verification-done-zesty verification-needed verification-needed-artful |
|
| 2017-12-06 14:53:07 |
Stefan Bader |
tags |
verification-done-xenial verification-done-zesty verification-needed verification-needed-artful |
verification-done verification-done-artful verification-done-xenial verification-done-zesty |
|
| 2017-12-11 15:06:20 |
Launchpad Janitor |
ubuntu-fan (Ubuntu Artful): status |
Fix Committed |
Fix Released |
|
| 2017-12-11 15:06:29 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2017-12-11 15:19:48 |
Launchpad Janitor |
ubuntu-fan (Ubuntu Zesty): status |
Fix Committed |
Fix Released |
|
| 2017-12-11 15:48:59 |
Launchpad Janitor |
ubuntu-fan (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
