fanctl does not stop setup on first match
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-fan (Ubuntu) |
Fix Released
|
Medium
|
Stefan Bader | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Zesty |
Fix Released
|
Medium
|
Unassigned |
Bug Description
SRU Justification (Zesty/Xenial)
Impact: When /etc/network/fan contains two entries for the same mapping (for example on mapping for the generic network mapping and one for a specific interface) it will try to set up the same Fan bridge twice.
Fix: Modify fanctl to only bring up enabled networks in auto mode and to correctly apply the most specific local configuration.
Testcase: If in an environment that uses one of the 192.168.0.0/16 subnets, and host has for example a 192.168.1.0/24 address. Then trying to use
fanatic enable-fan -u 192.168.1.x/24 -o 250.0.0.0/8
would show an error now and with the fix applied work ok.
Regression Potential: We tested both cases of using an underlay/overlay combination which is in the template section and one that was using a subset for the underlay. The former was working before the latter not. For that reason we anticipate a low risk of regression.
tags: | added: patch |
Changed in ubuntu-fan (Ubuntu): | |
assignee: | nobody → Stefan Bader (smb) |
importance: | Undecided → Medium |
status: | New → In Progress |
description: | updated |
Changed in ubuntu-fan (Ubuntu Zesty): | |
status: | Incomplete → In Progress |
Changed in ubuntu-fan (Ubuntu Xenial): | |
status: | New → Triaged |
Changed in ubuntu-fan (Ubuntu Zesty): | |
importance: | Undecided → Medium |
Changed in ubuntu-fan (Ubuntu Xenial): | |
importance: | Undecided → Medium |
This is occuring because fanatic is trying to bring up the newly configured Fan Network as if it had been brought up automatically. This is done to bring the system into a state that is equivalent to having had the configuration for this Fan Network at boot time. However it does it using an interface which appear to fanctl as a user "who knows what they are doing", and it brings up all matching prefixes; in this case a prefix which is purely in the file as an example/preferred configuration.