fanatic does not use the user-specified underlay, but 192.168.0.0/16

[Dimiter Naydenov]

On a xenial machine, I tried to use fanatic to configure the fan with underlay 10.88.0.0/16 and the suggested overlay 250.0.0.0/8, but the underlay suggested by fanatic (192.168.0.0/16) was used instead of 10.88.0.0/16 I specified.

Here's the paste of the session: http://paste.ubuntu.com/16630235/

===
[Impact]

Configuration for some combinations which including using the default overlay only will be miss-parsed.

[Test Case]

As above.

[Regression Potential]

Low, only affects new setup.

[Dimiter Naydenov (dimitern)]

Trying to specify both explicitly yields a different error: http://paste.ubuntu.com/16630370/

Same result when I run `fanatic configure -u 10.88.0.0/16 -o 250.0.0.0/8` FWIW.

There's a typo in the error message when I at first tried `fanatic -u 10.88.0.0./16 -o 250.0.0.0/8`: Usage: /usr/sbin/fanatic -u: uknown command

[Dimiter Naydenov (dimitern)]

I wasn't aware I needed to use an underlay range already present on my machine :/ (I thought it needs a free range to do the config). Using the defaults (I suspect, 192.168.0.0/16 was auto-detected) worked!

[Andy Whitcroft (apw)]

This can be worked around by specifying both the underlay and overlay addresses at this prompt. If only the underlay is specified it is not detected correctly.

Fix in the works.

[Dimiter Naydenov (dimitern)]

Another thing I noticed:

/usr/sbin/fanatic: 808: /usr/sbin/fanatic: lxd-images: not found

Because of this the lxd test cannot spin up the test container, as it can't import the image.
I managed to get it to work by patching fanatic like this:

---
        # Check if we have images already...
        lxc image show fanatic-test >/dev/null 2>&1
        if [ "$?" -ne 0 ]; then
                echo "local lxd test: pulling container images ..."
                lxc image copy ubuntu:xenial local: --alias fanatic-test
                local rc="$?"
                if [ "$rc" -ne 0 ]; then
                        echo "local lxd test: lxc image import failure, skipping test."
                        return "$rc"
                fi
        fi
---

There's no lxd-images on my machine and I suspect it used to be one in an earlier version of the LXD package. I'm using lxd 2.0.1-0ubuntu1~16 amd64

[Dimiter Naydenov (dimitern)]

Filed a separate bug 1584775 for the issue in comment #4

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-fan - 0.10.0

---------------
ubuntu-fan (0.10.0) yakkety; urgency=medium

  [ Andy Whitcroft ]
  * fanatic: fix legacy command line form syntax error (LP: #1584150)
  * fanctl/fanatic: add help commands/options with initial pointers
    (LP: #1535054)

  [ Jay Vosburgh ]
  * fanatic: fix underlay with calculation (LP: #1584092)

  [ Andy Whitcroft ]
  * fanctl/fanatic: remove invalid web reference from manual pages.
    (LP: #1582956)
  * debian/control: fix use of obsolete > operator
  * fanatic: detect user specified underlay address without overlay
    (LP: #1584692)
  * fanatic: switch from lxd-images to using cached lxc images. (LP: #1584775)
  * fanctl.8: fix interfane type (LP: #1584845)
  * fanatic: test-host -- use the selected underlay width to calculate the remote addresses
    (LP: #1584878)

 -- Andy Whitcroft <email address hidden> Mon, 23 May 2016 22:05:19 +0100

[Chris J Arges (arges)]

Hello Dimiter, or anyone else affected,

Accepted ubuntu-fan into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-fan/0.9.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Andy Whitcroft (apw)]

Confirmed that manually supplying only the underlay address with take that and the default overlay addresses.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-fan - 0.9.1

---------------
ubuntu-fan (0.9.1) xenial; urgency=medium

  [ Andy Whitcroft ]
  * fanatic: fix legacy command line form syntax error (LP: #1584150)
  * fanctl/fanatic: add help commands/options with initial pointers
    (LP: #1535054)

  [ Jay Vosburgh ]
  * fanatic: fix underlay with calculation (LP: #1584092)

  [ Andy Whitcroft ]
  * fanctl/fanatic: remove invalid web reference from manual pages.
    (LP: #1582956)
  * fanatic: detect user specified underlay address without overlay
    (LP: #1584692)
  * fanatic: switch from lxd-images to using cached lxc images. (LP: #1584775)
  * fanatic: test-host -- use the selected underlay width to calculate the remote addresses
    (LP: #1584878)
  * fanctl: fix net start/stop exit codes. (LP: #1551747)
  * fanatic: install ping and nc when needed (LP: #1586176)
  * fanatic: switch docker testing to lts images (LP: #1586169)

 -- Andy Whitcroft <email address hidden> Mon, 04 Jul 2016 14:35:39 +0100

[Martin Pitt (pitti)]

The verification of the Stable Release Update for ubuntu-fan has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.