autopkgtest failures if nvidia dkms module fails to build

[Steve Langasek]

The ubuntu-drivers-common package is currently failing its autopkgtests:

test_nvidia_304 (__main__.TestUbuntuDrivers)
nvidia-304 ...
--- Error output from package installation ---
dpkg-preconfigure: unable to re-open stdin: No such file or directory
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
 * Setting up X socket directories...
   ...done.
ERROR: ld.so: object 'libumockdev-preload.so.0' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
INFO:Enable nvidia-304
DEBUG:Parsing /usr/share/ubuntu-drivers-common/quirks/lenovo_thinkpad
DEBUG:Parsing /usr/share/ubuntu-drivers-common/quirks/dell_latitude
DEBUG:Parsing /usr/share/ubuntu-drivers-common/quirks/put_your_quirks_here
Error! Bad return status for module build on kernel: 3.19.0-7-generic (x86_64)
Consult /var/lib/dkms/nvidia-304/304.125/build/make.log for more information.

------
FAIL
test_nvidia_304_updates (__main__.TestUbuntuDrivers)
nvidia-304-updates ...
--- Error output from package installation ---
dpkg-preconfigure: unable to re-open stdin: No such file or directory
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
 * Setting up X socket directories...
   ...done.
INFO:Enable nvidia-304-updates
DEBUG:Parsing /usr/share/ubuntu-drivers-common/quirks/lenovo_thinkpad
DEBUG:Parsing /usr/share/ubuntu-drivers-common/quirks/dell_latitude
DEBUG:Parsing /usr/share/ubuntu-drivers-common/quirks/put_your_quirks_here
Error! Bad return status for module build on kernel: 3.19.0-7-generic (x86_64)
Consult /var/lib/dkms/nvidia-304-updates/304.125/build/make.log for more information.

------
FAIL

https://jenkins.qa.ubuntu.com/job/vivid-adt-ubuntu-drivers-common/57/ARCH=amd64,label=adt/console

This has been failing consistently since Feb 27.

This is a bad test, because a failure of the nvidia dkms module to be buildable should be captured as a failure on the nvidia package and not on the ubuntu-drivers package which is testing all of drivers. For ubuntu-drivers-common, an unbuildable dkms module should be treated as a skipped test rather than a failed test.

Also opening a task against the nvidia 304 package, which probably needs a fix for newer kernels or to be dropped from the archive if it's incompatible with linux 3.19.

[Martin Pitt (pitti)]

That's pretty much exactly what the u-d-common tests are supposed to detect -- the new kernel broke the -304 nvidia driver. I talked about that to Alberto last week, but good to have a bug now.

[Steve Langasek (vorlon)]

Martin, the reason I filed this bug against ubuntu-drivers-common is that the behavior of this package's tests is at odds with proposed-migration. There is a new version of perl waiting to reach vivid, which causes ubuntu-drivers-common's tests to be run and report a failure because of a regression in a package that is *not* a dependency of ubuntu-drivers-common. perl, or other dependencies of ubuntu-drivers-common, shouldn't find themselves blocked because of a regression in an nvidia driver package; and testing that the nvidia dkms drivers can be built should happen /when the kernel package is updated/, which didn't happen here. The tests are currently happening in the wrong place to be useful for proposed-migration, and that should be fixed.

[Martin Pitt (pitti)]

Right. For the record, the plan is to enable reverse test dependencies, so that u-d-common can test-depend on the kernel and will be triggered on new kernel uploads (https://bugs.debian.org/779559)

[Alberto Milone (albertomilone)]

What Martin proposed in the Debian bug report would make my life as a maintainer much easier.

[kary (kari-kivioja)]

I'm not sure, what this discussion is about. But as far as i know, you could fix Nvidia drivers:

In bug Bug #1409190 I wrote:
    ROOT CAUSE: In kernel headers, a feature that nvidia code depends on, has been removed in kernel 3.19:

        $ diff linux-headers-3.18.0-13/include/linux/fs.h linux-headers-3.19.0-7/include/linux/fs.h | grep f_dentry
        < #define f_dentry f_path.dentry

    WORKAROUND: Make nvidia code live without that feature:

        $ sudo sed -i~ s/f_dentry/f_path.dentry/ /usr/src/nvidia-304-304.125/nv.c
        $ apt list --installed 'linux*' | cut -d / -f 1 | grep 3.19 | xargs sudo apt install --reinstall

But if you are after a set of tests, that don't get bugged about failing packages, that's another kettle...

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-304 - 304.125-0ubuntu2

---------------
nvidia-graphics-drivers-304 (304.125-0ubuntu2) vivid; urgency=medium

  * debian/templates/dkms.conf.in,
    debian/dkms/patches/buildfix_kernel_3.19.patch:
    - Add support for Linux 3.19 (LP: #1427924).
 -- Alberto Milone <email address hidden> Wed, 04 Mar 2015 17:52:08 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package nvidia-graphics-drivers-304-updates - 304.125-0ubuntu2

---------------
nvidia-graphics-drivers-304-updates (304.125-0ubuntu2) vivid; urgency=medium

  * debian/templates/dkms.conf.in,
    debian/dkms/patches/buildfix_kernel_3.19.patch:
    - Add support for Linux 3.19 (LP: #1427924).
 -- Alberto Milone <email address hidden> Wed, 04 Mar 2015 17:54:42 +0100

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.