[MIR] ubuntu-download-manager

[Olivier Tilloy]

webbrowser-app (in main) currently has a non-explicit runtime dependency on ubuntu-download-manager, which is in universe.
This has been working until now because the desktop version of the app doesn’t make use of the QML API for the download manager, only the version for touch devices does (and ubuntu-download-manager is part of the touch seed).
With convergence in mind, the desktop version needs to start using that QML API, so the runtime dependency needs to be made explicit. Hence the need for ubuntu-download-manager to be included in main.
It is likely that other applications will have the same kind of requirements in the near future too.

ubuntu-download-manager is actively being developed and maintained, upstream tracks their bugs at https://bugs.launchpad.net/ubuntu/+source/ubuntu-download-manager/.

All its build and runtime dependencies are already in main.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Michael Terry (mterry)]

Love the tests, symbols files, and clean packaging! :)

Blockers:
- Needs a team bug subscriber (a team that looks after this package in main, I assume ~touch-packages, which is currently subscribed, is not actually watched by anyone, and is just for bookkeeping?)
- In the spirit of the above, UDM shouldn't keep bugs in two places: bug 1478462. That just makes it harder to maintain, and means that the designated team might miss a bug.
- I'm confused on whether there are user-visible strings in u-d-m... If so, they should be translatable. (There might be some error messages in src/uploads/priv/ubuntu/uploads/file_upload.cpp... maybe elsewhere? I'm not familiar with the code.)

Other notes:
- Critical crasher bug 1411866 has been reported with reproduction steps for seven and half months, with no progress. That's not a comforting sign of maintenance.
- UDM runs daemons, sometimes as root. This should have a security lookover, so assigning to ~ubuntu-security.
- E: ubuntu-download-manager source: build-depends-on-metapackage build-depends: qt5-default
- W: libubuntu-download-manager-client-doc: embedded-javascript-library usr/share/doc/ubuntu-download-manager/cpp/html/jquery.js please use libjs-jquery

[Jamie Strandboge (jdstrand)]

At this point I doubt this will be reviewed in time for 15.10-- what would happen if it was done for 16.04 (this seems to be in line with current Ubuntu Personal priorities anyway, no?)?

[Olivier Tilloy (osomon)]

The current implementation of the onDownloadRequested signal handler in the browser, on desktop, does this:

    Qt.openUrlExternally(request.url)

(as opposed to the touch version which uses the DownloadManager API to actually download the requested URI).

This means that the requested URI will be opened and downloaded in the default browser. If the default browser has been set to webbrowser-app, this will open another webbrowser-app instance (multiple windows are not well supported by the way) pointing to the requested URI, which will, obviously, not be downloaded. In both cases, a rather bad UX.

[Jamie Strandboge (jdstrand)]

I acknowledge the bad user experience but AIUI, Ubuntu Personal is not the priority for 15.10 and I don't think that webbrowser-app is used as the default browser any where else. I'm not saying that this won't happen, I'm just trying to figure out priorities.

[Jamie Strandboge (jdstrand)]

The security review will not be done in time for 15.10.

[Bill Filler (bfiller)]

@elleo
please address the issues raised in comment #2

[Bill Filler (bfiller)]

then assign to ubuntu security team once done

[Mathieu Trudel-Lapierre (cyphermox)]

What is the state of this MIR? Is it ready for another round of review?

[Michael Sheldon (michael-sheldon)]

I'm taking a look at the crasher mentioned in this now, then will review the other items to see if anything else is still outstanding

[Michael Sheldon (michael-sheldon)]

Silo 57 (which is currently being reviewed) contains fixes for translations, for bug 1411866, and the packaging error, but not the jquery warning, as this is apparently the expected behaviour of Doxygen based packages (see README.jquery in the doxygen package for details). We've also synced up the bug lists and added a team subscriber for the bugs. So as soon as silo 57 lands this should be ready to re-review.

[Michael Sheldon (michael-sheldon)]

Silo 57 has landed now, so this is ready for re-review now

[Michael Sheldon (michael-sheldon)]

Actually not quite ready, it's still in the proposed pocket so hasn't finished landing yet, I jumped the gun a bit :)

[Michael Sheldon (michael-sheldon)]

Silo 57 has now really landed fully, so this MIR is ready for re-review

[Emily Ratliff (emilyr)]

Security Team ack for 16.10. We will be doing a source code review and request that the requesting team to promptly address any issues that we find.

[Will Cooke (willcooke)]

@cyphermox - ready for another go around I think.

[Steve Langasek (vorlon)]

Override component to main
ubuntu-download-manager 1.3+16.10.20160909.1-0ubuntu1 in yakkety: universe/net -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety amd64: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety arm64: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety armhf: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety i386: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety powerpc: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety ppc64el: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety s390x: universe/libdevel/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety amd64: universe/doc/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety arm64: universe/doc/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety armhf: universe/doc/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety i386: universe/doc/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety powerpc: universe/doc/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety ppc64el: universe/doc/optional/100% -> main
libubuntu-download-manager-client-doc 1.3+16.10.20160909.1-0ubuntu1 in yakkety s390x: universe/doc/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety amd64: universe/libs/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety arm64: universe/libs/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety armhf: universe/libs/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety i386: universe/libs/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety powerpc: universe/libs/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety ppc64el: universe/libs/optional/100% -> main
libubuntu-download-manager-client1 1.3+16.10.20160909.1-0ubuntu1 in yakkety s390x: universe/libs/optional/100% -> main
libubuntu-download-manager-common-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety amd64: universe/libdevel/optional/100% -> main
libubuntu-download-manager-common-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety arm64: universe/libdevel/optional/100% -> main
libubuntu-download-manager-common-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety armhf: universe/libdevel/optional/100% -> main
libubuntu-download-manager-common-dev 1.3+16.10.20160909.1-0ubuntu1 in yakkety i386: universe/libdevel/optional...