requestsync: undefined variable hasLP

Bug #607874 reported by Jelmer Vernooij on 2010-07-20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)

Bug Description

Binary package hint: ubuntu-dev-tools

If --lpapi doesn't get specified to requestsync 'hasLP' doesn't end up being set. I suspect it to have to be set to False in the other case, but I can't see what that variable is actually needed for (it's only used once and that code doesn't appear to use the LP API).

gwenhwyvar:~/src/meliae/trunk% requestsync meliae
W: Target release missing - assuming maverick
Traceback (most recent call last):
  File "/usr/bin/requestsync", line 146, in <module>
    if (ubuntu_version >= debian_version) and hasLP:
NameError: name 'hasLP' is not defined

Michael Bienia (geser) wrote :

Fixed in trunk r670.

Changed in ubuntu-dev-tools (Ubuntu):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.101

ubuntu-dev-tools (0.101) unstable; urgency=low

  [ Andrew Starr-Bochicchio ]
  * syncpackage: Update manpage to reflect current usage. (Closes: #587142,
    LP: #598477)
  * ubuntu-build: Update manpage to reflect current usage. (LP: #490535)
  * edit-patch: Add manpage. (LP: #538379)
  * massfile: Add manpage.
  * pull-debian-debdiff: Add manpage.
  * setup-packaging-environment: Add manpage.
  * ubuntu-iso: Add manpage.

  [ Benjamin Drung ]
  * Bump Standards-Version to 3.9.1 (no changes required).
  * Switch to dpkg-source 3.0 (native) format.
  * Switch to simple dh7 rule.
  * syncpackage:
    - Use Version class from python-debian to fix extraction of upstream
      version for debian versions that contain more than one dash.
    - Prepend script name to every output
    - Output every executed command in verbose mode
    - Print proper error message if the dsc file is malformed.
  * update-maintainer: Add a --quiet option.
  * suspicious-source: Replace with total rewrite in Python using python-magic.

  [ Michael Bienia ]
  * ubuntutools/lpapi/ Use the new LP API method
    archive.checkUpload() to check upload permissions.
  * Add "import-bug-from-debian" written by James Westby.
  * Add python-soappy to Recommends.
  * requestsync: Fix bug where the variable 'hasLP' is not always set
    (lp: #607874).

  [ Steve Beattie ]
  * mk-schroot: add debootstrap include/exclude options
  * mk-schroot.1: document added options
 -- Luca Falavigna <email address hidden> Wed, 04 Aug 2010 10:06:44 +0000

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers