Activity log for bug #1569400

Date Who What changed Old value New value Message
2016-04-12 14:54:36 Robie Basak bug added bug
2016-04-12 14:55:40 Robie Basak attachment added fix.patch https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1569400/+attachment/4634267/+files/fix.patch
2016-04-12 16:27:32 Ubuntu Foundations Team Bug Bot tags amd64 apport-bug uec-images xenial amd64 apport-bug patch uec-images xenial
2016-04-27 12:16:56 Launchpad Janitor ubuntu-dev-tools (Ubuntu): status New Confirmed
2016-05-09 06:00:44 Launchpad Janitor branch linked lp:ubuntu-dev-tools
2016-05-09 12:04:07 Launchpad Janitor ubuntu-dev-tools (Ubuntu): status Confirmed Fix Released
2016-07-01 19:08:45 Steve Langasek nominated for series Ubuntu Xenial
2016-07-01 19:08:45 Steve Langasek bug task added ubuntu-dev-tools (Ubuntu Xenial)
2016-07-01 19:15:06 Steve Langasek ubuntu-dev-tools (Ubuntu Xenial): importance Undecided High
2016-07-01 19:15:06 Steve Langasek ubuntu-dev-tools (Ubuntu Xenial): status New Triaged
2016-07-01 19:15:06 Steve Langasek ubuntu-dev-tools (Ubuntu Xenial): assignee Steve Langasek (vorlon)
2016-07-01 19:22:57 Steve Langasek ubuntu-dev-tools (Ubuntu Xenial): status Triaged In Progress
2016-07-01 19:29:43 Steve Langasek description On my system, /etc/localtime points to Etc/UTC. When I run mk-sbuild, it fails as follows: I: Base system installed successfully. cp: '/etc/localtime' and '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' are the same file rbasak@diglett:~$ stat /etc/localtime File: '/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC' Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 24904635 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:34:01.913544692 +0000 Modify: 2016-04-09 14:16:56.000000000 +0000 Change: 2016-04-11 14:33:38.788003973 +0000 Birth: - rbasak@diglett:~$ stat /var/lib/schroot/chroots/xenial-amd64/etc/localtime File: '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC' Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 25958842 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:39:39.042359630 +0000 Modify: 2016-04-12 14:39:39.038359620 +0000 Change: 2016-04-12 14:39:39.038359620 +0000 Birth: - rbasak@diglett:~$ ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: ubuntu-dev-tools 0.155 [modified: usr/bin/mk-sbuild] ProcVersionSignature: Ubuntu 4.4.0-18.34-generic 4.4.6 Uname: Linux 4.4.0-18-generic x86_64 NonfreeKernelModules: zfs zunicode zcommon znvpair zavl ApportVersion: 2.20.1-0ubuntu1 Architecture: amd64 Date: Tue Apr 12 14:52:21 2016 JournalErrors: Error: command ['journalctl', '-b', '--priority=warning', '--lines=1000'] failed with exit code 1: Hint: You are currently not seeing messages from other users and the system. Users in the 'systemd-journal' group can see all messages. Pass -q to turn off this notice. No journal files were opened due to insufficient permissions. PackageArchitecture: all SourcePackage: ubuntu-dev-tools UpgradeStatus: No upgrade log present (probably fresh install) [SRU Justification] The mk-sbuild command fails to completely set up its schroot environment if /etc/localtime is a symlink, due to wrong 'cp' options. Since /etc/localtime is a symlink /by default/, this makes the tool unusable for most users in xenial. [Test case] 1. Verify that /etc/localtime is a symlink on your system. 2. Install ubuntu-dev-tools. 3. Run 'mk-sbuild yakkety'. When prompted to edit ~/.sbuildrc, you can accept the defaults. 4. Run 'sg sbuild' to make sure you are in the 'sbuild' group in case this is newly added. 5. Run 'mk-sbuild yakkety' again. Verify that the command output ends with the line: cp: '/etc/localtime' and '/var/lib/schroot/chroots/yakkety-amd64/etc/localtime' are the same file. 6. Run 'echo $?' to verify that the return value of mk-sbuild is 1. 7. Install ubuntu-dev-tools from xenial-proposed. 8. Run 'sudo rm -rf /var/lib/schroot/chroots/yakkety-amd64' to remove the incompletely-bootstrapped directory from the previous attempt. 9. Run 'mk-sbuild yakkety' again. Confirm that the command exits 0. 10. Confirm that 'schroot -l' shows the yakkety-amd64 chroot. On my system, /etc/localtime points to Etc/UTC. When I run mk-sbuild, it fails as follows: I: Base system installed successfully. cp: '/etc/localtime' and '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' are the same file rbasak@diglett:~$ stat /etc/localtime   File: '/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC'   Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 24904635 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:34:01.913544692 +0000 Modify: 2016-04-09 14:16:56.000000000 +0000 Change: 2016-04-11 14:33:38.788003973 +0000  Birth: - rbasak@diglett:~$ stat /var/lib/schroot/chroots/xenial-amd64/etc/localtime   File: '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC'   Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 25958842 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:39:39.042359630 +0000 Modify: 2016-04-12 14:39:39.038359620 +0000 Change: 2016-04-12 14:39:39.038359620 +0000  Birth: - rbasak@diglett:~$ ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: ubuntu-dev-tools 0.155 [modified: usr/bin/mk-sbuild] ProcVersionSignature: Ubuntu 4.4.0-18.34-generic 4.4.6 Uname: Linux 4.4.0-18-generic x86_64 NonfreeKernelModules: zfs zunicode zcommon znvpair zavl ApportVersion: 2.20.1-0ubuntu1 Architecture: amd64 Date: Tue Apr 12 14:52:21 2016 JournalErrors:  Error: command ['journalctl', '-b', '--priority=warning', '--lines=1000'] failed with exit code 1: Hint: You are currently not seeing messages from other users and the system.        Users in the 'systemd-journal' group can see all messages. Pass -q to        turn off this notice.  No journal files were opened due to insufficient permissions. PackageArchitecture: all SourcePackage: ubuntu-dev-tools UpgradeStatus: No upgrade log present (probably fresh install)
2016-07-01 19:33:12 Steve Langasek description [SRU Justification] The mk-sbuild command fails to completely set up its schroot environment if /etc/localtime is a symlink, due to wrong 'cp' options. Since /etc/localtime is a symlink /by default/, this makes the tool unusable for most users in xenial. [Test case] 1. Verify that /etc/localtime is a symlink on your system. 2. Install ubuntu-dev-tools. 3. Run 'mk-sbuild yakkety'. When prompted to edit ~/.sbuildrc, you can accept the defaults. 4. Run 'sg sbuild' to make sure you are in the 'sbuild' group in case this is newly added. 5. Run 'mk-sbuild yakkety' again. Verify that the command output ends with the line: cp: '/etc/localtime' and '/var/lib/schroot/chroots/yakkety-amd64/etc/localtime' are the same file. 6. Run 'echo $?' to verify that the return value of mk-sbuild is 1. 7. Install ubuntu-dev-tools from xenial-proposed. 8. Run 'sudo rm -rf /var/lib/schroot/chroots/yakkety-amd64' to remove the incompletely-bootstrapped directory from the previous attempt. 9. Run 'mk-sbuild yakkety' again. Confirm that the command exits 0. 10. Confirm that 'schroot -l' shows the yakkety-amd64 chroot. On my system, /etc/localtime points to Etc/UTC. When I run mk-sbuild, it fails as follows: I: Base system installed successfully. cp: '/etc/localtime' and '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' are the same file rbasak@diglett:~$ stat /etc/localtime   File: '/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC'   Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 24904635 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:34:01.913544692 +0000 Modify: 2016-04-09 14:16:56.000000000 +0000 Change: 2016-04-11 14:33:38.788003973 +0000  Birth: - rbasak@diglett:~$ stat /var/lib/schroot/chroots/xenial-amd64/etc/localtime   File: '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC'   Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 25958842 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:39:39.042359630 +0000 Modify: 2016-04-12 14:39:39.038359620 +0000 Change: 2016-04-12 14:39:39.038359620 +0000  Birth: - rbasak@diglett:~$ ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: ubuntu-dev-tools 0.155 [modified: usr/bin/mk-sbuild] ProcVersionSignature: Ubuntu 4.4.0-18.34-generic 4.4.6 Uname: Linux 4.4.0-18-generic x86_64 NonfreeKernelModules: zfs zunicode zcommon znvpair zavl ApportVersion: 2.20.1-0ubuntu1 Architecture: amd64 Date: Tue Apr 12 14:52:21 2016 JournalErrors:  Error: command ['journalctl', '-b', '--priority=warning', '--lines=1000'] failed with exit code 1: Hint: You are currently not seeing messages from other users and the system.        Users in the 'systemd-journal' group can see all messages. Pass -q to        turn off this notice.  No journal files were opened due to insufficient permissions. PackageArchitecture: all SourcePackage: ubuntu-dev-tools UpgradeStatus: No upgrade log present (probably fresh install) [SRU Justification] The mk-sbuild command fails to completely set up its schroot environment if /etc/localtime is a symlink to the default timezone file (Etc/UTC), due to wrong 'cp' options. This makes the tool unusable in xenial on systems with a default config. It also causes the tool to do the wrong thing on systems with a user-configured timezone, as the Etc/UTC file within the chroot environment will be overwritten by the host system's zone file, rather than changing the *target* of the /etc/localtime symlink. [Test case] 1. Verify that /etc/localtime is a symlink to /usr/share/zoneinfo/Etc/UTC on your system. 2. Install ubuntu-dev-tools. 3. Run 'mk-sbuild yakkety'. When prompted to edit ~/.sbuildrc, you can accept the defaults. 4. Run 'sg sbuild' to make sure you are in the 'sbuild' group in case this is newly added. 5. Run 'mk-sbuild yakkety' again. Verify that the command output ends with the line: cp: '/etc/localtime' and '/var/lib/schroot/chroots/yakkety-amd64/etc/localtime' are the same file. 6. Run 'echo $?' to verify that the return value of mk-sbuild is 1. 7. Install ubuntu-dev-tools from xenial-proposed. 8. Run 'sudo rm -rf /var/lib/schroot/chroots/yakkety-amd64' to remove the incompletely-bootstrapped directory from the previous attempt. 9. Run 'mk-sbuild yakkety' again. Confirm that the command exits 0. 10. Confirm that 'schroot -l' shows the yakkety-amd64 chroot. [Regression potential] Minimal. We don't want to dereference /etc/localtime when copying it into the target environment; this never DTRT and often fails altogether. The fix for this is small and targeted. On my system, /etc/localtime points to Etc/UTC. When I run mk-sbuild, it fails as follows: I: Base system installed successfully. cp: '/etc/localtime' and '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' are the same file rbasak@diglett:~$ stat /etc/localtime   File: '/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC'   Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 24904635 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:34:01.913544692 +0000 Modify: 2016-04-09 14:16:56.000000000 +0000 Change: 2016-04-11 14:33:38.788003973 +0000  Birth: - rbasak@diglett:~$ stat /var/lib/schroot/chroots/xenial-amd64/etc/localtime   File: '/var/lib/schroot/chroots/xenial-amd64/etc/localtime' -> '/usr/share/zoneinfo/Etc/UTC'   Size: 27 Blocks: 0 IO Block: 4096 symbolic link Device: fa00h/64000d Inode: 25958842 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2016-04-12 14:39:39.042359630 +0000 Modify: 2016-04-12 14:39:39.038359620 +0000 Change: 2016-04-12 14:39:39.038359620 +0000  Birth: - rbasak@diglett:~$ ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: ubuntu-dev-tools 0.155 [modified: usr/bin/mk-sbuild] ProcVersionSignature: Ubuntu 4.4.0-18.34-generic 4.4.6 Uname: Linux 4.4.0-18-generic x86_64 NonfreeKernelModules: zfs zunicode zcommon znvpair zavl ApportVersion: 2.20.1-0ubuntu1 Architecture: amd64 Date: Tue Apr 12 14:52:21 2016 JournalErrors:  Error: command ['journalctl', '-b', '--priority=warning', '--lines=1000'] failed with exit code 1: Hint: You are currently not seeing messages from other users and the system.        Users in the 'systemd-journal' group can see all messages. Pass -q to        turn off this notice.  No journal files were opened due to insufficient permissions. PackageArchitecture: all SourcePackage: ubuntu-dev-tools UpgradeStatus: No upgrade log present (probably fresh install)
2016-07-03 21:37:13 Martin Pitt ubuntu-dev-tools (Ubuntu Xenial): status In Progress Fix Committed
2016-07-03 21:37:14 Martin Pitt bug added subscriber Ubuntu Stable Release Updates Team
2016-07-03 21:37:16 Martin Pitt bug added subscriber SRU Verification
2016-07-03 21:37:18 Martin Pitt tags amd64 apport-bug patch uec-images xenial amd64 apport-bug patch uec-images verification-needed xenial
2016-07-04 03:03:11 Mathew Hodson ubuntu-dev-tools (Ubuntu): importance Undecided High
2016-07-15 07:01:43 Luke Faraone tags amd64 apport-bug patch uec-images verification-needed xenial amd64 apport-bug patch uec-images verification-done xenial
2016-07-18 09:05:40 Launchpad Janitor ubuntu-dev-tools (Ubuntu Xenial): status Fix Committed Fix Released
2016-07-18 09:05:43 Martin Pitt removed subscriber Ubuntu Stable Release Updates Team