update script in ubuntu-meta not handling germinate or specified versions

[Tim Andersson]

update script handled debootstrap and devscripts, does not handle germinate. also doesn't handle potential specified versions in the package directory.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "mysuperpatch.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Graham Inggs (ginggs)]

The debdiff is against 1.481 in jammy, please rebase against the latest version in the development release (currently 1.501 in lunar). You can use 'pull-lp-source ubuntu-meta' for this.
Please also close this bug in the changelog e.g. (LP: #2017786).

We should probably do the same for all the flavour meta packages as well, so this bug should be marked as affecting ubuntu-unity-meta, ubuntucinnamon-meta, etc.

Unsubscribing sponsors for now.

[Tim Andersson (andersson123)]

Please find attached updated debdiff

[Tim Andersson (andersson123)]

Okay, ?th time lucky

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-meta - 1.502

---------------
ubuntu-meta (1.502) mantic; urgency=medium

  * Fix update script to include germinate in 'dependency' check and
    refactor script LP: #2017786

 -- Tim Andersson <email address hidden> Fri, 28 Apr 2023 09:09:28 +0100

[Steve Langasek (vorlon)]

I do not see what this change was supposed to solve. I disagree with the *existing* version check in germinate, and do not want to see more of these - it imposes needless barriers for updating the metapackages.

[Erich Eickmeyer (eeickmeyer)]

Now that I've had some time to look at the patch, I really don't see it solving anything. After seeing Steve's comment, I do agree, it simply puts up needless barriers to updating metapackages. Sorry, but from Ubuntu Studio and Edubuntu, this is a Nack. I hope other flavors follow suit and don't accept this patch.

[Brian Murray (brian-murray)]

@eeickmeyer - the version of the change that actually landed in the package essentially adds the following to the update script:

+if ! which germinate-update-metapackage >/dev/null; then
+ echo >&2 "please install germinate"
+ exit 1
+fi

I think this is a useful improvement as not everyone has germinate installed but do as you wish with your packages.

[Erich Eickmeyer (eeickmeyer)]

@brian-murray

Agreed, simply checking to see whether or not germinate is installed or not is a good idea. However, checking which version is installed, as is currently done with debootstrap, is a bit overkill and I disagree with the debootstrap version check to begin with.

Realistically, if one is running the update script on the current LTS or higher, it shouldn't cause problems and the version check seems to be at least encouraging the update to run on the development version. This seems odd as germinate is pulling from whatever is configured in update.cfg regardless of what series it's being run on, so the version checks just seem like, as Steve put it, needless barriers.

So, in summary, your check for germinate seems sane. A wholesale version check seems overkill and unnecessary.

[Scarlett Gately Moore (scarlettmoore)]

I have opted for the check without the version check. Will be uploaded shortly.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "mysuperpatch.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package kubuntu-meta - 1.443

---------------
kubuntu-meta (1.443) noble; urgency=medium

  * Update update to check for germinate. Ref: (LP: #2017786)

 -- Scarlett Moore <email address hidden> Tue, 27 Feb 2024 05:02:36 -0700

[Benjamin Drung (bdrung)]

I see nothing in this bug that needs sponsoring. Unsubscribing ~ubuntu-sponsors.

[Sean Davis (bluesabre)]

Super low priority and doesn't really fix anything. Declining for Xubuntu.