pro attach fails on interim releases when enabling livepatch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-advantage-tools (Ubuntu) |
Fix Released
|
High
|
Grant Orndorff | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned | ||
Kinetic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
`pro attach` fails on interim releases because it attempts to enable livepatch, which is not supported on interim releases and errors.
The fix is to honor the existing "series" affordance which specifies which releases livepatch can be enabled on.
[ Test Plan ]
`pro attach` on an interim release (kinetic or lunar).
Before the fix, it will fail while enabling Livepatch.
After the fix, it will not attempt to enable livepatch.
[ Where problems could occur ]
The affordance checking code now runs before enabling livepatch. This is well-tested, but if there is an error, then the bug could reoccur in some situation.
More likely, is that we forget to add a supported release to the list of supported releases in the future - which would prevent livepatch from getting enabled on that future supported release.
We'll need to remember this for 24.04 - luckliy this affects all Pro services equally, so we'll add 24.04 to the list of supported releases around the same time we're adding it to ESM.
[ Other Info ]
This bug occurred because we were relaxing our affordance checking before enabling livepatch - in order to allow livepatch client to be the source of truth for whether a certain kernel is supported or not. This is generally good and works for kernel versions and flavors, but interim releases and non-amd64 architectures are not supported at all, so they need to be treated specially.
Related branches
- Athos Ribeiro (community): Approve
- Canonical Server Core Reviewers: Pending requested
- Canonical Server Reporter: Pending requested
-
Diff: 109 lines (+44/-3)6 files modifieddebian/changelog (+7/-0)
features/livepatch.feature (+31/-0)
tools/run-integration-tests.py (+1/-1)
tox.ini (+2/-0)
uaclient/entitlements/livepatch.py (+2/-1)
uaclient/version.py (+1/-1)
Changed in ubuntu-advantage-tools (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Grant Orndorff (orndorffgrant) |
importance: | Undecided → High |
description: | updated |
This bug was fixed in the package ubuntu- advantage- tools - 27.14.3
--------------- advantage- tools (27.14.3) lunar; urgency=medium
ubuntu-
* livepatch: prevent livepatch from auto-enabling and subsequently failing
on interim releases (LP: #2013409)
-- Grant Orndorff <email address hidden> Fri, 31 Mar 2023 10:13:44 -0400