| 2022-09-21 10:28:39 |
Robie Basak |
bug |
|
|
added bug |
| 2022-09-21 11:57:59 |
Renan Rodrigo |
ubuntu-advantage-tools (Ubuntu): assignee |
|
Renan Rodrigo (renanrodrigo) |
|
| 2023-01-04 15:03:09 |
Renan Rodrigo |
ubuntu-advantage-tools (Ubuntu): status |
Triaged |
In Progress |
|
| 2023-01-16 22:33:00 |
Renan Rodrigo |
description |
As discussed in https://code.launchpad.net/~renanrodrigo/ubuntu/+source/ubuntu-advantage-tools/+git/ubuntu-advantage-tools/+merge/429778, there's already code in the postinst that will unconditionally add (pinned to be ignored) ESM repositories to sources.list if run after Bionic's ESM date (April 2023), in order to detect and report what ESM updates are available.
It appears that this will be problematic for users who run in an isolated network environment with their own local apt mirrors or managed apt repositories. For them, "apt-get update" will start to fail on this date, whereas previously it worked. Effectively, for those users, this is a time bomb.
Following discussion we think that we must find a way that does not change users' system apt configuration except when they explicitly opt-in to that.
This bug has an obvious hard deadline, but really needs fixing well in advance to prevent inadvertent triggering of the bug before users have picked up the fix. |
[Impact]
[Original Description]
As discussed in https://code.launchpad.net/~renanrodrigo/ubuntu/+source/ubuntu-advantage-tools/+git/ubuntu-advantage-tools/+merge/429778, there's already code in the postinst that will unconditionally add (pinned to be ignored) ESM repositories to sources.list if run after Bionic's ESM date (April 2023), in order to detect and report what ESM updates are available.
It appears that this will be problematic for users who run in an isolated network environment with their own local apt mirrors or managed apt repositories. For them, "apt-get update" will start to fail on this date, whereas previously it worked. Effectively, for those users, this is a time bomb.
Following discussion we think that we must find a way that does not change users' system apt configuration except when they explicitly opt-in to that.
This bug has an obvious hard deadline, but really needs fixing well in advance to prevent inadvertent triggering of the bug before users have picked up the fix.
[Test Case]
It is important to notice that this 'time bomb' described above will be triggered not only by Bionic reaching ESM (trigger for esm-infra), but also can be triggered by esm-apps as it goes out of beta. This will happen in the exact release where this bug is fixed.
For the functionality: on a Xenial system:
- verify that there is a unauthenticated .lists file for esm-infra
- run security-status and see there are package counts for esm, advertising possible updates
- install ubuntu-advantage-tools >= 27.13
- verify that there are no unauthenticated esm-infra files
- run apt update
- run security-status and see there are package counts for esm, advertising possible updates
For this particular bug fix: on a Bionic system:
- install ubuntu-advantage-tools >= 27.13
- verify that there are no unauthenticated esm-apps files, or esm-infra files
- run apt update
- run security-status and see there are package counts for esm, advertising possible updates
[Regression Potential]
This should be a 'refactor' from the functionality point of view - all integration/acceptance tests are passing following the exact same steps as before, both for security-status and for the apt esm hook. Users are expected to see exactly what they do see today, but without their system configuration being changed.
If we have a gap in our unit/integration tests, then this gap may contain errors that we did not catch yet. We have also tested this change taking into consideration all of the common scenarios where it would run to avoid surprises.
A review from juliank was most helpful to make sure we didn't implement anything wrong with the available apt libraries.
[Discussion]
As discussed in https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2003018, there were pre-SRU reviews for the change that fixes this bug. |
|
| 2023-01-20 17:57:04 |
Andreas Hasenack |
tags |
|
block-proposed-kinetic |
|
| 2023-01-20 17:57:45 |
Andreas Hasenack |
ubuntu-advantage-tools (Ubuntu Kinetic): status |
New |
Fix Committed |
|
| 2023-01-20 17:57:47 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2023-01-20 17:57:49 |
Andreas Hasenack |
bug |
|
|
added subscriber SRU Verification |
| 2023-01-20 17:57:52 |
Andreas Hasenack |
tags |
block-proposed-kinetic |
block-proposed-kinetic verification-needed verification-needed-kinetic |
|
| 2023-01-20 17:59:51 |
Andreas Hasenack |
ubuntu-advantage-tools (Ubuntu Jammy): status |
New |
Fix Committed |
|
| 2023-01-20 17:59:56 |
Andreas Hasenack |
tags |
block-proposed-kinetic verification-needed verification-needed-kinetic |
block-proposed-kinetic verification-needed verification-needed-jammy verification-needed-kinetic |
|
| 2023-01-20 18:01:55 |
Andreas Hasenack |
tags |
block-proposed-kinetic verification-needed verification-needed-jammy verification-needed-kinetic |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-jammy verification-needed-kinetic |
|
| 2023-01-20 18:02:44 |
Andreas Hasenack |
ubuntu-advantage-tools (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2023-01-20 18:02:49 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-jammy verification-needed-kinetic |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-focal verification-needed-jammy verification-needed-kinetic |
|
| 2023-01-20 18:04:26 |
Andreas Hasenack |
ubuntu-advantage-tools (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2023-01-20 18:04:32 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-focal verification-needed-jammy verification-needed-kinetic |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic |
|
| 2023-01-20 18:07:30 |
Andreas Hasenack |
ubuntu-advantage-tools (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2023-01-20 18:07:36 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
|
| 2023-01-20 19:50:00 |
Launchpad Janitor |
ubuntu-advantage-tools (Ubuntu): status |
In Progress |
Fix Released |
|
| 2023-01-23 20:17:02 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-kinetic block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
|
| 2023-01-23 20:20:54 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-focal block-proposed-jammy block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
block-proposed-bionic block-proposed-focal block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
|
| 2023-01-23 20:23:26 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-focal block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
block-proposed-bionic block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
|
| 2023-01-23 20:25:47 |
Andreas Hasenack |
tags |
block-proposed-bionic block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
|
| 2023-01-23 20:28:04 |
Andreas Hasenack |
tags |
block-proposed-xenial verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
|
| 2023-01-25 18:15:27 |
Grant Orndorff |
attachment added |
|
verification-1990378.txt https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1990378/+attachment/5643480/+files/verification-1990378.txt |
|
| 2023-01-25 18:15:54 |
Grant Orndorff |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-kinetic verification-needed-xenial |
verification-done verification-done-bionic verification-done-focal verification-done-jammy verification-done-kinetic verification-done-xenial |
|
| 2023-01-26 11:33:22 |
Launchpad Janitor |
ubuntu-advantage-tools (Ubuntu Kinetic): status |
Fix Committed |
Fix Released |
|
| 2023-01-26 11:33:31 |
Andreas Hasenack |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2023-01-26 11:34:06 |
Launchpad Janitor |
ubuntu-advantage-tools (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2023-01-26 11:35:07 |
Launchpad Janitor |
ubuntu-advantage-tools (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2023-01-26 11:35:57 |
Launchpad Janitor |
ubuntu-advantage-tools (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2023-01-26 11:36:23 |
Launchpad Janitor |
ubuntu-advantage-tools (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
