Comment 45 for bug 1719671

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok, we managed to change the code a bit to support running tests with python 3.4, which is in trusty. But we did that for master only:
https://github.com/CanonicalLtd/ubuntu-advantage-script/commit/4f6740e1a9b6106eb5567f4be057baca82f23b91

Then a following packaging change to run the tests at package build time:
https://github.com/CanonicalLtd/ubuntu-advantage-script/commit/f3b6bfac5911f248499c79a42a0d18f12ca9065a

Here is our recipe for daily builds with those two incorporated:
https://code.launchpad.net/~ahasenack/+recipe/ubuntu-advantage-script-daily

All binary builds there have a test run incorporated.

This is not contemplated in this SRU, but is a step in the right direction.

The SRU started with backporting what's in artful, and there the tests don't run at package build time. Would such a change be accepted in the SRU'ed packages only? I.e., add tests at package build time for xenial and zesty, while artful (and bionic) don't have them yet?

Or maybe just a manual test run for trusty, xenial and zesty, and attach the logs to this bug? Given that upstream is now running tests at package build time for all of these. In trusty I can run the tests from this package as long as I install python 3.5 or 3.6 on it.