Preseeded installation doesn't reboot unless ubiquity/poweroff is also set
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubiquity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Binary package hint: ubiquity
Ubuntu release: natty daily from 20110301
Ubiquity version: 2.5.21, revno 392
It used to be that we could get preseeded, automated installations to reboot when finished by setting:
ubiquity ubiquity/reboot boolean true
However, this stopped working recently. I found out that we now need to set two values in order for the system to reboot when finished:
ubiquity ubiquity/reboot boolean true
ubiquity ubiquity/poweroff boolean true
I tracked down the change to Ubiquity 2.5.13 where code was added to ubiquity/
The code expresses this but it seems to me that it's incorrect, and one should be able to get a reboot or shutdown by setting only the actual, desired value. What's more, if they are both set, ubiquity/reboot takes precedence because it comes first in the code, meaning that the section of code that issues a shutdown will never get called.
The problem line (610 on gtk_ui.py, 483 on kde_ui.py) says:
elif not self.get_
should be:
elif not self.get_
or (I think it's clearer):
elif not (self.get_
The attached patch implements the proposed changes.
Setting as Triaged, as there is a patch attached.