Preseeded installation doesn't reboot unless ubiquity/poweroff is also set

Bug #727416 reported by Daniel Manrique on 2011-03-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Medium
Unassigned

Bug Description

Binary package hint: ubiquity

Ubuntu release: natty daily from 20110301
Ubiquity version: 2.5.21, revno 392

It used to be that we could get preseeded, automated installations to reboot when finished by setting:

ubiquity ubiquity/reboot boolean true

However, this stopped working recently. I found out that we now need to set two values in order for the system to reboot when finished:

ubiquity ubiquity/reboot boolean true
ubiquity ubiquity/poweroff boolean true

I tracked down the change to Ubiquity 2.5.13 where code was added to ubiquity/frontend/gtk_ui.py and ubiquity/frontend/kde_ui.py, to fix bug #690726. Starting in that version, for the system to *either* reboot or shutdown (the latter via ubiquity/poweroff), *both* of these options have to be set to true.

The code expresses this but it seems to me that it's incorrect, and one should be able to get a reboot or shutdown by setting only the actual, desired value. What's more, if they are both set, ubiquity/reboot takes precedence because it comes first in the code, meaning that the section of code that issues a shutdown will never get called.

The problem line (610 on gtk_ui.py, 483 on kde_ui.py) says:

elif not self.get_reboot_seen() or not self.get_shutdown_seen():

should be:

elif not self.get_reboot_seen() and not self.get_shutdown_seen():

or (I think it's clearer):

elif not (self.get_reboot_seen() or self.get_shutdown_seen()):

The attached patch implements the proposed changes.

Daniel Manrique (roadmr) wrote :
Ara Pulido (ara) wrote :

Setting as Triaged, as there is a patch attached.

Changed in ubiquity (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Colin Watson (cjwatson) wrote :

Thanks! Applied.

Changed in ubiquity (Ubuntu):
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.5.26

---------------
ubiquity (2.5.26) natty; urgency=low

  [ Evan Dandrea ]
  * Revert dropping privileges earlier (LP: #730209).

  [ Colin Watson ]
  * Update for changes in localechooser up to 2.34ubuntu1.
  * Automatic update of included source packages: localechooser 2.34ubuntu2,
    partman-auto 93ubuntu10.
  * Update translations from Launchpad.
  * GTK frontend:
    - Translate some other possible versions of the next button when
      changing language (LP: #730208).

  [ Daniel Manrique ]
  * Allow preseeding only ubiquity/reboot to suppress the reboot dialog,
    without needing to preseed ubiquity/poweroff as well (LP: #727416).
 -- Colin Watson <email address hidden> Tue, 15 Mar 2011 17:34:27 +0000

Changed in ubiquity (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers