Support for lxdm in ubiquity (autologin, only-ubiquity support)

Bug #546445 reported by Julien Lavergne
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Wishlist
Unassigned
user-setup (Ubuntu)
Wishlist
Unassigned

Bug Description

Binary package hint: ubiquity

Attached branch add the support of autologin and only-ubiquity mode, when lxdm is used instead of gdm.

bzr branch : https://code.launchpad.net/~gilir/+junk/ubiquity-lxdm-autologin

Related branches

Julien Lavergne (gilir)
Changed in ubiquity (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Julien Lavergne (gilir) wrote :
Julien Lavergne (gilir)
summary: - Support for autologin when lxdm is used
+ Support for lxdm in ubiquity (autologin, only-ubiquity support)
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Evan, could you review that patch?

Revision history for this message
Julien Lavergne (gilir) wrote :

Attached is an updated patch vs 2.4.8 version, which add support for autologin with lxdm, and only-install mode with Lubuntu.

Revision history for this message
Julien Lavergne (gilir) wrote :
Revision history for this message
Artur Rona (ari-tczew) wrote :

Ping on this one. Julien, could you prepare a debdiff?

Changed in ubiquity (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Julien Lavergne (gilir) wrote :

I waiting for a feedback for 9 month on it, I don't want to prepare a debdiff each time ubiquity is updated. The diff in on the branch attached, Evan or any people working on ubiquity just need to merge it into the main ubiquity branch when it's ready. No need for a debdiff right now.

Changed in ubiquity (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Michael Vogt (mvo) wrote :

Hey Julien, thanks for your branch! I think it would be good if you could create a merge proposal into lp:ubiquity for it. AFAICS there is none created yet?

I looked over the diff and while I'm not a ubiquity expert I think it looks fine. My only question would be if it needs to run a full lxde session (the other DE environments seem to not run the full session AFAICS) and if the line:

            if os.path.exists('/usr/lib/ubiquity/panel') and "xfwm4" not in wm_cmd:

needs a additional 'not not "openbox-lubuntu" in wm_cmd'.

Revision history for this message
Michael Vogt (mvo) wrote :

For this particular bug I think its more appropriate to use a bzr branch merge request into lp:ubiquity. I will remove ubuntu-sponsors as there is nothing to sponsor (as such :)

Revision history for this message
Evan (ev) wrote :

Indeed, can you please branch against lp:ubiquity. As it stands, I would have to manually merge this, losing the revision history.

Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks for the advises, I submit 2 merge requests, as one part of the patch is in the user-setup package.

Concerning the lxde session, the lxsession is called with -a, which launch a minimal session (only the xsettings stuff is launched, no panel, no applications autostarted). I also let the ubiquity panel to this session to add the minimal panel to the session.

Colin Watson (cjwatson)
Changed in user-setup (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package user-setup - 1.28ubuntu11

---------------
user-setup (1.28ubuntu11) natty; urgency=low

  * Add support for autologin when lxdm is installed (LP: #546445)
 -- Julien Lavergne <email address hidden> Mon, 29 Nov 2010 13:18:31 +0000

Changed in user-setup (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

Sorry for the delay on this! These patches look fine, and I'll make sure they're all merged for Natty Alpha 1.

Colin Watson (cjwatson)
Changed in ubiquity (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.5.2

---------------
ubiquity (2.5.2) natty; urgency=low

  [ Julien Lavergne ]
  * debian/ubiquity.ubiquity.upstart, debian/oem-config.oem-config.upstart:
    - Add lxdm support.
  * Add support for openbox-lubuntu and lxsession for ubiquity-dm (LP: #546445)

  [ Colin Watson ]
  * Automatic update of included source packages: apt-setup 1:0.49ubuntu2,
    user-setup 1.28ubuntu11.
 -- Colin Watson <email address hidden> Mon, 29 Nov 2010 14:59:02 +0000

Changed in ubiquity (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers