Activity log for bug #235374

Date Who What changed Old value New value Message
2008-05-28 02:19:06 Glenn McDonald bug added bug
2008-05-29 19:03:25 Evan ubiquity: status New Confirmed
2008-05-29 19:03:25 Evan ubiquity: assignee evand
2008-05-29 19:03:25 Evan ubiquity: importance Undecided Medium
2008-05-30 19:10:05 Evan ubiquity: status Confirmed Fix Committed
2008-06-02 17:20:40 Evan description There is a sequence of events that can cause the Ubiquity installer in Hardy Herron (8.04) to loop at step 4, the partitioning step. Steps to reproduce are: 1) Run the installer, click "Forward" until you get to Step 5, Who are you? 2) Enter all data correctly except for the "What is the name of this computer?" field - enter a name with an underscore (or presumably any other non-valid character) and press "Forward" 3) The installer will complain that the computer name is invalid. 4) Click "Back" to go back to Step 4, the partition editor 5) Press "Forward" - partition editor rescans the disk and step 4 starts again (this will happen every time you press "Forward", and happens regardless of what settings you choose for the partitions.) My guess is the invalid variable is not cleared when "Back" is pressed, and there is a validation error when an attempt is made to re-insert the bad value into step 5, causing step 4 to repeat. The installer fails to reset the variable that causes it to stay on a page when an error is triggered when returning to a previous page, causing it to stay on the previous page that it just returned to despite any attempts to proceed. This will occur if a user enters an invalid password, then presses back to change their partition layout. If they try to proceed forward to the user setup page again, they will remain on the partitioning page. This is a one line change that should have no regressions. A diff of the proposed change as included in the ubiquity 1.8.9 upload can be found here: TEST CASE: 1) Run the installer, click "Forward" until you get to Step 5, Who are you? 2) Enter all data correctly except for the "What is the name of this computer?" field - enter a name with an underscore (or presumably any other non-valid character) and press "Forward" 3) The installer will complain that the computer name is invalid. 4) Click "Back" to go back to Step 4, the partition editor 5) Press "Forward" - partition editor rescans the disk and step 4 starts again (this will happen every time you press "Forward", and happens regardless of what settings you choose for the partitions.) Original report: There is a sequence of events that can cause the Ubiquity installer in Hardy Herron (8.04) to loop at step 4, the partitioning step.
2008-06-02 17:22:27 Evan bug added attachment '235374-reset-error.patch' (235374-reset-error.patch)
2008-06-02 18:35:06 Launchpad Janitor ubiquity: status Fix Committed Fix Released
2008-06-03 10:41:36 Martin Pitt ubiquity: status New Fix Committed
2008-09-19 08:33:13 Steve Beattie ubiquity: status Fix Committed Fix Released
2008-09-19 08:33:13 Steve Beattie ubiquity: statusexplanation The 8.04 proposed package that addressed this issue was released but this bug was not referred to in the changelog. Marking as fix released.
2010-02-22 10:41:25 Launchpad Janitor branch linked lp:ubuntu/ubiquity
2010-02-22 10:45:55 Launchpad Janitor branch linked lp:ubuntu/hardy-updates/ubiquity