ubiquity: autopkgtest fails in test_city_entry

Bug #2022965 reported by Nick Rosbrook
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Won't Fix
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Won't Fix
Undecided
Unassigned

Bug Description

[Impact]

The unit test in ubiquity's autopkgtest are failing for focal, jammy, and kinetic. This is caused by a tzdata change and has happened in the past, but in reverse (see bug 1951519). The current failure is:

======================================================================
FAIL: test_city_entry (test_timezone.TimezoneTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1330, in patched
    return func(*args, **keywargs)
  File "/tmp/autopkgtest.ThYxjs/build.Pwg/src/tests/test_timezone.py", line 58, in test_city_entry
    self.assertEqual(set(results), set(expected))
AssertionError: Items in the first set but not the second:
('Eastern', 'Canada')
Items in the second set but not the first:
('Eastern', 'Bahamas')

----------------------------------------------------------------------
Ran 89 tests in 10.662s

FAILED (failures=1, skipped=1)
autopkgtest [22:32:51]: test unit: -----------------------]
unit FAIL non-zero exit status 1
autopkgtest [22:32:52]: test unit: - - - - - - - - - - results - - - - - - - - - -
autopkgtest [22:32:52]: @@@@@@@@@@@@@@@@@@@@ summary
unit FAIL non-zero exit status 1

[Test Plan]

Run autopkgtest for ubiquity.

[Where problems could occur]

The patch modifies expected output in a test file, so any impacts would be confined to running the test_city_entry unit test.

Related branches

Nick Rosbrook (enr0n)
Changed in ubiquity (Ubuntu):
status: New → Fix Released
Revision history for this message
Nick Rosbrook (enr0n) wrote :

Since there won't be any more point releases for focal or kinetic, it's actually not worth fixing there.

Changed in ubiquity (Ubuntu Focal):
status: New → Won't Fix
Changed in ubiquity (Ubuntu Kinetic):
status: New → Won't Fix
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Nick, or anyone else affected,

Accepted ubiquity into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/22.04.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubiquity (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Nick Rosbrook (enr0n) wrote :
tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 22.04.20

---------------
ubiquity (22.04.20) jammy; urgency=medium

  [ Steve Langasek ]
  * Whenever removing packages, use apt-get autoremove --purge instead of
    apt-get purge so that no-longer-used dependencies are removed together
    with the package in question, and we do not leave behind any packages
    that will be reported as autoremovable later. LP: #1925265.
  * bin/oem-config-remove-gtk uses aptdaemon to remove packages, not
    apt-get. Set the flag to autoremove dependencies here as well.

  [ Nick Rosbrook ]
  * tests: modify test_city_entry to adapt to tzdata update (LP: #2022965)

  [ Shih-Yuan Lee (FourDollars) ]
  * Use dpkg-divert /sbin/start-stop-daemon unconditionally instead of just
    renaming it conditionally. (LP: #1978931)

 -- Steve Langasek <email address hidden> Mon, 05 Jun 2023 14:36:01 -0700

Changed in ubiquity (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Update Released

The verification of the Stable Release Update for ubiquity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.