Always create the ESP

Bug #1847721 reported by Didier Roche on 2019-10-11
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
partman-auto (Ubuntu)
Undecided
Unassigned
partman-efi (Ubuntu)
Medium
Unassigned
ubiquity (Ubuntu)
Undecided
Unassigned

Bug Description

For a smoother transition for people who disabled and enabled secure boot later on, Steve mentioned to always create the ESP partition.

We can then install grub into the ESP.

Related branches

Yes; this will furthermore require work in grub-installer, partman-auto, and partman-efi.

Changed in partman-efi (Ubuntu):
status: New → In Progress
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
importance: Undecided → Medium
Changed in ubiquity (Ubuntu):
status: New → Triaged
tags: added: id-5da5c3543d6088838f8778e8
Changed in partman-efi (Ubuntu):
assignee: Mathieu Trudel-Lapierre (cyphermox) → nobody
Changed in partman-auto (Ubuntu):
status: New → Fix Released
Dimitri John Ledkov (xnox) wrote :

partman-auto recipes got adjusted so ESP is now created even under BIOS boot of ubiquity.

However, it simply is empty at the moment. We should "install" both PC & UEFI grub onto it, somehow.

Jean-Baptiste Lallement (jibel) wrote :

Note: Currently on MBR systems the ESP is created with a type 'b' and EFI is type 'ef'

Jean-Baptiste Lallement (jibel) wrote :

The second issue is that there is no partition type for partition 1 on the "Write changes to disk?" confirmation dialog in Ubiquity.

It's written:
"Partition #1 of Virtual Disk 1 (vda) as"

Michael Hudson-Doyle (mwhudson) wrote :

Had a stare at this.

partman-efi mostly disables itself if not booted under EFI (https://git.launchpad.net/ubuntu/+source/partman-efi/tree/init.d/efi?h=ubuntu/groovy#n15), I think that's why the partition type doesn't get set and why the partition doesn't get formatted. I'm not sure what the consequence of simply not checking that would be.

Also, I think grub-installer needs to grow a way to override archdetect (maybe just ARCH="${ARCH:-$(archdetect)}" or whatever) and ubiquity needs to call it twice.

IOW this is a fair bit of work.

Dimitri John Ledkov (xnox) wrote :
tags: added: patch
Dimitri John Ledkov (xnox) wrote :
Dimitri John Ledkov (xnox) wrote :

Hm, the grub-installer patch will not do the right thing. Because we need to install pc stuff on the bios bootdev, and unless the package grub_package is set to grub-pc this will not happen.

Launchpad Janitor (janitor) wrote :
Download full text (4.3 KiB)

This bug was fixed in the package partman-efi - 84ubuntu1

---------------
partman-efi (84ubuntu1) groovy; urgency=low

  * Merge from Debian unstable. Remaining changes:
    - check.d/efi: Make sure we block on a missing EFI partition no matter what
      architecture, not just for ia64. One could attempt to install on EFI x86
      and will need an ESP to be able to install GRUB. (LP: #1803031)
    - debian/partman-efi.templates: Make the no_efi template clearer, so that it
      clearly explains why an EFI System partition is important.
    - Clean-up leftover checks for the no longer used ignore_uefi file.
    - Save the number of ESPs found to /var/lib/partman/efi_esp_count for
      partman-auto. (LP: #1766945)
    - Do not ask the user about forcing UEFI installation if there are BIOS
      compatibility mode installed systems as those will still be bootable from
      grub if we proceed in UEFI mode. (LP: #1668148)
    - debian/partman-efi.templates: remove the partman-efi/non_efi_system
      template as we no longer need it.
    - Remove efi-modules dependency; it seems to be built into Ubuntu
      kernels now.
    - Require partman-base >= 129 to support a null value for the name.
    - Only force an EFI system partition on ia64.
    - Allow x86/macs booted in legacy mode to use EFI System partitions.

  * Always init EFI mode, irrespective if booted in EFI or legacy
    mode. LP: #1847721

partman-efi (84) unstable; urgency=medium

  * Team upload

  [ Updated translations ]
  * Estonian (et.po) by Kristjan Räts
  * Korean (ko.po) by Changwoo Ryu
  * Portuguese (Brazil) (pt_BR.po) by Adriano Rafael Gomes
  * Tamil (ta.po) by Jeyanthinath MuthuRam

partman-efi (83) unstable; urgency=medium

  * Team upload

  [ Updated translations ]
  * Russian (ru.po) by Lev Lamberov

partman-efi (82) unstable; urgency=medium

  * Team upload

  [ Updated translations ]
  * Czech (cs.po) by Miroslav Kure
  * Esperanto (eo.po) by Felipe Castro
  * Croatian (hr.po) by Milo Ivir
  * Indonesian (id.po) by Andika Triwidada
  * Icelandic (is.po) by Sveinn í Felli
  * Swedish (sv.po) by Anders Jonsson
  * Simplified Chinese (zh_CN.po) by 玉堂白鹤

partman-efi (81) unstable; urgency=medium

  * Team upload

  [ Cyril Brulebois ]
  * Remove Christian Perrier from Uploaders, with many thanks for all
    his contributions over the years! (Closes: #927572)

  [ Holger Wansing ]
  * Remove trailing whitespaces from changelog file, to fix lintian tag.
  * Adapt sublevel definitions for template strings; also mark an ia64-only
    string as not-translatable (no need for translators to work on this
    dropped arch).
    Includes udating all po|pot files.

  [ Updated translations ]
  * German (de.po) by Holger Wansing
  * French (fr.po) by Baptiste Jammet
  * Hebrew (he.po) by Yaron Shahrabani
  * Indonesian (id.po) by Andika Triwidada
  * Icelandic (is.po) by Sveinn í Felli
  * Dutch (nl.po) by Frans Spiesschaert
  * Punjabi (Gurmukhi) (pa.po) by Aman ALam
  * Portuguese (pt.po) by Miguel Figueiredo
  * Serbian (sr.po) by Filipovic Dragan

partman-efi (80) unstable; urgency=medium

  * Team upload

  [ Cyril Brulebois ]
  * Update Vcs-{Browser,Git} to point to ...

Read more...

Changed in partman-efi (Ubuntu):
status: In Progress → Fix Released
Dimitri John Ledkov (xnox) wrote :

This is now fixed in today's daily. The partition is formatted "as ESP".

Changed in ubiquity (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers