Ubuntu
tsclient package

Wrong X-Ubuntu-Gettext-Domain key in tsclient.desktop file

Bug #84544 reported by Kamil Páral on 2007-02-11

Affects		Status	Importance	Assigned to	Milestone
	tsclient (Ubuntu)	Fix Released	High	Jonh Wendell

Bug Description

Binary package hint: tsclient

Ubuntu 6.10.
In tsclient.desktop file, X-Ubuntu-Gettext-Domain key is not in [Desktop Entry] section, but in [Desktop Action Full] section. I don't really know what this section is for, but it is causing a problem, when you update translations for menu items in package tsclient using rosseta. This changes would not apply, and old translations from tsclient.desktop file would be still valid. Moving X-Ubuntu-Gettext-Domain key into [Desktop Entry] section helped, when I tried it.

Revision history for this message

Pascal De Vuyst (pascal-devuyst) wrote on 2007-02-11:

Confirmed on both Feisty and Edgy.

Changed in tsclient:
importance:	Undecided → Low
status:	Unconfirmed → Confirmed

Revision history for this message

Pascal De Vuyst (pascal-devuyst) wrote on 2007-02-11:

desktop file errors Edit (3.0 KiB, text/plain)

There are some problems with the desktop file.
desktop-file-validate returns some errors (see attachment).
Could someone with more knowledge of the desktop file specification provide an improved desktop file.
Is it valid to have a [Desktop Action Full] section?

Revision history for this message

Kamil Páral (kamil.paral) wrote on 2007-02-13:

Well, i can't help you with that. But i think this bug should get a higher importance, so someone could notice it and fix it.

My other (very similar) reported bug got "high" importance
https://bugs.launchpad.net/ubuntu/+source/gnome-utils/+bug/84556
and was fixed almost immediately.

Untranslatable menu entries are very unpleasant for non-english speaking countries.

Thank you.

Changed in tsclient:
assignee:	nobody → desktop-bugs

Pascal De Vuyst (pascal-devuyst) on 2007-02-13

Changed in tsclient:
importance:	Low → High

Revision history for this message

Jonh Wendell (wendell) wrote on 2007-02-15:

Proposed patch Edit (466 bytes, text/plain)

Changed in tsclient:
assignee:	desktop-bugs → wendell

Revision history for this message

Pascal De Vuyst (pascal-devuyst) wrote on 2007-02-15:

Thanks a lot for the path Jonh Wendell.
After reading the freedesktop.org desktop entry en menu spec I have the following remarks: the Encoding key is deprecated and the category "Application" isn't valid. Could you provide a new patch with these removed.

Revision history for this message

Jonh Wendell (wendell) wrote on 2007-02-15:

I don't know if we can do that. I see a lot of applications using both of them. See /usr/share/applications/*.desktop

Revision history for this message

Sebastien Bacher (seb128) wrote on 2007-02-18:

That upload fixes the problem:

tsclient (0.148-2ubuntu2) feisty; urgency=low
.
   * debian/control.in:
     - updated Maintainer information
   * debian/patches/16_fix_desktop_menu_item.patch:
     - fix desktop category and translation domain use (Ubuntu: #84544)
   * debian/patches/20_return_launchs_connect.patch:
     - make "connect" be the default action when somebody uses the enter key,
       patch by Jonh Wendell (Ubuntu: #61918)