tsclient always tries to reconnect

Bug #293660 reported by clovepower
94
This bug affects 14 people
Affects Status Importance Assigned to Milestone
tsclient (Ubuntu)
Invalid
Undecided
Unassigned
Nominated for Lucid by Sam Illingworth

Bug Description

Binary package hint: tsclient

tsclient 0.150-1ubuntu1

Ubuntu 8.04.1 AMD64 Desktop Linux set 2.6.24-21-generic

When I connect to a Windows XP box and I choose "log off" my session is closed on the Windows side but soon after tsclient tries to reconnect and re-opens it if I do not stop it, which is rather annoying.

tsclient should try to re-open a connection only if it dropped because of a network failure and not because the user required to be disconnected.

I realize it might not be possible to distinguish between the two cases from tsclient, but then at least a check box to disable this behavior should be provided. I would find much less annoying to reconnect on an error than to stop ts from reconnecting each time.

Revision history for this message
Cyrille Grosdemange (ze-cyrilou) wrote :

same bug on jaunty (alpha5 2009 mar, 11th)

Revision history for this message
Aaron Roydhouse (aaron-roydhouse) wrote :

I've found reports of this bug back as far as 2005. I affects me too on 8.04 and 8.10.

It appears that if rdesktop generates any output or perhaps exit code at all, then tsclient treats that a valid reason to reconnect.

So, for example, if you request 24-bit colour and the remote computer only supports 16-bit, rdesktop outputs a warning (no problem). Later however, when rdesktop exits because you deliberately closed it, tsclient uses the earlier warning about colour depth to trigger an automatic reconnect. Very frustrating.

  http://ubuntuforums.org/showthread.php?t=86131

  http://ubuntuforums.org/showthread.php?p=3659984

The reconnect behaviour needs to be removed or disabled until it gets smarter about checking the rdesktop messages.

Aaron.

Revision history for this message
bucketoftruth (6-launchpad-troutpocket-org) wrote :

I've found that if I close the tsclient connect window in the background then I'm not prompted to reconnect. It only tries to reconnect if I leave that window open.

Revision history for this message
elijahr (elijahr) wrote :

This bug can be very problematic. Take this situation for instance:
User A logs into Server X with tsclient, does some work, and goes home for the day, leaving tsclient connected to Server X's console.
While User A is away, an emergency comes up and User B needs access to Server X. User B connects to Server X using any terminal server client. This disconnects User A's tsclient, but triggers the automatic reconnect. Subsequently, every 30 seconds, User A's tsclient will kick User B off of Server X, until User A comes home the next day and clicks "Cancel" in the automatic reconnect prompt.

A patch is provided here:
http://brainstorm.ubuntu.com/idea/1035/

Revision history for this message
pat72 (f-bastianello) wrote :

Also on Karmic x86_64

Revision history for this message
Sam Illingworth (mazz0) wrote :

This bug's being going on for ages! Please let's get it fixed for Lucid!

Can anyone give me instructions for installing that patch (and indeed other patches)?

Revision history for this message
liquidweaver (joshuaweaver) wrote :

I too have been dealing with this for, well, about forever.
I touch at least 2-3 different Ubuntu machines and run tsclient from all of them, and I got really fed up with this.
Here's a rebuilt Karmic .deb with the offending code removed (as of 1/19/2010)

Revision history for this message
Sam Illingworth (mazz0) wrote :

@ liquidweaver

:D I love you.

Revision history for this message
liquidweaver (joshuaweaver) wrote :

I love you too, Sam.

Revision history for this message
Jonas Schwertfeger (j-n-s08) wrote :

Fix from http://brainstorm.ubuntu.com/idea/1035/: Save your connection parameters in an RDP file using tsclient, open that file in a text editor and add the line

reconnect_policy:s:never

to the end. Now you can either open that file manually in the tsclient GUI, or load it automatically by executing

tsclient myprofile.rdp

or even establish a connection right away by executing

tsclient -x myprofile.rdp

Revision history for this message
Jonas Schwertfeger (j-n-s08) wrote :

Sorry, obviously this is not a "fix", it is a workaround; the correct solution would be to add a drop-down list to the UI allowing one to select the reconnect policy.

Asif Youssuff (yoasif)
Changed in tsclient (Ubuntu):
status: New → Confirmed
Revision history for this message
funkyFlash (lexotron314) wrote :

I also find this irritating, and would like to see it fixed properly. I like having the reconnect policy for when I actually do have network problems (which happen far too often at my company), but don't want it when I log out/get kicked off a machine.

I probably wouldn't find this bug so bothersome if tsclient wasn't the de-facto RDP client for Ubuntu. Granted, other rdesktop front-ends irritate me just as much...

Revision history for this message
f1anker (ianspigeon) wrote :

Same issue for me in Ubuntu Lucid RC1, also occurs if you just close the window rather than logging off.

Remote server: windows 2003/2008
Protocol: RDPv5
tsclient version: 0.150-3ubuntu1

Revision history for this message
Angus (gusspam) wrote :

Still exists in Lucid. Thanks @Sam for the recompile, makes my life alot easier considering I have to use RDP a lot.

Revision history for this message
Nogero (oregonbob) wrote :

If you save an RDP file for each destination, then use QuickConnect button to select from your server choices (RDP files), It won't automatically reconnect. I have developed a habit of only using the QuickConnect buttons and my RDP files to avoid that problem. It is a big nuisance. They should have a simple on/off menu item that you can set default. That would be easiest change to source I would expect.

Revision history for this message
Pierre Rudloff (rudloff) wrote :

Any news on this bug ?
I can still reproduce on Natty.

Revision history for this message
Nogero (oregonbob) wrote :

Yes, this bug still exists. Another painful bug and security vulnerability is that it saves plain text passwords. These critical bugs have existed for years and no one wants to correct them. I don't know how to program this code but I did I surely would fix it. Tsclient is an important application!

Revision history for this message
liquidweaver (joshuaweaver) wrote : Re: [Bug 293660] Re: tsclient always tries to reconnect

I have corrected it - even submitted a patch and was wholly ignored.
Guess I'm not in the club.

On Sun, Jul 24, 2011 at 2:51 PM, Nogero <email address hidden> wrote:
> Yes, this bug still exists. Another painful bug and security
> vulnerability is that it saves plain text passwords. These critical bugs
> have existed for years and no one wants to correct them. I don't know
> how to program this code but I did I surely would fix it. Tsclient is an
> important application!
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/293660
>
> Title:
>  tsclient always tries to reconnect
>
> Status in “tsclient” package in Ubuntu:
>  Confirmed
>
> Bug description:
>  Binary package hint: tsclient
>
>  tsclient 0.150-1ubuntu1
>
>  Ubuntu 8.04.1 AMD64 Desktop Linux set 2.6.24-21-generic
>
>  When I connect to a Windows XP box and I choose "log off" my session
>  is closed on the Windows side but soon after tsclient tries to
>  reconnect and re-opens it if I do not stop it, which is rather
>  annoying.
>
>  tsclient should try to re-open a connection only if it dropped because
>  of a network failure and not because the user required to be
>  disconnected.
>
>  I realize it might not be possible to distinguish between the two
>  cases from tsclient, but then at least a check box to disable this
>  behavior should be provided. I would find much less annoying to
>  reconnect on an error than to stop ts from reconnecting each time.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/tsclient/+bug/293660/+subscriptions
>

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thank you for reporting this bug. tsclient has been removed from the Ubuntu 11.10 archives. The software has not had a new release in years and was no longer being maintained. Unfortunately that means this bug won't be fixed.

Changed in tsclient (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Brian Carlson (abutilize) wrote :

So if tsclient is being removed from the archives/repositories, is there a plan to support another application?

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Yes, I apologize for not mentioning a replacement. Remote Desktop Viewer (Vinagre) which has shipped on the CD for years supports RDP in addition to VNC, starting with Ubuntu 11.10 "Oneiric". Alternatively, you could look at Remmina.

Revision history for this message
Hari (haridara) wrote :

@liquidweaver do you have a 64-bit deb with your change?

Revision history for this message
liquidweaver (joshuaweaver) wrote :

@Hari - I do not.
I'm using Arch on most of my machines now, I wasn't a big fan of Unity or KDE.
The process is essentially to grab a patch for tsclient (there are a few if you google it), grab the source with "apt-get source tsclient", apply the patch (probably with "cat [patchfile] | patch -p0"), and then run the debian build script to make the package.

Revision history for this message
liquidweaver (joshuaweaver) wrote : Joshua Weaver has shared a document on Google Docs with you
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.