Trusted prompts need to be part of the lifecycle

Bug #1384950 reported by Michał Sawicz on 2014-10-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
High
Unassigned
Mir
Fix Released
Medium
Nick Dedekind
0.8
Fix Released
Medium
Cemil Azizoglu
mir (Ubuntu)
Medium
Unassigned
mir (Ubuntu RTM)
Undecided
Cemil Azizoglu
pay-service (Ubuntu)
Undecided
Unassigned
qtmir (Ubuntu)
Undecided
Nick Dedekind
qtmir (Ubuntu RTM)
Undecided
Michał Sawicz
trust-store (Ubuntu)
Undecided
Unassigned
ubuntu-system-settings-online-accounts (Ubuntu)
Undecided
Unassigned

Bug Description

After we fix bug #1355173, we'll be "leaking" trusted prompts in the sense that when an app gets unfocused (and potentially killed subsequently), the trusted prompts will be left running, not suspended with the app. We should apply the same rules to the whole app container (can we use ual? add the prompts to the pgroup/cgroup?).

This needs an escape route, too, for trusted helpers to be able to kill prompts as they need to.

Related branches

Michał Sawicz (saviq) on 2014-10-23
Changed in unity8 (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Nick Dedekind (nick-dedekind)
Nick Dedekind (nick-dedekind) wrote :

I'm not too sure about suspending the prompt helper along with the application, since it's a long running service in some cases. This is where the logic for bailing out of prompts should be (not in the prompt providers UIs)
The prompt providers UIs are fine to suspend since they're only associated with one instance of a prompt session (process/control group would help here).

We have a prompt session state (stopped/started), which could be modified to accept a suspend state. We could pick this up in the prompt helper client and do the necessary (start time-out/whatever)

Michał Sawicz (saviq) wrote :

Oh yeah, we should never suspend helpers, that's for sure.

I'm not even totally sure we should be suspending the UIs, after all those are *trusted* prompts, meaning they should be able to trust they won't go haywire with the CPU.

Changed in mir:
assignee: nobody → Nick Dedekind (nick-dedekind)
milestone: none → 0.10.0
status: New → In Progress
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 2167, scheduled for release in mir, milestone 0.10.0

Changed in mir:
status: In Progress → Fix Committed
Changed in mir:
importance: Undecided → Medium
Changed in mir:
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt) wrote :

mir (0.10.0+15.04.20150107.2-0ubuntu1) vivid; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Fix Released
Michał Sawicz (saviq) on 2015-01-09
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
Changed in qtmir (Ubuntu):
status: New → In Progress
assignee: nobody → Nick Dedekind (nick-dedekind)
no longer affects: unity8 (Ubuntu)
no longer affects: unity8 (Ubuntu RTM)
Changed in mir (Ubuntu RTM):
status: New → In Progress
assignee: nobody → Cemil Azizoglu (cemil-azizoglu)
Changed in pay-service (Ubuntu):
status: New → Triaged
Changed in qtmir (Ubuntu RTM):
status: New → Triaged
Changed in pay-service (Ubuntu):
status: Triaged → New
Changed in qtmir (Ubuntu RTM):
assignee: nobody → Michał Sawicz (saviq)
Pat McGowan (pat-mcgowan) wrote :

part of bug #1355173, per description

Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww03-2015
status: New → Confirmed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtmir - 0.4.4+15.04.20150109-0ubuntu1

---------------
qtmir (0.4.4+15.04.20150109-0ubuntu1) vivid; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Nick Dedekind ]
  * Notify prompt sessions that sessions have been suspended/resumed.
    (LP: #1355173, #1384950)
 -- Ubuntu daily release <email address hidden> Fri, 09 Jan 2015 17:26:00 +0000

Changed in qtmir (Ubuntu):
status: In Progress → Fix Released
Michał Sawicz (saviq) wrote :

Having tested the linked branches, it seems there's some misunderstanding as to what should happen:

* should the trusted prompts for an app be SIGSTOP'ed with the app
* or should we leave it all to the trusted helper to decide

Michał Sawicz (saviq) on 2015-01-12
Changed in qtmir (Ubuntu RTM):
status: Triaged → In Progress
Michał Sawicz (saviq) on 2015-01-13
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Michał Sawicz (saviq) on 2015-01-13
Changed in qtmir (Ubuntu RTM):
milestone: none → 14.09-ota-2
Changed in mir (Ubuntu RTM):
milestone: none → 14.09-ota-2
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtmir - 0.4.4+15.04.20150112.3~rtm-0ubuntu1

---------------
qtmir (0.4.4+15.04.20150112.3~rtm-0ubuntu1) 14.09; urgency=medium

  [ Nick Dedekind ]
  * Compatibility for Mir 0.8.1
  * Notify prompt sessions that sessions have been suspended/resumed.
    (LP: #1355173, #1384950)

  [ Ricardo Salveti de Araujo ]
  * qteventfeeder: adding bt and wired headset multimedia keys (LP:
    #1398427)
 -- Ubuntu daily release <email address hidden> Mon, 12 Jan 2015 13:38:21 +0000

Changed in qtmir (Ubuntu RTM):
status: In Progress → Fix Released
Michał Sawicz (saviq) on 2015-01-14
Changed in mir (Ubuntu RTM):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: In Progress → Fix Released
Alberto Mardegan (mardy) wrote :

Removing ubuntu-system-settings-online-accounts as it seems we are already handling this properly.

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers