incorrect datatype for "OctaviaFlavorId"

[Pratik Pravin Bandarkar]

Description:

Heat templates will expect “OctaviaFlavorId” value to “number”. The default value is “65”. Where the actual flavor ID will be in the format of "number+string+special char".
For ex. “3a6b8284-2382-4e9a-9e9b-6ea31203b0b3” which cant be number/integer/float datatype and hence, while upgrading the openstack setup, the `openstack overcloud upgrade prepare` command will fail:
<snip>
2018-12-21 14:32:44.354 18144 ERROR heat.engine.resource raise exception.ResourceFailure(message, self, action=self.action)
2018-12-21 14:32:44.354 18144 ERROR heat.engine.resource ResourceFailure: resources.OctaviaWorkerPuppetBase: Parameter 'OctaviaFlavorId' is invalid: invalid literal for float(): 3a6b8284-2382-4e9a-9e9b-6ea31203b0b3
</snip>

To fix the issue, instead of using "Number" we can expect "String":
<snip>
  OctaviaFlavorId:
    default: 65
    description: Nova flavor ID to be used when creating the nova flavor for
                 amphora.
    #type: number #<==
    type: string #<==
</snip>

Steps to reproduce:
1. Deployed "Pike" release with Octavia
2. Created few Octavia load balancers
3. As Octavia loadbalancer was using custom flavor(3a6b8284-2382-4e9a-9e9b-6ea31203b0b3), while upgrading the setup(Pike --> Queens), I specified "OctaviaFlavorId"(3a6b8284-2382-4e9a-9e9b-6ea31203b0b3). But, `openstack overcloud upgrade prepare` command filed with the error mentioned in the description.
4. To fix the issue, I updated data type for "OctaviaFlavorId" from "number" to "String".

Environment:
- Pike
- Queens
- Rocky

Expected result: Installation/upgradation of OpenStack with alphanumeric OctaviaFlavorId should be successful.

Actual result: Upgradation of OpenStack with alphanumeric OctaviaFlavorId fails.

I think(not tested), even for the fresh installation if the user tries to specify OctaviaFlavorId in alphanumeric format, the installation will fail.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.