Support Application Indicators

[Jorge Castro]

This application should be investigated to be ported to use Application
Indicators for Lucid - https://edge.launchpad.net/indicator-application

 affects ubuntu/transmission

 assignee canonical-dx-team
 tag indicator-application

[Sense Egbert Hofstede (sense)]

I've decided to use this to improve my C and AutoTools skills. I'm almost at a point where I can start testing.

Autotools check are used to make it easy for people to disable the integration. This should make the patch easier to submit upstream.

[Sense Egbert Hofstede (sense)]

It should work now! The working version is in lp:~qense/ubuntu/lucid/transmission/fix-497882 but since the branch contained an older version and not the newer version that is in the repositories I'll need to do some tricks for getting a patch.

[Sense Egbert Hofstede (sense)]

Attaching a patch for Transmission 1.83. The changes to debian/patches/99_autoreconf.patch are not included.

[Sense Egbert Hofstede (sense)]

This time with nicer passing of the icon.
You will still see that the icon doesn't exist. This is because it's looking for 'transmission-tray-icon'. which is defined as the TRAY_ICON in transmission/gtk/actions.h

[Sense Egbert Hofstede (sense)]

This is fixed in the upstream trunk -- http://trac.transmissionbt.com/changeset/10133 -- and the bug was added to the 1.90 milestone. I don't think there is need to include the patch, we could just wait until the new version is released.

[Chris Coulson (chrisccoulson)]

Thanks for your work there. I'm going to backport the patch from trunk and upload it after dinner as we might not get a 1.90 release before feature freeze, so I'd rather get this in now

[Chris Coulson (chrisccoulson)]

After chatting with charles on #transmission, we're going to wait for the 1.90 release, which should happen before FF now:

<charles> one of the popular trackers currently has a ban on 1.8x because they don't like some of its behavior. Yesterday I sent them a test build from trunk to see if it's resolved
<charles> I'm pretty sure it's http://trac.transmissionbt.com/ticket/2854
<chrisccoulson> charles - thanks, i wasn't aware of that
<charles> so the Transmission developers were wondering, let's say yesterday's trunk build passes the sniff test and gets unbanned
<charles> at that point we would need to decide what to do for the next release
<charles> it might be less risky to just jump to 1.90 and put 1.8x in the past
<chrisccoulson> yeah, possibly. there are a lot of commits there
<charles> also we've discussed what we want to put on the table for 1.90. after the massive birthing pains of the 140-ticket 1.80, nobody voted for a long list of features in 1.90.
<charles> if we get word back from that tracker that the test app works, my vote would be to freeze the code base for 1.90
<charles> chrisccoulson: if 10.04's freeze is 1.5 weeks away, that makes it an even clearer choice IMO
<chrisccoulson> charles - yeah, that sounds good to me

[Sense Egbert Hofstede (sense)]

A patch go get the icon work correctly can be found at <http://trac.transmissionbt.com/attachment/ticket/2900/icon_fallback.patch> in bug <http://trac.transmissionbt.com/ticket/2900>.

[Launchpad Janitor (janitor)]

This bug was fixed in the package transmission - 1.90-0ubuntu1

---------------
transmission (1.90-0ubuntu1) lucid; urgency=low

  [ Krzysztof Klimonda ]
  * New upstream release (LP: #522726)
  * Fixes bugs:
    - Support Application Indicators (LP: #497882)
    - Better file preallocation with fallocate() (LP: #445592)
    - Speed limit of 0 is not honored (LP: #473652)
    - incorrectly sent information (LP: #521140)
  * Refreshed 99_autoreconf.patch
  * debian/control:
    - Build-Depend on libappindicator-dev

  [ Chris Coulson ]
  * Add ${misc:Depends} in debian/control to make Lintian happy
  * Update Standards-Version to 3.8.4. No other changes necessary
 -- Krzysztof Klimonda <email address hidden> Tue, 16 Feb 2010 17:50:22 +0100