Support Application Indicators
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Transmission |
Fix Released
|
Unknown
|
||
| transmission (Ubuntu) |
Wishlist
|
Unassigned |
Bug Description
This application should be investigated to be ported to use Application
Indicators for Lucid - https:/
affects ubuntu/transmission
assignee canonical-dx-team
tag indicator-
Related branches
- Benjamin Drung: Disapprove on 2010-05-09
- Ubuntu branches: Pending requested 2010-02-07
-
Diff: 12145 lines (+4121/-3351)1 file modifieddebian/patches/99_autoreconf.patch (+4121/-3351)
Changed in transmission (Ubuntu): | |
importance: | Undecided → Wishlist |
Changed in transmission (Ubuntu): | |
status: | New → Triaged |
Sense Egbert Hofstede (sense) wrote : | #1 |
Changed in transmission (Ubuntu): | |
assignee: | Canonical Desktop Experience Team (canonical-dx-team) → Sense Hofstede (qense) |
status: | Triaged → In Progress |
Sense Egbert Hofstede (sense) wrote : | #2 |
It should work now! The working version is in lp:~qense/ubuntu/lucid/transmission/fix-497882 but since the branch contained an older version and not the newer version that is in the repositories I'll need to do some tricks for getting a patch.
Changed in transmission (Ubuntu): | |
assignee: | Sense Hofstede (qense) → nobody |
status: | In Progress → Triaged |
Sense Egbert Hofstede (sense) wrote : | #3 |
Attaching a patch for Transmission 1.83. The changes to debian/
Sense Egbert Hofstede (sense) wrote : | #4 |
This time with nicer passing of the icon.
You will still see that the icon doesn't exist. This is because it's looking for 'transmission-
Changed in transmission: | |
status: | Unknown → New |
Sense Egbert Hofstede (sense) wrote : | #5 |
This is fixed in the upstream trunk -- http://
Chris Coulson (chrisccoulson) wrote : | #6 |
Thanks for your work there. I'm going to backport the patch from trunk and upload it after dinner as we might not get a 1.90 release before feature freeze, so I'd rather get this in now
Changed in transmission (Ubuntu): | |
assignee: | nobody → Chris Coulson (chrisccoulson) |
status: | Triaged → In Progress |
Chris Coulson (chrisccoulson) wrote : | #7 |
After chatting with charles on #transmission, we're going to wait for the 1.90 release, which should happen before FF now:
<charles> one of the popular trackers currently has a ban on 1.8x because they don't like some of its behavior. Yesterday I sent them a test build from trunk to see if it's resolved
<charles> I'm pretty sure it's http://
<chrisccoulson> charles - thanks, i wasn't aware of that
<charles> so the Transmission developers were wondering, let's say yesterday's trunk build passes the sniff test and gets unbanned
<charles> at that point we would need to decide what to do for the next release
<charles> it might be less risky to just jump to 1.90 and put 1.8x in the past
<chrisccoulson> yeah, possibly. there are a lot of commits there
<charles> also we've discussed what we want to put on the table for 1.90. after the massive birthing pains of the 140-ticket 1.80, nobody voted for a long list of features in 1.90.
<charles> if we get word back from that tracker that the test app works, my vote would be to freeze the code base for 1.90
<charles> chrisccoulson: if 10.04's freeze is 1.5 weeks away, that makes it an even clearer choice IMO
<chrisccoulson> charles - yeah, that sounds good to me
Changed in transmission (Ubuntu): | |
assignee: | Chris Coulson (chrisccoulson) → nobody |
status: | In Progress → Fix Committed |
Changed in transmission: | |
status: | New → Fix Released |
Changed in transmission: | |
status: | Fix Released → New |
tags: | added: patch |
Changed in transmission: | |
status: | New → Fix Released |
Sense Egbert Hofstede (sense) wrote : | #8 |
A patch go get the icon work correctly can be found at <http://
Launchpad Janitor (janitor) wrote : | #9 |
This bug was fixed in the package transmission - 1.90-0ubuntu1
---------------
transmission (1.90-0ubuntu1) lucid; urgency=low
[ Krzysztof Klimonda ]
* New upstream release (LP: #522726)
* Fixes bugs:
- Support Application Indicators (LP: #497882)
- Better file preallocation with fallocate() (LP: #445592)
- Speed limit of 0 is not honored (LP: #473652)
- incorrectly sent information (LP: #521140)
* Refreshed 99_autoreconf.patch
* debian/control:
- Build-Depend on libappindicator-dev
[ Chris Coulson ]
* Add ${misc:Depends} in debian/control to make Lintian happy
* Update Standards-Version to 3.8.4. No other changes necessary
-- Krzysztof Klimonda <email address hidden> Tue, 16 Feb 2010 17:50:22 +0100
Changed in transmission (Ubuntu): | |
status: | Fix Committed → Fix Released |
I've decided to use this to improve my C and AutoTools skills. I'm almost at a point where I can start testing.
Autotools check are used to make it easy for people to disable the integration. This should make the patch easier to submit upstream.