tp-smapi DKMS FTBFS wrt Linux 6.4

[Paolo Pisati]

[Impact]

...
/var/lib/dkms/tp_smapi/0.43/build/thinkpad_ec.c:94:42: error: macro "DEFINE_SEMAPHORE" requires 2 arguments, but only 1 given
   94 | static DEFINE_SEMAPHORE(thinkpad_ec_mutex);
      | ^
...

[Fix]

Apply the attached patch.

[How to test]

Install the patch package (and make sure it builds).

[Regression potential]

Low, the buildifx is an upstream cherrypick and it's conditionally compiled only if Linux >= 6.4.

[Marc Cheng (bdgraue)]

i am hit by this bug, when i try to add a newer kernel from mainline. are there any plans to port the fix back to Lobster?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Paolo Pisati (p-pisati)]

This bug was fixed in the package tp-smapi - 0.44-1

---------------
tp-smapi (0.44-1) unstable; urgency=medium

  * New upstream version 0.44
    + Support 6.4 kernel
      Closes: #1038207

 -- Evgeni Golov <email address hidden> Mon, 31 Jul 2023 20:09:41 +0200

tp-smapi (0.43-3) unstable; urgency=medium

  * Limit autopkgtest to amd64 and i386 as tp_smapi doesn't work on other
    arches.

 -- Evgeni Golov <email address hidden> Thu, 26 Jan 2023 21:42:38 +0100

tp-smapi (0.43-2) unstable; urgency=medium

  [ Evgeni Golov ]
  * Standards-Version: 4.6.2
  * fix d/watch to find a release
  * update source to point at https://github.com/linux-thinkpad/tp_smapi

  [ Andreas Beckmann ]
  * Switch to dh-sequence-dkms. (Closes: #1027884)
  * Declare Testsuite: autopkgtest-pkg-dkms.
  * Declare Rules-Requires-Root: no.
  * Update to copyright-format 1.0.

  [ Debian Janitor ]
  * Trim trailing whitespace.
  * Bump debhelper from deprecated 9 to 13.
  * Set debhelper-compat version in Build-Depends.
  * Replace spaces in short license names with dashes.
  * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse.

 -- Evgeni Golov <email address hidden> Tue, 24 Jan 2023 20:44:49 +0100

[Andreas Hasenack (ahasenack)]

Mantic and Noble have 0.44-1ubuntu1, which has this patch applied, and they also run kernel 6.5 at the moment, so they were affected.

Lunar is on kernel 6.2, so not affected, nor is jammy. This really only applies to users who are running a non-distro kernel in lunar or earlier.

Even though the patch looks safe and has #ifdefs for the specific affected kernel version, I'm not sure we should SRU this to the stable releases which, on the shipped kernel, are not affected. This would update every user of tp-smapi, including the ones not affected by this build problem.

Is there an expectation that jammy will get a 6.4 or higher kernel at some point, perhaps via hwe? Currently the hwe kernel for jammy is 6.2 if I'm not mistaken.

[Julian Andres Klode (juliank)]

hwe kernels have been rolling for a couple of releases now, so uh yes, of course it will get a higher kernel at some point.

SRUs for DKMS modules for those upcoming HWE kernels is standard practice.

[Andreas Hasenack (ahasenack)]

How do you propose this to be tested in jammy? The bug is "tp-smapi dkms does not build with kernel 6.4". Testing that it keeps building with the current jammy kernels does not show the bug is fixed.

[Andreas Hasenack (ahasenack)]

Here is a suggestion for the testing:

Enable the kernel team's ppa: sudo add-apt-repository ppa:canonical-kernel-team/ppa

Install, on jammy, linux-headers-generic-hwe-22.04-edge (and maybe even the actual kernel: linux-image-generic-hwe-22.04-edge)

And then install tp-smapi-dkms, verifying it builds. Then repeat with the normal jammy kernel, to confirm it still builds.

With an amended test case, and patch that also covers the interim releases, this can be sponsored for an SRU.

[Dave Jones (waveform)]

The concerns about a test case for SRU need addressing, but the suggested method of using the kernel team's PPA looks reasonable.

Unsubscribing ubuntu-sponsors until this is addressed; please re-subscribe when the test case is updated to include instructions that verify the patch under jammy with a 6.4 kernel (it wouldn't hurt to check that it definitely doesn't affect the current 6.2 HWE kernel either).