Ubuntu

Add support for keywords

Reported by Nekhelesh Ramananthan on 2012-04-08
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Totem
Fix Released
Medium
totem (Ubuntu)
High
Vibhav Pant
Precise
High
Unassigned
Quantal
High
Unassigned

Bug Description

Impact:
It makes totem hard to find in the dash

Test Case:
Open the unity dash, type "DVD" or "Film" or "Movie", any of those should find totem

Regression potential:
Totem will be listed as matching some new keywords, shouldn't create any issue

---

The totem desktop file needs to add support to the new keywords XDG specifications.

Changed in totem (Ubuntu):
status: New → Confirmed
assignee: nobody → Nekhelesh Ramananthan (nik90)
Changed in totem:
importance: Unknown → Medium
status: Unknown → New
Changed in totem (Ubuntu):
status: Confirmed → In Progress
Changed in totem:
status: New → Fix Released
Vibhav Pant (vibhavp) on 2012-04-13
Changed in totem (Ubuntu):
assignee: Nekhelesh Ramananthan (nik90) → Vibhav Pant (vibhavp)
Vibhav Pant (vibhavp) wrote :
Bryce Harrington (bryce) wrote :

Hi Nekhelesh,

First off, thanks for contributing to totem upstream!

Unfortunately we're past final freeze on precise. This looks like a fairly innocuous change but I don't think it's a severe enough problem to warrant an Stable Release Update, so am marking it wontfix.

If you disagree, please feel free to file an SRU request. Docs on how to do this are at https://wiki.ubuntu.com/StableReleaseUpdates

Changed in totem (Ubuntu):
status: In Progress → Won't Fix
Bryce Harrington (bryce) wrote :

I'll leave a task open for Q-series. I gather we'll probably get this fix automatically once Q syncs in the new package.

Nekhelesh Ramananthan (nik90) wrote :

Bryce, this has been fix released upstream. I agree that this is not a severe enough problem, hence it is better of to push to Q series. In fact I am guessing it will automatically come in from upstream if totem 3.4.1 is imported.

Sebastien Bacher (seb128) wrote :
Changed in totem (Ubuntu Quantal):
status: In Progress → Fix Committed
Sebastien Bacher (seb128) wrote :

In fact that seems worth backporting, it's a bit lame that typing "DVD" or "Film" in the dash doesn't find totem

Changed in totem (Ubuntu Precise):
assignee: Vibhav Pant (vibhavp) → Sebastien Bacher (seb128)
importance: Undecided → Low
status: Won't Fix → In Progress
assignee: Sebastien Bacher (seb128) → nobody
status: In Progress → Triaged
Sebastien Bacher (seb128) wrote :

If somebody wants to backport to patch please do it, I will have a look next week otherwise

tags: added: keywords
description: updated
Changed in totem (Ubuntu Precise):
status: Triaged → In Progress
Changed in totem (Ubuntu Precise):
milestone: none → ubuntu-12.04.1
Changed in totem (Ubuntu Precise):
importance: Low → High
Changed in totem (Ubuntu Quantal):
importance: Low → High
Chris Halse Rogers (raof) wrote :

This breaks string freeze, as the new keywords appear to be translatable.

That should be ok, though, as long as these keywords never appear in user-visible UI. Is that the case? These are *only* used to match in the dash, never displayed?

Nekhelesh Ramananthan (nik90) wrote :

Chris, these keywords are used *only* for the sole purpose of improving the matching in the dash. Currently, a new user can find totem in the dash by explicitly searching for totem, movie. However the keywords will help the user find totem using other generic terms such as Film, DVD etc etc.. They do not appear in any form in the user-visible UI.

Sebastien Bacher (seb128) wrote :

Does string freeze really apply to non visibile strings? Those are just keywords for dash searchability and no they are not displayed in any ui elemenet

Hello Nekhelesh, or anyone else affected,

Accepted totem into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/totem/3.0.1-0ubuntu21.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in totem (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in totem (Ubuntu Precise):
milestone: ubuntu-12.04.1 → ubuntu-12.04.2
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package totem - 3.4.3-0ubuntu2

---------------
totem (3.4.3-0ubuntu2) quantal; urgency=low

  * debian/patches/git_no_browser_slider_hack.patch,
  * debian/patches/git_no_slider_hack.patch:
    - git patch, drop hack which was breaking "click to jump" behaviour
      with gtk 3.5 (lp: #953757)
  * debian/patches/git_use_keywords.patch:
    - backport upstream patch to set keywords in the desktop entry,
      it makes easier to find totem in the unity dash or gnome-shell
      (lp: #976624)
 -- Sebastien Bacher <email address hidden> Fri, 27 Jul 2012 15:47:52 +0200

Changed in totem (Ubuntu Quantal):
status: Fix Committed → Fix Released
madbiologist (me-again) wrote :

I have tested totem 3.0.1-0ubuntu21.1 from precise-proposed and can confirm it fixes this bug. Typing "movie", "film" or "DVD" in the dash will all find totem now.

I have also tested playback of several MP3, MP4, FLV and WMV files and found no regressions.

tags: added: verification-done
removed: verification-needed

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package totem - 3.0.1-0ubuntu21.1

---------------
totem (3.0.1-0ubuntu21.1) precise-proposed; urgency=low

  * debian/patches/git_use_keywords.patch:
    - backport upstream patch to set keywords in the desktop entry,
      it makes easier to find totem in the unity dash or gnome-shell
      (lp: #976624)
 -- Sebastien Bacher <email address hidden> Fri, 27 Jul 2012 15:47:52 +0200

Changed in totem (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.