[SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
torbrowser-launcher (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Thomas Ward | ||
Focal |
Fix Released
|
Undecided
|
Thomas Ward | ||
Groovy |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Because of poor version string checking, the torbrowser-launcher package fails to recognize Tor Browser 10 and later as a valid version that is 'newer' than the previous versions. As such, the torbrowser-launcher package fails to update Tor Browser.
[Test Case]
(1) Install torbrowser-launcher
(2) Attempt to update
(3) Tor Browser version check will fail, and the tor browser version won't update.
[Regression Potential]
Thomas Ward reviewed the python changes relevant to this and they are superior to the previous version checking system. To that end, the fix for this issue should be non-breaking with very little risk of a regression.
[racb] Version comparison code (of Tor upstream) is being changed, so we might have missed some other area where a version comparison is required.
[Original Bug Description]
torbrowser-launcher does not work anymore since yesterday Tor Browser 10.0 release. There is already a simple fix available as a PR in the upstream GitHub repository: https:/
I will fix this in Focal as part of the #1896085 SRU, however it will also need to be fixed in Groovy.
Changed in torbrowser-launcher (Ubuntu Focal): | |
assignee: | nobody → Thomas Ward (teward) |
Changed in torbrowser-launcher (Ubuntu Groovy): | |
assignee: | nobody → Thomas Ward (teward) |
Changed in torbrowser-launcher (Ubuntu Focal): | |
status: | New → In Progress |
Changed in torbrowser-launcher (Ubuntu Groovy): | |
status: | New → In Progress |
Changed in torbrowser-launcher (Ubuntu Groovy): | |
status: | In Progress → Fix Released |
assignee: | Thomas Ward (teward) → nobody |
description: | updated |
summary: |
Version checking error in torbrowser-launcher since Tor Browser 10.0 was - released + [SRU] released |
summary: |
- Version checking error in torbrowser-launcher since Tor Browser 10.0 was - [SRU] released + [SRU] Version checking error in torbrowser-launcher since Tor Browser + 10.0 was released |
description: | updated |
tags: | removed: verification-needed |
I have following error: /github. com/micahflee/ torbrowser- launcher /aus1.torprojec t.org/torbrowse r/update_ 3/release/ Linux_x86_ 64-gcc3/ x/en-US
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.2
https:/
Your version of Tor Browser is out-of-date. Downloading the newest version.
Downloading https:/
Is it related with this topic? Or should i create new topic?