Tomboy appindicator menu shows templates as notes (bug in Ubuntu patch)

Bug #664963 reported by Thomas N on 2010-10-22
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tomboy (Ubuntu)
Low
Rodrigo Moya

Bug Description

Binary package hint: tomboy

Hello

Maybe after I installed and synced with Tomdroid (https://launchpad.net/tomdroid) I see my templates as notes in Tomboy.

On Tomboy Web and in Tomdroid these notes aren't visible, only in Tomboy.

I cannot delete them.

So right now I can see all my regular notes + <Notebookname> Notebook Template (old) + <Notebookname2> Notebook Template.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: tomboy 1.4.0-0ubuntu2
ProcVersionSignature: Ubuntu 2.6.35-22.35-generic 2.6.35.4
Uname: Linux 2.6.35-22-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Fri Oct 22 08:57:46 2010
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release i386 (20101007)
ProcEnviron:
 PATH=(custom, user)
 LANG=en_DK.utf8
 SHELL=/bin/bash
SourcePackage: tomboy

Related branches

A user came into IRC with this problem today. It seems to be caused by the appindicator patch applied by Ubuntu, but I can't be totally sure.

If you quit Tomboy, and add it to your panel as an applet instead of starting it in the way you normally start it, does the menu still have the same problem? I believe the problem will go away at this point.

If you then remove Tomboy from your panel, and start it the way you normally start it, does the bug reappar? If so, this is definitely a bug with the appindicator patch and needs to be fixed by the Ubuntu guys.

If you still have the problem even when running Tomboy as an applet, we'll need to take a look at your .note files to figure out what's going on.

Yeah, this is clearly a bug in the patch:

++ var menuItems = manager.Notes
++ .Where (n => !n.IsSpecial)
++ .OrderByDescending (n => n.ChangeDate)
++ .Take (10)
++ .Select (n => new NoteMenuItem (n, n.IsPinned))
++ .ToArray ();

There is no check at all for whether the note is a template. You guys need to add something like:

Tag template_tag = TagManager.GetOrCreateSystemTag (TagManager.TemplateNoteSystemTag);

and change the Where clause to:

++ .Where (n => !n.IsSpecial && !n.ContainsTag(template_tag))

I fixed this by doing this:

Adding some random text to these two notes

egewg

I shutdown Tomboy.

Then going to ~/.local/share/tomboy in a terminal.

grep egewg *

Then I got two filenames. I moved these two into the Backups directory.

Then re-started Tomboy and the notes were gone.

@ThomasNovin: that is not a real fix...template notes can get regenerated at any time.

summary: - Tomboy shows templates as notes
+ Tomboy appindicator menu shows templates as notes (bug in Ubuntu patch)
Robert Roth (evfool) on 2011-03-10
Changed in tomboy (Ubuntu):
status: New → Confirmed
Greg A (etulfetulf) wrote :
tags: added: patch
Sebastien Bacher (seb128) wrote :

Thank you for your work there, that should probably be sent upstream if that has not been done yet, Rodrigo what do you think about the patch there?

Changed in tomboy (Ubuntu):
assignee: nobody → Rodrigo Moya (rodrigo-moya)
importance: Undecided → Low
Sebastien Bacher (seb128) wrote :

ignore the comment about upstream I didn't read all comments before, that seems an issue with the indicator rather

Rodrigo Moya (rodrigo-moya) wrote :

It looks good to me. If Sandy agrees the fix is ok, let's push it

Changed in tomboy (Ubuntu):
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tomboy - 1.6.0-0ubuntu2

---------------
tomboy (1.6.0-0ubuntu2) natty; urgency=low

  * Don't show templates in the indicator (LP: #664963)
 -- Greg Auger <email address hidden> Sun, 10 Apr 2011 09:53:30 +0100

Changed in tomboy (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers