[FFe] Tomahawk 0.8.4 or newer [needs upgrade]

[Sandra Karuving]

in Ubuntu (and debian) ther's only Tomahawk 0.7. on http://www.tomahawk-player.org/ || official ppa -> https://launchpad.net/~tomahawk/+archive/ubuntu/ppa there is 0.8.4 right now.
because of many changes, we need this newer version in our repositories too.

so please upgrade if possible

[Hans Joachim Desserud (hjd)]

Thanks for taking your time to report this issue and help making Ubuntu better.

Since this concerns an upgrade request, I've added the 'upgrade-software-version' tag.
Note that the tomahawk package in Debian has the same name, but is actually something completely different. It is mentioned in the Ubuntu sync blacklist [1], and I also found a bug report in Debian [2] which might refer to the same issue.

[1] http://people.canonical.com/~ubuntu-archive/sync-blacklist.txt
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770906

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Stefan Ahlers (justin-time)]

I'm one of the maintainers of the official tomahawk PPA.

I have created a PPA with a tomahawk-player build for xenial [1], which uses the package name "tomahawk-player" instead of
"tomahawk" to allow sync the "tomahawk" package of the debian sources.

I also started to bring the "tomahawk-player" to debian directly, but it will not be ready until DebianImportFreeze. And so it would be nice if someone could help me to improve the quality of my package and bring it to ubuntu xenial directly.

[1] https://launchpad.net/~justin-time/+archive/ubuntu/tomahawk/+packages

[Daniel Holbach (dholbach)]

Can you maybe explain why a new source package is required?

[Stefan Ahlers (justin-time)]

Tomahawk 0.8.4 is the latest version of the tomahawk player. There are huge changes between 0.7.x and 0.8.x. I've attached the upstream changelog.

[Daniel Holbach (dholbach)]

But having two separate source packages will mean that

 - two sets of packages have to be maintained
 - code in the archive is being duplicated
 - users will be confused
 - bugs will end up in two different places

[Stefan Ahlers (justin-time)]

Ah ok, this source package (tomahawk-player) is a replacement for the old tomahawk source package. And so it will be possible to sync the tomahawk package from the debian source, which is not the same.

The debian source package contains the binary packages python-tomahawk and python3-tomahawk. The new tomahawk-player source package contains the binary packages:

 libtomahawk - Core libraries for tomahawk
 libtomahawk-dev - Core libraries for tomahawk – development files
 tomahawk - Multi source music player
 tomahawk-dbg

[Daniel Holbach (dholbach)]

Why would it be necessary to have two source packages? Why would we not just update the current one to 0.8.4? Will the old tomahawk including the python packages still be maintained somewhere?

[Stefan Ahlers (justin-time)]

The debian tomahawk package (https://tracker.debian.org/pkg/tomahawk) is activly maintained by Kouhei Maeda and based on this source code: https://github.com/oinume/tomahawk. It is "a simple ssh wrapper to execute commands into many hosts".

This program is not related to the ubuntu tomahawk package (https://launchpad.net/tomahawk), which based on https://github.com/tomahawk-player/tomahawk, a "the multi-source music player". There is a name mismatched between the debian tomahawk package and the ubuntu tomahawk package.

See this information in the Debian Bugtracker: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649287#27 or the first comment on this bug report.

And so it is necassary to have two different source packages. I ask the current maintainer of the ubuntu tomahawk package and he said I should open a sponsoring request to update this package.

[Daniel Holbach (dholbach)]

Ok, so you're now changing the Ubuntu-only tomahawk package to distinguish itself from the tomahawk package (different upstream) in Debian, OK.

[Daniel Holbach (dholbach)]

Should data/js/cryptojs/ be replaced with libjs-cryptojs?

[Daniel Holbach (dholbach)]

Why are the debian/repack bits dropped in the new upload?

[Daniel Holbach (dholbach)]

lintian complains about a number of things in debian/copyright.

[Daniel Holbach (dholbach)]

It'd also be good to explain why you needed to repack the tarball and in which way.

[Daniel Holbach (dholbach)]

A few unrelated changes: http://paste.ubuntu.com/15105969/ (readd changelog entry, update timestamp, run update-maintainer, run wrap-and-sort).

[Stefan Ahlers (justin-time)]

> Ok, so you're now changing the Ubuntu-only tomahawk package to distinguish itself from the tomahawk package (different upstream) in Debian, OK.

Exactly!

> Should data/js/cryptojs/ be replaced with libjs-cryptojs?

This would be better, but I do not know how to patch the cmake files to use the external one.

> Why are the debian/repack bits dropped in the new upload?

A debian developer said to me that it is better to drop the debian/repack files and include them into debian/copyright as "Files-Excluded".

> It'd also be good to explain why you needed to repack the tarball and in which way.

The files admin/win and admin/mac thirdparty/SPMediaKeyTap are unnecessary for the ubuntu build and they create lintian warnings.

> A few unrelated changes: http://paste.ubuntu.com/15105969/ (readd changelog entry, update timestamp, run update-maintainer, run wrap-and-sort).

Should be done.

[Stefan Ahlers (justin-time)]

> lintian complains about a number of things in debian/copyright.

Is fixed.

[Stefan Ahlers (justin-time)]

> Should data/js/cryptojs/ be replaced with libjs-cryptojs?

Now, there exists a patch to use the external libjs-cryptojs package.

[Stefan Ahlers (justin-time)]

Dear ubuntu-release team,

this is a FeatureFreeze Exceptions request for the tomahawk-player package.

Many of the music streaming plugins of tomahawk 0.7 do not work any longer. Tomahawk 0.7.x is deprecated and there are no updates any longer. And so it would be nice if you would accept my request and update the tomahawk package to 0.8.4. I request also a renaming from "tomahawk" to "tomahawk-player" to distinguish itself from the tomahawk package (different upstream) in Debian.

Kind regards,
Stefan Ahlers

[Iain Lane (laney)]

FFe approved, please work with a sponsor (dholbach?) to get it uploaded.

[Stefan Ahlers (justin-time)]

A PPA with testbuilds for amd64, i386, arm64, armhf and ppc64el builds of the tomahawk-player package can be found here:

https://launchpad.net/~justin-time/+archive/ubuntu/tomahawk-player/+packages

[Marc Deslauriers (mdeslaur)]

Thanks for the package in the PPA. I've verified that it addresses the concerns raised by Daniel Holbach.

I've uploaded the package to xenial with the correct versioning change. It is awaiting processing by an archive admin.

Once it is accepted into Xenial, we can then sync Debian's unrelated tomahawk package into Ubuntu and resolve the package name collision.

Thanks!

[Stefan Ahlers (justin-time)]

Thank you for reviewing and uploading!