Activity log for bug #1890406

Date Who What changed Old value New value Message
2020-08-05 08:40:08 LTD Admin bug added bug
2020-08-06 12:58:39 Kai Kasurinen bug added subscriber Kai Kasurinen
2020-08-20 12:33:14 Paride Legovini bug added subscriber Ubuntu Server
2020-08-20 12:45:05 Paride Legovini nominated for series Ubuntu Groovy
2020-08-20 12:45:05 Paride Legovini bug task added tmux (Ubuntu Groovy)
2020-08-20 12:45:05 Paride Legovini nominated for series Ubuntu Focal
2020-08-20 12:45:05 Paride Legovini bug task added tmux (Ubuntu Focal)
2020-08-20 12:45:15 Paride Legovini bug task deleted tmux (Ubuntu Groovy)
2020-08-20 12:45:22 Paride Legovini tmux (Ubuntu): status New Fix Released
2020-08-20 12:45:25 Paride Legovini tmux (Ubuntu Focal): status New Triaged
2020-08-20 12:45:30 Paride Legovini tmux (Ubuntu Focal): importance Undecided Low
2021-04-13 10:41:46 Philipp Wendler bug added subscriber Philipp Wendler
2021-04-14 14:52:34 Sergio Durigan Junior tmux (Ubuntu Focal): importance Low Medium
2021-04-14 14:52:46 Sergio Durigan Junior tags bitesize server-next
2021-04-14 20:38:37 Sergio Durigan Junior bug added subscriber Sergio Durigan Junior
2021-04-20 17:21:09 Launchpad Janitor merge proposal linked https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/tmux/+git/tmux/+merge/401482
2021-04-22 15:47:14 Athos Ribeiro description Hallo! I have recently - I am pretty sure it is since the 20.04 upgrade (coming from 18.04) - experienced the problem that (detached) tmux sessions don't show up anymore in the output of commands such as `who -u` or `users`. Since I have a cron job for shutting down hosts where no users are logged in, I am constantly kicking out people now who have running jobs in detached tmux sessions. We would be very happy if this could be fixed. Thanks! [original message] Hallo! I have recently - I am pretty sure it is since the 20.04 upgrade (coming from 18.04) - experienced the problem that (detached) tmux sessions don't show up anymore in the output of commands such as `who -u` or `users`. Since I have a cron job for shutting down hosts where no users are logged in, I am constantly kicking out people now who have running jobs in detached tmux sessions. We would be very happy if this could be fixed. Thanks! [Impact] This is a regression that gets tmux not to record logins through utmp for its sessions (https://github.com/tmux/tmux/issues/2022). The bug was fixed upstream in https://github.com/tmux/tmux/commit/54efe337993b5571728a09b247c7f39d493659a8 by reintroducing the code that calls utempter to register the tmux session in utmp. This SRU is especially important because it affects unattended-upgrades users. unattended-upgrades uses /usr/bin/users to determine logged-in users, which queries utmp for that purpose. If running tmux sessions are not registered, and unattended-upgrades is configured not to reboot when there are users logged in, then it will misbehave and forcefully kill the running (not recorded) tmux session. The MP provided solves the issue by introducing the specific upstream fix into Focal's tmux. [Test Plan] * Reproducing: * Install tmux-3.0a-2ubuntu0.2 in Focal. * Start a tmux session (by running tmux) and detach from the session ("ctrl+b", then press "d"). * Run "who". You should verify that no entries for the running tmux session were recorded. * Run "tmux attach" and exit the session. * Verifying fix: * Install tmux-3.0a-2ubuntu0.3 (from MP) in Focal. * Start a tmux session (by running tmux) and detach from the session ("ctrl+b", then press "d"). * Run "who". You should verify that there is an entry for the running tmux session recorded. * Run "tmux attach" and exit the session. [Where problems could occur] This is a cherry-pick commit from upstream. 113 other code changes (that are not present in this MP) were applied upstream before the patch being proposed was introduced, meaning the code path may deviate from upstream's codepath during execution leading to unexpected behaviour, which could result in tmux terminating abruptly (e.g., segmetation fault) for possible not tested scenarios when starting a tmux session. In special, there were a small change in an upstream struct (window_pane) is being used in the code introduced by this patch (additional data was added). However, the change does not seem to affect the cherry-picked change AFAICT.
2021-04-22 16:21:59 Athos Ribeiro tmux (Ubuntu Focal): assignee Athos Ribeiro (athos-ribeiro)
2021-04-22 17:00:13 Athos Ribeiro tmux (Ubuntu Focal): status Triaged In Progress
2021-04-22 17:01:44 Athos Ribeiro bug added subscriber Athos Ribeiro
2021-04-22 20:20:21 Athos Ribeiro description [original message] Hallo! I have recently - I am pretty sure it is since the 20.04 upgrade (coming from 18.04) - experienced the problem that (detached) tmux sessions don't show up anymore in the output of commands such as `who -u` or `users`. Since I have a cron job for shutting down hosts where no users are logged in, I am constantly kicking out people now who have running jobs in detached tmux sessions. We would be very happy if this could be fixed. Thanks! [Impact] This is a regression that gets tmux not to record logins through utmp for its sessions (https://github.com/tmux/tmux/issues/2022). The bug was fixed upstream in https://github.com/tmux/tmux/commit/54efe337993b5571728a09b247c7f39d493659a8 by reintroducing the code that calls utempter to register the tmux session in utmp. This SRU is especially important because it affects unattended-upgrades users. unattended-upgrades uses /usr/bin/users to determine logged-in users, which queries utmp for that purpose. If running tmux sessions are not registered, and unattended-upgrades is configured not to reboot when there are users logged in, then it will misbehave and forcefully kill the running (not recorded) tmux session. The MP provided solves the issue by introducing the specific upstream fix into Focal's tmux. [Test Plan] * Reproducing: * Install tmux-3.0a-2ubuntu0.2 in Focal. * Start a tmux session (by running tmux) and detach from the session ("ctrl+b", then press "d"). * Run "who". You should verify that no entries for the running tmux session were recorded. * Run "tmux attach" and exit the session. * Verifying fix: * Install tmux-3.0a-2ubuntu0.3 (from MP) in Focal. * Start a tmux session (by running tmux) and detach from the session ("ctrl+b", then press "d"). * Run "who". You should verify that there is an entry for the running tmux session recorded. * Run "tmux attach" and exit the session. [Where problems could occur] This is a cherry-pick commit from upstream. 113 other code changes (that are not present in this MP) were applied upstream before the patch being proposed was introduced, meaning the code path may deviate from upstream's codepath during execution leading to unexpected behaviour, which could result in tmux terminating abruptly (e.g., segmetation fault) for possible not tested scenarios when starting a tmux session. In special, there were a small change in an upstream struct (window_pane) is being used in the code introduced by this patch (additional data was added). However, the change does not seem to affect the cherry-picked change AFAICT. [Impact] This is a regression that gets tmux not to record logins through utmp for its sessions (https://github.com/tmux/tmux/issues/2022). The bug was fixed upstream in https://github.com/tmux/tmux/commit/54efe337993b5571728a09b247c7f39d493659a8 by reintroducing the code that calls utempter to register the tmux session in utmp. This SRU is especially important because it affects unattended-upgrades users. unattended-upgrades uses /usr/bin/users to determine logged-in users, which queries utmp for that purpose. If running tmux sessions are not registered, and unattended-upgrades is configured not to reboot when there are users logged in, then it will misbehave and forcefully kill the running (not recorded) tmux session. The MP provided solves the issue by introducing the specific upstream fix into Focal's tmux. [Test Plan] * Reproducing:  * Install tmux-3.0a-2ubuntu0.2 in Focal.  * Start a tmux session (by running tmux) and detach from the session ("ctrl+b", then press "d").  * Run "who". You should verify that no entries for the running tmux session were recorded.  * Run "tmux attach" and exit the session. * Verifying fix:  * Install tmux-3.0a-2ubuntu0.3 (from MP) in Focal.  * Start a tmux session (by running tmux) and detach from the session ("ctrl+b", then press "d").  * Run "who". You should verify that there is an entry for the running tmux session recorded.  * Run "tmux attach" and exit the session. [Where problems could occur] This is a cherry-pick commit from upstream. 113 other code changes (that are not present in this MP) were applied upstream before the patch being proposed was introduced, meaning the code path may deviate from upstream's codepath during execution leading to unexpected behaviour, which could result in tmux terminating abruptly (e.g., segmetation fault) for possible not tested scenarios when starting a tmux session. In special, there were a small change in an upstream struct (window_pane) is being used in the code introduced by this patch (additional data was added). However, the change does not seem to affect the cherry-picked change AFAICT. [original message] Hallo! I have recently - I am pretty sure it is since the 20.04 upgrade (coming from 18.04) - experienced the problem that (detached) tmux sessions don't show up anymore in the output of commands such as `who -u` or `users`. Since I have a cron job for shutting down hosts where no users are logged in, I am constantly kicking out people now who have running jobs in detached tmux sessions. We would be very happy if this could be fixed. Thanks!
2021-04-22 21:26:58 Athos Ribeiro bug added subscriber Ubuntu Stable Release Updates Team
2021-04-22 22:29:53 Brian Murray tmux (Ubuntu Focal): status In Progress Fix Committed
2021-04-22 22:29:56 Brian Murray bug added subscriber SRU Verification
2021-04-22 22:30:02 Brian Murray tags bitesize server-next bitesize server-next verification-needed verification-needed-focal
2021-04-23 12:21:19 Athos Ribeiro tags bitesize server-next verification-needed verification-needed-focal bitesize server-next verification-done verification-done-focal
2021-05-06 08:55:53 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2021-05-06 08:55:52 Launchpad Janitor tmux (Ubuntu Focal): status Fix Committed Fix Released