Activity log for bug #1875109

Date Who What changed Old value New value Message
2020-04-25 23:47:18 Anthony Sottile bug added bug
2020-04-28 01:58:17 Rafael David Tinoco nominated for series Ubuntu Groovy
2020-04-28 01:58:17 Rafael David Tinoco bug task added tmux (Ubuntu Groovy)
2020-04-28 01:58:17 Rafael David Tinoco nominated for series Ubuntu Focal
2020-04-28 01:58:17 Rafael David Tinoco bug task added tmux (Ubuntu Focal)
2020-04-28 01:58:28 Rafael David Tinoco bug added subscriber Ubuntu Server
2020-04-28 01:58:32 Rafael David Tinoco tmux (Ubuntu Focal): status New Triaged
2020-04-28 01:58:35 Rafael David Tinoco tmux (Ubuntu Groovy): status New Triaged
2020-05-19 13:46:00 Launchpad Janitor merge proposal linked https://code.launchpad.net/~sergiodj/ubuntu/+source/tmux/+git/tmux/+merge/384181
2020-05-19 13:46:17 Sergio Durigan Junior tmux (Ubuntu Focal): assignee Sergio Durigan Junior (sergiodj)
2020-05-19 13:54:11 Sergio Durigan Junior description This is the same as this upstream issue: https://github.com/tmux/tmux/issues/1963 (fixed 2019-11-02) this is present in 3.0a-2 for ubuntu focal there is a patch listed here -- alternatively, it looks like this is fixed in 3.1: https://github.com/tmux/tmux/issues/1963#issuecomment-548929945 [Impact] This is a fix to a problem that happens when the user splits up tmux windows (using 'split-window') while running tmux in the background (i.e., not attached to a pty). In this scenario, tmux should automatically resize the panes and the applications running inside them, but it doesn't. The cherry-picked fix, which has been pushed upstream already, can be found at: https://github.com/tmux/tmux/commit/bad95db8785f4ee6b6e17750500c024642e83134 [Test Case] To reproduce the bug, one can use a slightly modified version of the upstream bug reporter's script. $ lxc launch ubuntu-daily:focal tmux-bug1875109 $ lxc shell tmux-bug1875109 # apt update && apt install tmux # cat > reproducer.sh << __EOF__ #!/usr/bin/env bash set -euo pipefail TMUX="tmux" tmux_cmd() { "${TMUX}" -u -L demo-session "$@"; } msg() { echo -e "\033[1m+ $*\033[m"; } msg tmux version "${TMUX}" -V msg starting tmux... tmux_cmd new-session -d -x 80 -y 8 nano --ignorercfiles sleep .5 tmux_cmd send-keys -t0 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa tmux_cmd send-keys -t0 Enter sleep .5 msg 'this is nano at full width:' tmux_cmd capture-pane -pt0 tmux_cmd split-window -ht0 -l 50 sleep infinity sleep .5 msg 'this is nano at smaller width (should have "Modified" + $ at eol):' tmux_cmd capture-pane -pt0 msg 'trying to grep Modified' if ! tmux_cmd capture-pane -pt0 | grep Modified; then msg "@@@@@@@@ BUG DETECTED @@@@@@@@" else msg "@@@@@@@@ NO BUG FOUND @@@@@@@@" fi msg cleaning up... tmux_cmd kill-pane -t1 # quit nano to exit tmux tmux_cmd send-keys -t0 '^X' tmux_cmd send-keys -t0 'n' sleep .5 tmux_cmd kill-session >& /dev/null || true __EOF__ # chmod +x reproducer.sh # ./reproducer.sh Look for "@@@@@@@@ BUG DETECTED @@@@@@@@" in the output. [Regression Potential] * The fix is extremely simple and self-contained: it teaches tmux to detect whether a window in an unattached session, and resizes it in this case. * The only "regression" potential I can think of is if tmux's internal state gets confused and mistakenly assumes that a window that is active in an attached session is actually in an unattached session, thus failing to properly resize the window. This would not be considered a regression, though, since it'd be a latent bug that manifested after this change. [Original Description] This is the same as this upstream issue: https://github.com/tmux/tmux/issues/1963 (fixed 2019-11-02) this is present in 3.0a-2 for ubuntu focal there is a patch listed here -- alternatively, it looks like this is fixed in 3.1: https://github.com/tmux/tmux/issues/1963#issuecomment-548929945
2020-05-19 13:58:06 Sergio Durigan Junior tmux (Ubuntu Groovy): status Triaged Fix Released
2020-05-20 12:09:31 Sergio Durigan Junior description [Impact] This is a fix to a problem that happens when the user splits up tmux windows (using 'split-window') while running tmux in the background (i.e., not attached to a pty). In this scenario, tmux should automatically resize the panes and the applications running inside them, but it doesn't. The cherry-picked fix, which has been pushed upstream already, can be found at: https://github.com/tmux/tmux/commit/bad95db8785f4ee6b6e17750500c024642e83134 [Test Case] To reproduce the bug, one can use a slightly modified version of the upstream bug reporter's script. $ lxc launch ubuntu-daily:focal tmux-bug1875109 $ lxc shell tmux-bug1875109 # apt update && apt install tmux # cat > reproducer.sh << __EOF__ #!/usr/bin/env bash set -euo pipefail TMUX="tmux" tmux_cmd() { "${TMUX}" -u -L demo-session "$@"; } msg() { echo -e "\033[1m+ $*\033[m"; } msg tmux version "${TMUX}" -V msg starting tmux... tmux_cmd new-session -d -x 80 -y 8 nano --ignorercfiles sleep .5 tmux_cmd send-keys -t0 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa tmux_cmd send-keys -t0 Enter sleep .5 msg 'this is nano at full width:' tmux_cmd capture-pane -pt0 tmux_cmd split-window -ht0 -l 50 sleep infinity sleep .5 msg 'this is nano at smaller width (should have "Modified" + $ at eol):' tmux_cmd capture-pane -pt0 msg 'trying to grep Modified' if ! tmux_cmd capture-pane -pt0 | grep Modified; then msg "@@@@@@@@ BUG DETECTED @@@@@@@@" else msg "@@@@@@@@ NO BUG FOUND @@@@@@@@" fi msg cleaning up... tmux_cmd kill-pane -t1 # quit nano to exit tmux tmux_cmd send-keys -t0 '^X' tmux_cmd send-keys -t0 'n' sleep .5 tmux_cmd kill-session >& /dev/null || true __EOF__ # chmod +x reproducer.sh # ./reproducer.sh Look for "@@@@@@@@ BUG DETECTED @@@@@@@@" in the output. [Regression Potential] * The fix is extremely simple and self-contained: it teaches tmux to detect whether a window in an unattached session, and resizes it in this case. * The only "regression" potential I can think of is if tmux's internal state gets confused and mistakenly assumes that a window that is active in an attached session is actually in an unattached session, thus failing to properly resize the window. This would not be considered a regression, though, since it'd be a latent bug that manifested after this change. [Original Description] This is the same as this upstream issue: https://github.com/tmux/tmux/issues/1963 (fixed 2019-11-02) this is present in 3.0a-2 for ubuntu focal there is a patch listed here -- alternatively, it looks like this is fixed in 3.1: https://github.com/tmux/tmux/issues/1963#issuecomment-548929945 [Impact] This is a fix to a problem that happens when the user splits up tmux windows (using 'split-window') while running tmux in the background (i.e., not attached to a pty). In this scenario, tmux should automatically resize the panes and the applications running inside them, but it doesn't. The cherry-picked fix, which has been pushed upstream already, can be found at: https://github.com/tmux/tmux/commit/bad95db8785f4ee6b6e17750500c024642e83134 [Test Case] To reproduce the bug, one can use a slightly modified version of the upstream bug reporter's script. $ lxc launch ubuntu-daily:focal tmux-bug1875109 $ lxc shell tmux-bug1875109 # apt update && apt install tmux # cat > reproducer.sh << __EOF__ #!/usr/bin/env bash set -euo pipefail TMUX="tmux" tmux_cmd() { "${TMUX}" -u -L demo-session "$@"; } msg() { echo -e "\033[1m+ $*\033[m"; } msg tmux version "${TMUX}" -V msg starting tmux... tmux_cmd new-session -d -x 80 -y 8 nano --ignorercfiles sleep .5 tmux_cmd send-keys -t0 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa tmux_cmd send-keys -t0 Enter sleep .5 msg 'this is nano at full width:' tmux_cmd capture-pane -pt0 tmux_cmd split-window -ht0 -l 50 sleep infinity sleep .5 msg 'this is nano at smaller width (should have "Modified" + $ at eol):' tmux_cmd capture-pane -pt0 msg 'trying to grep Modified' if ! tmux_cmd capture-pane -pt0 | grep Modified; then   msg "@@@@@@@@ BUG DETECTED @@@@@@@@" else   msg "@@@@@@@@ NO BUG FOUND @@@@@@@@" fi msg cleaning up... tmux_cmd kill-pane -t1 # quit nano to exit tmux tmux_cmd send-keys -t0 '^X' tmux_cmd send-keys -t0 'n' sleep .5 tmux_cmd kill-session >& /dev/null || true __EOF__ # chmod +x reproducer.sh # ./reproducer.sh Look for "@@@@@@@@ BUG DETECTED @@@@@@@@" in the output. [Regression Potential] * The fix is extremely simple and self-contained: it teaches tmux to detect whether a window is in an unattached session, and resizes it in this case. * The changes are localized to the client's screen drawing behaviour, so irregularities in drawing behaviour would be what to watch for with regressions. [Original Description] This is the same as this upstream issue: https://github.com/tmux/tmux/issues/1963 (fixed 2019-11-02) this is present in 3.0a-2 for ubuntu focal there is a patch listed here -- alternatively, it looks like this is fixed in 3.1: https://github.com/tmux/tmux/issues/1963#issuecomment-548929945
2020-05-20 16:58:21 Robie Basak tmux (Ubuntu Focal): status Triaged Fix Committed
2020-05-20 16:58:22 Robie Basak bug added subscriber Ubuntu Stable Release Updates Team
2020-05-20 16:58:24 Robie Basak bug added subscriber SRU Verification
2020-05-20 16:58:27 Robie Basak tags verification-needed verification-needed-focal
2020-05-20 18:50:18 Anthony Sottile tags verification-needed verification-needed-focal verification-done-focal verification-needed
2020-05-28 09:01:57 Łukasz Zemczak tags verification-done-focal verification-needed verification-needed verification-needed-focal
2020-08-22 20:40:46 Anthony Sottile tags verification-needed verification-needed-focal verification-done verification-done-focal
2020-08-25 17:22:43 Launchpad Janitor tmux (Ubuntu Focal): status Fix Committed Fix Released
2020-08-25 17:22:47 Brian Murray removed subscriber Ubuntu Stable Release Updates Team