tlf crashes on hitting ENTER
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tlf (Ubuntu) |
Fix Released
|
Undecided
|
John Nogatch |
Bug Description
Binary package hint: tlf
$ lsb_release -rd
Description: Ubuntu 9.10
Release: 9.10
$ apt-cache policy tlf
tlf:
Installed: 0.9.32.3-4
Candidate: 0.9.32.3-4
Version table:
*** 0.9.32.3-4 0
500 http://
100 /var/lib/
What happened
=============
1. Execute:
$ tlf
2. Tlf starts and everything looks normal. I get the "login:". From then on, no matter what I try to do, as soon as I hit the [ENTER] key, I get a crash. Here is what I get on the terminal:
*** buffer overflow detected ***: tlf terminated
======= Backtrace: =========
/lib/libc.
/lib/libc.
/lib/libc.
tlf[0x40e6c3]
tlf[0x42f7a6]
tlf[0x431b9e]
tlf[0x41a7a5]
/lib/libc.
tlf[0x403819]
======= Memory map: ========
00400000-0043e000 r-xp 00000000 fc:00 40235 /usr/bin/tlf
0063d000-0063e000 r--p 0003d000 fc:00 40235 /usr/bin/tlf
0063e000-00641000 rw-p 0003e000 fc:00 40235 /usr/bin/tlf
00641000-009d1000 rw-p 00000000 00:00 0
0104e000-01090000 rw-p 00000000 00:00 0 [heap]
7eff20e34000-
7eff20e4a000-
7eff21049000-
7eff2104a000-
7eff2104b000-
7eff2104d000-
7eff2124d000-
7eff2124e000-
7eff2124f000-
7eff213b5000-
7eff215b4000-
7eff215b8000-
7eff215b9000-
7eff215be000-
7eff21640000-
7eff21840000-
7eff21841000-
7eff21842000-
7eff21859000-
7eff21a58000-
7eff21a59000-
7eff21a5a000-
7eff21a5e000-
7eff21a9c000-
7eff21c9c000-
7eff21ca0000-
7eff21ca1000-
7eff21cbd000-
7eff21ebd000-
7eff21ebf000-
7eff21ec0000-
7eff220b4000-
7eff220db000-
7eff220de000-
7eff220df000-
7fff11547000-
7fff115ff000-
ffffffffff60000
Aborted
What I expected
=============
I expected tlf not to crash.
Changed in tlf (Ubuntu): | |
status: | New → Confirmed |
tags: | added: patch |
I found it necessary to make 3 changes:
1. The 2 digit string for the current month was obtained incorrectly.
2. FIlling the line buffer with blanks was going 1 character too far.
3. Some strcat() operations exceeded the length of the log_line[4] buffer, so it was made longer.
With these changes, tlf will start, and accept callsign entries.