timer-applet crashed with NameError in bus_event()

[Martin Olsson]

Binary package hint: timer-applet

repro steps:
1. install timer-applet
2. kill gnome-panel to force it to reload (this is needed because of the unrelated bug 21625 )
3. right-click gnome panel and select add, then find "timer" in there and add it
4. right click the little egg timer icon on the panel and select preferences
5. select sound notification using the "default sound"
6. add a new timer event, set it to seconds and activate it
7. wait 2 seconds
8. crash happens

Steps 7 and 8 can be repeated again and again, they will reproduce the bug over and over again.

ProblemType: Crash
Architecture: amd64
Date: Thu Oct 8 20:24:41 2009
DistroRelease: Ubuntu 9.10
ExecutablePath: /usr/lib/timer-applet/timer-applet
InterpreterPath: /usr/bin/python2.6
Package: timer-applet 2.1.2-1
PackageArchitecture: all
ProcCmdline: python /usr/lib/timer-applet/timer-applet --oaf-activate-iid=OAFIID:TimerApplet_Factory --oaf-ior-fd=29
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-12.41-generic
PythonArgs: ['/usr/lib/timer-applet/timer-applet', '--oaf-activate-iid=OAFIID:TimerApplet_Factory', '--oaf-ior-fd=29']
SourcePackage: timer-applet
Title: timer-applet crashed with NameError in bus_event()
Traceback:
 Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/timerapplet/controllers/TimerApplet.py", line 97, in bus_event
     err, debug == message.parse_error()
 NameError: global name 'err' is not defined
Uname: Linux 2.6.31-12-generic x86_64
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

[Apport retracing service (apport)]

Thank you for taking the time to report this crash and helping to make Ubuntu better. This particular crash has already been reported and is a duplicate of bug #404978, so is being marked as such. Please look at the other bug report to see if there is any missing information that you can provide, or to see if there is a workaround for the bug. Additionally, any further discussion regarding the bug should occur in the other report. Please continue to report any other bugs you may find.

[Martin Olsson (mnemo)]

Unduping since 404978 is marked as private.

[Martin Olsson (mnemo)]

That Python line looks awfully weird actually:

    err, debug == message.parse_error()

Maybe they meant to use = instead of ==?

---

The line after that confirms that this bug only happens when it's trying to play sound:
    print 'Error playing sound: %s' % err, debug

[Martin Olsson (mnemo)]

Looks like this bug has been fixed in the upstream version already!
https://sourceforge.net/tracker/?func=detail&aid=2862819&group_id=127778&atid=709446

[Martin Olsson (mnemo)]

Here is the upstream patch:
http://timerapplet.git.sourceforge.net/git/gitweb.cgi?p=timerapplet/timerapplet;a=blobdiff;f=timer-applet/src/timerapplet/controllers/TimerApplet.py;h=916c20843e2e062b221366b60e6d75d6a5106bd9;hp=bcc856fcb5505188b8b231b13616912613d401e3;hb=18a21a2304bee4b62b36e4e6b68e1d0fef98f3b2;hpb=791426ab412206ebab5b441563f071dac4130e7a

[Martin Olsson (mnemo)]

I ran pylint on timer-applet now and it found more places in the code that will always crash if reached.

[Martin Olsson (mnemo)]

ANyway, even if I apply the upstream fix the audio still doesn't play (but the crash goes away).

[Martin Olsson (mnemo)]

Ah, here is the problem:

$ grep -ri DEFAULT_SOUND *
config.py:DEFAULT_SOUND_PATH = '/usr/share/sounds/gtk-events/clicked.wav'
$ aplay /usr/share/sounds/gtk-events/clicked.wav
/usr/share/sounds/gtk-events/clicked.wav: No such file or directory

So basically, the timer-applet has a dependency on a file which doesn't ship in that package and which is also not accounted for in any of the package dependencies list for the timer-applet package.

[Philipp Kern (pkern)]

Dear MOTU release,

this bug is basically a missing dependency on gnome-audio. I think an upload would be in order for this, right? Should I also fix the crash on the way using the patch that is linked in the bug log?

Kind regards,
Philipp Kern

[StefanPotyra (sistpoty)]

Yes, both are bugfix only, no need for an FFe.

[Martin Olsson (mnemo)]

Philip, please note that when the package "gnome-audio" is installed, it will uninstall "ubuntu-sounds" and thus also "ubuntu-desktop" because the "ubuntu-sounds" package has a conflicts tag pointing to "gnome-audio".

[StefanPotyra (sistpoty)]

There are no file conflicts in gnome-audio and ubuntu-sounds at the moment, so the conflicts there is wrong and should be dropped (or replaced by a versioned variant, in case there have been file conflicts in the past)

[Philipp Kern (pkern)]

Oh, well spotted, Martin.

That's LP: #343288, and it indeed still conflicts on /usr/share/sounds/card_shuffle.wav, AFAICS.

[StefanPotyra (sistpoty)]

indeed oversight from me.

[Martin Olsson (mnemo)]

Philip, will you set a new .wav file from ubuntu-sounds as the default sound in timer-applet or do you prefer to try uploading a new ubuntu-sounds version without the problematic conflicts line?

[Philipp Kern (pkern)]

ubuntu-sounds dropped the conflict (thanks to Luke), I'll upload timer-applet later today or tomorrow at last.

[Launchpad Janitor (janitor)]

This bug was fixed in the package timer-applet - 2.1.2-1ubuntu1

---------------
timer-applet (2.1.2-1ubuntu1) karmic; urgency=low

  * Copy changes from 2.1.2-3 in Debian. Both can be dropped with the next
    sync run post-karmic.
    - Depend on gnome-audio to pull in the sound file that is played when
      the timer finishes.
    - Apply upstream patch for wrong syntax in assigment, causing crashes.
      (LP: #446568)

 -- Philipp Kern <email address hidden> Mon, 12 Oct 2009 15:49:59 +0200