Comment 87 for bug 115484

Revision history for this message
In , Friedrich-beckmann (friedrich-beckmann) wrote :

(In reply to comment #79)
> >- either the GNU General Public License Version 2 or later (the "GPL"), or
> >- the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
> >+ either of the GNU General Public License Version 2 or later (the "GPL"),
> >+ or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
>
> Please don't change this. The license has to be a set format and wording as
> specified here: http://www.mozilla.org/MPL/boilerplate-1.1/
I reversed this. Now it complies to the template.
>
> Slightly better wording:
>
> "In HTML messages it is possible to embed images from remote sources. Opening
> such a message will open a connection to this external source. This may allow
> tracking of the message being read. Checking this box will allow such external
> embedded images in HTML messages from this contact."
I took your wording.
> >-<!ENTITY Notes.accesskey "N">
> >+
>
> No need for a blank line here, as long as there's just one new line after the
> last > we're fine.
Done.
> If you look at the existing code, <tabpanel> isn't necessary.
>
> You also have an extra <vbox> in here (after the <hbox>) that you don't need.
>
> Unfortunately, that means you still have an extra box element, so you need to
> re-indent the lines it encloses by two spaces.
>
> Once you have done this, please attach the full patch and a diff -w patch.
I removed the <tabpanel> and the useless <vboxes> and <hboxes>. The diff -U8 -w showed no difference to the diff -U8, so I only added the full patch.
>
> As you're now touching these lines, please can you wrap accesskey onto the next
> line and align it with the start of control. You may need to wrap the class
> attribute.
I did the wraps to have less line length overall.
>
> Mostly this is looking fine, I've verified it all seems to work on SM (both
> themes) & TB on Mac, I'll check it on Linux once you update the patch.
Thanks for review!