File -> Find in this folder: change catfish command

[DarkTrick]

Suggestion regarding the "Find in this folder"-custom action to improve UX for the thunar package.

Current situation
==================
"Find in this folder" will trigger `catfish --path=%f`. That means: "open catfish on the currently selected path, where "currently selected path" means either of the two:
1. If there is folder selected, open the path to inside that folder
2. If there is nothing selected, open the path to the currently open folder

Suggested behavior:
====================
Change command to `catfish --path=%d` (open catfish with the path of the currently viewed (open) folder)

Reason:
=======
1. I would say this is the expected behaviour for the general user.
2. The perception of "this" in "Find in this folder" seems to be stronger towards the currently viewed folder than the currently selected folder.

lsb_release -rd
===================
Description: Ubuntu 20.10
Release: 20.10

policykit
===========
thunar:
  Installed: 1.8.15-1
  Candidate: 1.8.15-1
  Version table:
 *** 1.8.15-1 500
        500 http://archive.ubuntu.com/ubuntu groovy/universe amd64 Packages
        100 /var/lib/dpkg/status

ProblemType: Bug
DistroRelease: Ubuntu 20.10
Package: thunar 1.8.15-1
ProcVersionSignature: Ubuntu 5.8.0-30.32-generic 5.8.17
Uname: Linux 5.8.0-30-generic x86_64
ApportVersion: 2.20.11-0ubuntu50.2
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: XFCE
Date: Mon Nov 30 18:25:47 2020
RebootRequiredPkgs:
 linux-image-5.8.0-31-generic
 linux-base
SourcePackage: thunar
UpgradeStatus: No upgrade log present (probably fresh install)

[DarkTrick (darktrick1337)]

Related file: https://git.launchpad.net/xubuntu-default-settings/tree/etc/xdg/xdg-xubuntu/Thunar/uca.xml.in#n55

[Sean Davis (bluesabre)]

I disagree with your assessment. If a user right-clicks on a folder, any actions displayed should be applicable to the selected ("this") folder. This matches with the other actions (open in new tab, etc) when right-clicking a folder.

Likewise, if a user right-clicks in the blank space of the current folder, they intend to act upon the current folder.