Bad substitutions in custom actions.

Bug #1761545 reported by Jacco van Schaik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Thunar File Manager
Fix Released
Medium
thunar (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When running a custom action without any files selected, the substitution parameters (%F, %f etc.) act as if the directory where the action was started is selected. That is, if I run the action in directory /a/b/c without any files selected, %f and %F expand to '/a/b/c', %d and %D expand to '/a/b', %n and %N expand to 'c'. If no files are selected, I would expect all those to be empty strings.

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: thunar 1.6.12-1
ProcVersionSignature: Ubuntu 4.13.0-38.43-generic 4.13.16
Uname: Linux 4.13.0-38-generic x86_64
NonfreeKernelModules: nvidia_uvm nvidia_drm nvidia_modeset nvidia
ApportVersion: 2.20.7-0ubuntu3.7
Architecture: amd64
Date: Thu Apr 5 19:00:32 2018
ExecutablePath: /usr/bin/thunar
InstallationDate: Installed on 2017-02-04 (425 days ago)
InstallationMedia: Xubuntu 16.10 "Yakkety Yak" - Release amd64 (20161012.2)
ProcEnviron:
 XDG_RUNTIME_DIR=<set>
 SHELL=/bin/zsh
 PATH=(custom, user)
 LANG=C.UTF-8
 LD_LIBRARY_PATH=<set>
SourcePackage: thunar
UpgradeStatus: Upgraded to artful on 2017-11-01 (154 days ago)

Revision history for this message
Jacco van Schaik (jacco-jaccovanschaik) wrote :
Revision history for this message
In , Theo Linkspfeifer (lastonestanding) wrote :

My suggested changes for plugins/thunar-uca/thunar-uca-editor.ui:

"the path to the first selected file" -> "the path to the first selected file or directory"
"the paths to all selected files" -> "the paths to all selected files and directories"

The remaining labels could be adjusted also, but those two changes may already be enough to clarify that the selection applies to files and directories.

Revision history for this message
In , Theo Linkspfeifer (lastonestanding) wrote :
Revision history for this message
In , Andreldm-2 (andreldm-2) wrote :

Makes sense.
Since we are about to release 1.8.2, let's wait for it before pushing those changes that require translation updates.

Revision history for this message
In , Gitbot (gitbot) wrote :

Andre Miranda referenced this bugreport in commit a3b4e7ce66a16f32750126b8086ed0487dae26f0

Improve description of UCA command parameters (Bug #14720)

https://git.xfce.org/xfce/thunar/commit?id=a3b4e7ce66a16f32750126b8086ed0487dae26f0

Revision history for this message
In , Gitbot (gitbot) wrote :

Andre Miranda referenced this bugreport in commit db640361b912594f725d4d5d038c7734b94da10b

Improve description of UCA command parameters (Bug #14720)

https://git.xfce.org/xfce/thunar/commit?id=db640361b912594f725d4d5d038c7734b94da10b

Changed in thunar:
importance: Unknown → Medium
status: Unknown → Fix Released
Revision history for this message
Theo Linkspfeifer (lastonestanding) wrote :

Fixed in Ubuntu 19.04 Disco Dingo. The behavior remains unchanged, but the description of the command parameters was improved.

Changed in thunar (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.