Thunar: "Open Terminal Here" breaks when any directory is deleted

[Nick Rose]

Thunar 1.6.3 in Xubuntu 14.10

How to reproduce:
1. Open Thunar.
2. Delete any directory in Thunar, e.g. /home/user/big-folder.
3. Stay in current directory or open any other directory without closing Thunar.
4. Select "File" -> "Open Terminal Here".

Result:
A dialogue box:

"Failed to launch preferred application for catagory "TerminalEmulator".
Failed to change to directory '/home/user/big-folder' (No such file or directory)."

[Xbzlhe (xbzlhe)]

Thunar 1.6.3 in Xubuntu 14.10

How to reproduce:
1. Open Thunar.
2. Delete any directory in Thunar, e.g. /home/user/big-folder.
3. Stay in current directory or open any other directory without closing Thunar.
4. Select "File" -> "Open Terminal Here".

Result:
The following dialogue box:

"Failed to launch preferred application for category "TerminalEmulator".
Failed to change to directory '/home/user/big-folder' (No such file or directory)."

[No Name Dot C (nonamedotc)]

I see this in Thunar 1.6.6 on Fedora 22 (pre-release) also.

[Hudd (hededrk)]

I was able to reproduce that in Thunar 1.6.6 on Arch Linux.

However, my actions were slightly different:
1. Create a folder.
2. Navigate into it, right-click “Open Terminal Here”
3. Close the terminal
4. Navigate to parent directory
5. Delete the newly created folder
6. Select in menu: “File” -> “Open Terminal Here”

New step here is step 2-3. Without it, Thunar for some reason “stays” in the directory where I've right-clicked most recently.

[Hjudt-l (hjudt-l)]

Probably a duplicate of bug #11749. Please try the patch attached there and report if it fixes the issue.

*** This bug has been marked as a duplicate of bug 11749 ***

[Hudd (hededrk)]

No, this is not a dupe of 11749. The bug appears when selecting custom actions from “File” menu, NOT the right-click menu.
Patch supplied for 11749 fixes issue described there, but it doesn't fix 11738.

[Hudd (hededrk)]

This bug is different from #11749. What happens here, is that Thunar gets “stuck” in a directory.
Custom actions don't disappear, they are just applied to a wrong folder.

[Hjudt-l (hjudt-l)]

To clarify: The other bug is not about disappearing custom "actions", only their shortcuts have disappeared (if assigned). However, I noticed a similar issue as described here has been fixed with that patch.

Now for this issue: I cannot reproduce the bug here, neither with the steps provided in the original report nor with those in comment #2. That is with current git master, and additionally with the patches from here: http://git.xfce.org/users/hjudt/thunar/log/?h=fix-bug-11008

Can you provide the custom action command you use? Also, what do you use to navigate to other folders and back?

Unsetting duplicate status.

[Hudd (hededrk)]

I've built Thunar from your git tree (http://git.xfce.org/users/hjudt/thunar/log/?h=fix-bug-11008), and this bug seems to be fixed there.

I tried this only with “Open Terminal here”, didn't try any other commands. Navigated using “Go back”, “Open the parent folder” and through “Places”.

[Hudd (hededrk)]

* I've meant git://git.xfce.org/users/hjudt/thunar

[Hjudt-l (hjudt-l)]

If you've tried the fix-bug-11008 branch and it fixes it, then this is a reload bug and doesn't have to do much with the custom actions themselves, the bug is only different symptoms.

If you have build the master branch from there, then I have no clue which commit fixed it, and you will have to bisect to find out. My private master branch is a bit older than the official one, and I have stopped tracking it due to conflicts. However, the fix-bug-11008 is based on the official master branch. Sorry for the confusion.

[Hudd (hededrk)]

Ok, I tried reproducing bug again on git master and fix-bug-11008 branch.

As it turns out, I didn't repeat my steps in the comment #2 properly ;)

> 2. Navigate into it, right-click “Open Terminal Here”

It is important to use right-click menu, not the “File” menu.

> 4. Navigate to parent directory

I navigate to the parent folder through button on toolbar or “Go -> Open Parent”

> 5. Delete the newly created folder

Bug appears when folder is deleted via “delete” on keyboard or “Edit -> Delete>", but doesn't when I use right-click menu.

> 6. Select in menu: “File” -> “Open Terminal Here”

Only happens with “File” menu, but not with right-click menu.

[Hjudt-l (hjudt-l)]

I am sorry, I still cannot reproduce this here :-/

[Hudd (hededrk)]

I checked put the git master (http://git.xfce.org/xfce/thunar/log/) again, and can't reproduce the bug there.
Strangely, fix didn't work the first time when I applied patch from the bug #11749 manually.

[Hjudt-l (hjudt-l)]

Make sure you killed the running thunar daemon and started a new instance. "-q" doesn't seem to always work reliably for reasons unknown. Also, please give it a few more tries just to be sure it is not a nasty bug that only happens sometimes.

[Hudd (hededrk)]

Tested it again few times, seems like it's fixed.

I guess, I'll report it again, if I notice it appearing.

[Hjudt-l (hjudt-l)]

I'm closing this as a duplicate of #11749, patch is already pushed to git master. Feel free to reopen if the bug reappears.

*** This bug has been marked as a duplicate of bug 11749 ***

[Theo Linkspfeifer (lastonestanding)]

Should be fixed in Xubuntu 18.04 (Thunar 1.6.7+).