vs-thumb should not rely on standard streams to communicate result image back
Bug #1556835 reported by
Thomas Voß
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
Alejandro J. Cura | ||
thumbnailer (Ubuntu) |
Fix Released
|
High
|
Michi Henning |
Bug Description
vs-thumb right now streams extracted data to stdout by default (see [1]). The approach is brittle in the sense that any component (e.g., gstreamer or gstreamer plugin) writing to stdout can easily break the thumbnail. We have zero control over stdout and should thus either:
(1.) Rely on specifying an explicit temporary destination file or
(2.) Open a dedicated communication pipe to communicate back the resulting thumbnail to the calling process.
Please also see [2.] for the respective product bug.
[1.] http://
[2.] https:/
Related branches
lp:~michihenning/thumbnailer/vs-thumb-pipe-fix
- James Henstridge: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 1103 lines (+342/-226)12 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+7/-0)
include/internal/gobj_memory.h (+0/-1)
include/internal/imageextractor.h (+13/-0)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.cpp (+1/-1)
src/imageextractor.cpp (+102/-8)
src/thumbnailer.cpp (+11/-10)
src/vs-thumb/test-seq.cpp (+15/-38)
src/vs-thumb/thumbnailextractor.cpp (+36/-31)
src/vs-thumb/thumbnailextractor.h (+7/-4)
src/vs-thumb/vs-thumb.cpp (+68/-45)
tests/vs-thumb/vs-thumb_test.cpp (+81/-87)
Changed in canonical-device-images: | |
importance: | Undecided → Critical |
status: | New → Confirmed |
Changed in thumbnailer (Ubuntu): | |
status: | Confirmed → In Progress |
affects: | canonical-device-images → canonical-devices-system-image |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Alejandro J. Cura (alecu) |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Writing via a temp file is way more expensive. (The old thumbnailer did that.)
Dedicated pipe sounds like the way to go.