Fix CPU thermal sensors enumeration

Bug #2054391 reported by Kai-Heng Feng
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
thermald (Ubuntu)
Fix Released

Bug Description

Some CPU sensors are not enumerated, this can make thermald deviates from the correct behavior of the CPU TDP.

Traverse all sensors under hwmon sysfs directory to make sure everything is enumerated.

Check the output of thermald. Once the fix is in place, thermal zones that are previously omitted now shows up:
[INFO]Zone 1: AMBF, Active:1 Bind:1 Sensor_cnt:1

[Where problems could occur]
Since the new logic traverse the whole hwmon sysfs, the startup time can take slightly longer.

Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

debdiff for Jammy.

Changed in thermald (Ubuntu):
status: New → Fix Released
Changed in thermald (Ubuntu Jammy):
status: New → Confirmed
importance: Undecided → Medium
tags: added: oem-priority originate-from-2050867 somerville
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the patch @Kai-Heng! I took a look and in general it looks good, but I'd like to ask you to add some DEP-3 headers [1] to your patch, that will give us (packagers) more context when revisiting this package for whatever reason.

Now a personal opinion, I like when the patch file name is listed in the changelog entry ("* d/p/0016-Fixed-enumeration-of-cpu-thermal-sensors.patch: <what_this_is_fixing>"). It makes a direct link between the change listed there and the file actually fixing it.

Once you address my first comment at least (the second one is not mandatory), please subscribe ~ubuntu-sponsors again (I am unsubscribing it now).


Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

DEP-3 headers and changelog entry added.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.